Bug 429356 - Please make qtwebengine dependency optional
Summary: Please make qtwebengine dependency optional
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: 2.23.0
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: 25.1.0
Assignee: Guillaume DE BURE
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-19 16:44 UTC by Luke-Jr
Modified: 2020-12-07 21:01 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luke-Jr 2020-11-19 16:44:23 UTC
QtWebEngine often has critical security vulnerabilities and slow to fix them. Can Skrooge do without (perhaps absent some features)?
Comment 1 Stephane MANKOWSKI 2020-11-19 21:06:21 UTC
Hi,

When you build Skrooge, you can choose if you want to build it with WebEngineWidgets or WebKitWidgets.

For that, you have to use -DSKG_WEBENGINE=OFF|ON in your CMake commande.

Is it acceptable or do you want to be able to build Skrooge without web engine included ? Of course, this will remove some important features ("Monthly reports", ...)
Comment 2 Luke-Jr 2020-11-20 00:22:07 UTC
QtWebKit seems to be even less maintained.

I understand that building with neither may lose functionality.
(Although maybe you can still generate reports and XDG-open them?)
Comment 3 Stephane MANKOWSKI 2020-12-06 20:08:04 UTC
Git commit 436fe5bff964c9a05a4bba52872a72bdd8c96400 by Stephane MANKOWSKI.
Committed on 06/12/2020 at 20:07.
Pushed by smankowski into branch 'master'.

Please make qtwebengine dependency optional

M  +5    -0    CHANGELOG
M  +12   -5    CMakeLists.txt
M  +3    -3    README
M  +5    -4    appimage.yml
M  +-    --    images/splash.png
M  +5032 -4359 images/splash.svg.in
M  +4    -0    plugins/generic/skg_file/tests/CMakeLists.txt
M  +4    -0    plugins/generic/skg_monthly/CMakeLists.txt
M  +18   -11   plugins/generic/skg_monthly/skgmonthlyplugin.cpp
M  +10   -2    plugins/generic/skg_monthly/skgmonthlyplugin.h
M  +12   -4    plugins/generic/skg_monthly/skgmonthlypluginwidget.cpp
M  +4    -0    plugins/generic/skg_print/CMakeLists.txt
M  +16   -4    plugins/generic/skg_print/skgprintplugin.cpp
M  +11   -4    plugins/generic/skg_print/skgprintplugin.h
M  +4    -0    plugins/skrooge/skrooge_bank/CMakeLists.txt
M  +4    -0    plugins/skrooge/skrooge_report/CMakeLists.txt
M  +4    -0    plugins/skrooge/skrooge_report/tests/CMakeLists.txt
M  +4    -0    plugins/skrooge/skrooge_unit/CMakeLists.txt
M  +2    -2    scripts/skrooge-release.py
M  +7    -2    skgbankgui/CMakeLists.txt
M  +7    -2    skgbankguidesigner/CMakeLists.txt
M  +7    -2    skgbasegui/CMakeLists.txt
M  +2    -1    skgbasegui/skgtablewithgraph.cpp
M  +13   -4    skgbasegui/skgtabpage.cpp
M  +0    -3    skgbasegui/skgtabpage.h
M  +44   -12   skgbasegui/skgwebview.cpp
M  +141  -116  skgbasegui/skgwebview.h
M  +7    -2    skgbaseguidesigner/CMakeLists.txt
M  +4    -0    skrooge/CMakeLists.txt
M  +1    -1    snapcraft.yaml
M  +4    -0    tests/skgbaseguitest/CMakeLists.txt

https://invent.kde.org/office/skrooge/commit/436fe5bff964c9a05a4bba52872a72bdd8c96400
Comment 4 Andreas Sturmlechner 2020-12-07 00:15:36 UTC
Is there a technical reason why deprecated old Qt5WebKit is preferred by default over Qt5WebEngine?
Comment 5 Stephane MANKOWSKI 2020-12-07 21:01:58 UTC
Qt5WebKit is the first implementation.
Qt5WebEngine is an alternative but doesn't work as well the first one (print issue).

That's why Qt5WebKit is still the default.