Bug 429330 - Album view has gaps at the top and bottom
Summary: Album view has gaps at the top and bottom
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: HI normal
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-11-19 02:21 UTC by Bruno Guedes
Modified: 2020-11-19 21:44 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 20.12


Attachments
open elisa in the album view (3.86 MB, image/png)
2020-11-19 02:22 UTC, Bruno Guedes
Details
scroll down until the albuns get coverd by the search bar (2.90 MB, image/png)
2020-11-19 02:24 UTC, Bruno Guedes
Details
open an album and see the gaps at the bottom and top (2.90 MB, image/png)
2020-11-19 02:25 UTC, Bruno Guedes
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Guedes 2020-11-19 02:21:44 UTC
VERSION: 20.08.3+p20.40+git20201119.0111-0

SUMMARY

when opening an album in elisa while in the albums view, if the screen is scrolled down a little, you might see that the albums view is still visible through gaps at the bottom and at the top of the screen.

Obs.: this bug depends on the size of the window, if it is to small it will not happen, but I can reproduce it 100% of the times if I have the window maximazed.


STEPS TO REPRODUCE
1. open elisa and go to the albums screen
2. scroll the page just so the album covers get partially covered by the search bar 
3. open one of the albums and see there is a space at the top and bottom of the window that does not get covered.

SOFTWARE/OS VERSIONS

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.1
Kernel Version: 5.4.0-52-generic
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-6200U CPU @ 2.30GHz
Memory: 7,2 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 520
Comment 1 Bruno Guedes 2020-11-19 02:22:42 UTC
Created attachment 133448 [details]
open elisa in the album view
Comment 2 Bruno Guedes 2020-11-19 02:24:44 UTC
Created attachment 133449 [details]
scroll down until the albuns get coverd by the search bar
Comment 3 Bruno Guedes 2020-11-19 02:25:54 UTC
Created attachment 133450 [details]
open an album and see the gaps at the bottom and top
Comment 4 Nate Graham 2020-11-19 20:52:30 UTC
Can reproduce. Seems like a recent regression. Will look into it.
Comment 5 Nate Graham 2020-11-19 21:37:28 UTC
Git bisect gives nonsensical results because apparently is is only sometimes reproducible...
Comment 6 Nate Graham 2020-11-19 21:42:10 UTC
Found it. Fix incoming.
Comment 7 Nate Graham 2020-11-19 21:44:36 UTC
Git commit de73a5dc83a6e839e2b14f0483a7b2c341f05745 by Nate Graham.
Committed on 19/11/2020 at 21:43.
Pushed by ngraham into branch 'release/20.12'.

Remove unneeded margins around list browser view

This margin causes the parent view to be visible underneath it.
FIXED-IN: 20.12

M  +0    -1    src/qml/ListBrowserView.qml

https://invent.kde.org/multimedia/elisa/commit/de73a5dc83a6e839e2b14f0483a7b2c341f05745