Bug 429281 - Checkmark button is too close to location bar at 100% scale (fine at higher scale)
Summary: Checkmark button is too close to location bar at 100% scale (fine at higher s...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: URL navigator (show other bugs)
Version: 5.76.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: KIO Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-18 03:23 UTC by guimarcalsilva
Modified: 2020-11-23 17:41 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Checkmark icon is too close to address bar (15.28 KB, image/png)
2020-11-18 03:23 UTC, guimarcalsilva
Details
Mockup of what could be done (29.66 KB, image/png)
2020-11-18 03:38 UTC, guimarcalsilva
Details
Looks fine to me (43.49 KB, image/jpeg)
2020-11-18 16:21 UTC, Nate Graham
Details
125% scaling on Xorg (32.54 KB, image/png)
2020-11-20 23:55 UTC, guimarcalsilva
Details
125% scaling on Wayland. (65.51 KB, image/png)
2020-11-20 23:56 UTC, guimarcalsilva
Details
After new update - 20 of november. (37.82 KB, image/png)
2020-11-21 00:53 UTC, guimarcalsilva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description guimarcalsilva 2020-11-18 03:23:26 UTC
Created attachment 133423 [details]
Checkmark icon is too close to address bar

SUMMARY

Now that the address bar lives on the top bar when you click to type a location you can see the checkmark button is too close to the location bar. I believe there should be some padding to the right. Check screenshot.

Maybe the location bar itself could have padding on the left and right sides so it won't be too close from buttons. That way it would make it harder to accidentally press on the bar instead of nearby buttons.


Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.1
Kernel Version: 5.4.0-54-generic
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-9400F CPU @ 2.90GHz
Memory: 3,8 GiB of RAM
Graphics Processor: SVGA3D; build: RELEASE; LLVM;
Comment 1 guimarcalsilva 2020-11-18 03:31:16 UTC
I should add why I think this change should be made: The spacing is visually jarring because there's a huge space between the right of the checkmark icon and the split button, while at the same time there's little to no space between the location bar and the checkmark icon. An argument could be made about making them closer to indicate they are related, however they still look like separate things because the check icon is neither inside the location bar nor have a color that would indicate it's different from the buttons to the right.
Comment 2 guimarcalsilva 2020-11-18 03:38:59 UTC
Created attachment 133424 [details]
Mockup of what could be done

Mockup of what could be done - Spacing between location bar and icons and fixed spacing between checkmark icon in relation to the location bar.
Comment 3 Nate Graham 2020-11-18 16:21:03 UTC
Created attachment 133436 [details]
Looks fine to me

Cannot reproduce, looks fine to me with the default font (Noto Sans 10pt)
Comment 4 guimarcalsilva 2020-11-20 23:36:06 UTC
(In reply to Nate Graham from comment #3)
> Created attachment 133436 [details]
> Looks fine to me
> 
> Cannot reproduce, looks fine to me with the default font (Noto Sans 10pt)

That's odd. I didn't know it was a problem on my end. I'm also using Noto Sans 10pt and I also have the default Breeze theme. I should note my resolution is 1920x1080 and i'm not applying any kind of scaling (1x). I'm also running it using a VMWare virtual machine.
Comment 5 guimarcalsilva 2020-11-20 23:39:29 UTC
Wait. I think I've found the reason:

I'm testing it now and apparently the issue is present on both Xorg and Wayland >only< when using 100% scaling. If I set the scaling for anything higher the issue is not present.
Comment 6 Nate Graham 2020-11-20 23:42:37 UTC
Interesting. I'm using 200%, so that's probably why I don't see it. I can reproduce the issue at 100% scale.
Comment 7 guimarcalsilva 2020-11-20 23:52:08 UTC
(In reply to Nate Graham from comment #6)
> Interesting. I'm using 200%, so that's probably why I don't see it. I can
> reproduce the issue at 100% scale.

Wait, wait again! I noticed the spacing is different between Xorg and Wayland when using fractional scaling. I will attach the results on both Xorg and Wayland at 125%.


(This is unrelated, but I wanna know if this is a known issue: I also noticed Spectacle on Wayland is showing me a smaller "secondary desktop" if I select the option to screenshot only a retangular area. That is only happening when using scaling. Is that normal?)
Comment 8 guimarcalsilva 2020-11-20 23:55:11 UTC
Created attachment 133511 [details]
125% scaling on Xorg

125% scaling on Xorg - The checkmark button much closer on the left side while using Xorg.
Comment 9 guimarcalsilva 2020-11-20 23:56:09 UTC
Created attachment 133512 [details]
125% scaling on Wayland.

When using 125% scaling on Wayland the padding on the button seems more proportional.
Comment 10 guimarcalsilva 2020-11-21 00:53:05 UTC
Created attachment 133514 [details]
After new update - 20 of november.

Wow. This gotta be the fastest bug fix in history. 😁 I mean, not really, but while I was making some experiments I decided to update KDE just in case (last time I updated the virtual machine was when I reported the bug) and apparently it's better now. I don't know if it's looking like it's supposed to be, but it's not too close anymore at 100% scale. Apparently before updating I didn't have the double ring focus on text fields, and now I do.

One thing I noticed is that scaling higher than 100% specifically on Wayland still makes the checkbox padding look bigger than Xorg.
Comment 11 Nate Graham 2020-11-23 17:41:06 UTC
Heh yeah that change came from Breeze itself. If you're happy with the way it looks now, we can call it fixed. :)