Bug 429226 - Right click context menu has misaligned underlines and duplicate underline below title
Summary: Right click context menu has misaligned underlines and duplicate underline be...
Status: REOPENED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-17 05:38 UTC by Raghavendra kamath
Modified: 2023-01-09 14:23 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Transform tool context menu (76.00 KB, image/jpeg)
2020-11-17 06:30 UTC, David Conner
Details
Selection tool context menu (118.73 KB, image/jpeg)
2020-11-17 06:32 UTC, David Conner
Details
screenshot of transform tool context menu (18.58 KB, image/png)
2020-11-17 06:37 UTC, Raghavendra kamath
Details
some miss aligment of the border and underlines bleeding out can be seen here (16.53 KB, image/png)
2020-11-17 06:37 UTC, Raghavendra kamath
Details
attachment-14898-0.html (2.58 KB, text/html)
2020-11-17 08:35 UTC, David Conner
Details
Transform Tool context menu on Cinnamon + Mint + fusion (96.91 KB, image/png)
2020-11-18 14:16 UTC, Tiar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Raghavendra kamath 2020-11-17 05:38:39 UTC
SUMMARY

In recent build from master, The right click context menu has bit weirdness.
The title of the context menu has bigger rectangle than the rest of the menu. There is a duplicate divider line under the title section. In the context menu for Transform tool the letter 'T' is hidden. 

The glitch can be clearly seen in the breeze theme, While in fusion you can see the duplicate divider line appearing right besides the title text.



STEPS TO REPRODUCE
1. Open Krita nightly or latest build from git master
2. Activate breeze theme and activate the selection tool or transform tool.
3. Right click on the canvas. If you see the transform tool context menu you can see the missing T

OBSERVED RESULT
Context menu layout has glitch

EXPECTED RESULT
the layout should be clean with proper padding and clear text in both theme

Operating System: Arch Linux
KDE Plasma Version: 5.20.3
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.1
Kernel Version: 5.9.8-arch1-1
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-4790K CPU @ 4.00GHz
Memory: 31.3 GiB of RAM
Graphics Processor: GeForce GTX 750 Ti/PCIe/SSE2
Comment 1 David Conner 2020-11-17 06:30:05 UTC
Created attachment 133392 [details]
Transform tool context menu
Comment 2 David Conner 2020-11-17 06:32:24 UTC
Created attachment 133393 [details]
Selection tool context menu
Comment 3 David Conner 2020-11-17 06:34:04 UTC
(In reply to Raghavendra kamath from comment #0)
> In recent build from master, The right click context menu has bit weirdness.
> The title of the context menu has bigger rectangle than the rest of the
> menu. There is a duplicate divider line under the title section. In the
> context menu for Transform tool the letter 'T' is hidden. 
> 
> The glitch can be clearly seen in the breeze theme, While in fusion you can
> see the duplicate divider line appearing right besides the title text.

Raghavendra, I am not seeing this bug. I have the Breeze theme active (with one or two deviations from the global theme, I believe). I just built Krita a few hours ago. I attached some screenshots.
Comment 4 Raghavendra kamath 2020-11-17 06:37:08 UTC
Created attachment 133394 [details]
screenshot of transform tool context menu

This is showing correct alignment now. might have been some glitch when I built from git.
Comment 5 Raghavendra kamath 2020-11-17 06:37:59 UTC
Created attachment 133395 [details]
some miss aligment of the border and underlines bleeding out can be seen here

@David 

Thanks I think it was some glitch on my build. It is now center aligned like you show in the screenshot. But there is double under line and the title part is still a pixel or two bigger than the rest
Comment 6 David Conner 2020-11-17 08:35:09 UTC
Created attachment 133397 [details]
attachment-14898-0.html

I just found the theme options inside the Krita app. I only have my KDE
desktop set to breeze, so I’m not sure whether that would affect the output.

2020年11月17日(火) 午前1:38 Raghavendra kamath <bugzilla_noreply@kde.org>:

> https://bugs.kde.org/show_bug.cgi?id=429226
>
> --- Comment #5 from Raghavendra kamath <raghu@raghukamath.com> ---
> Created attachment 133395 [details]
>   --> https://bugs.kde.org/attachment.cgi?id=133395&action=edit
> some miss aligment of the border and underlines bleeding out can be seen
> here
>
> @David
>
> Thanks I think it was some glitch on my build. It is now center aligned
> like
> you show in the screenshot. But there is double under line and the title
> part
> is still a pixel or two bigger than the rest
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
Comment 7 Tiar 2020-11-18 14:16:47 UTC
Created attachment 133431 [details]
Transform Tool context menu on Cinnamon + Mint + fusion

I cannot reproduce some elements being bigger than others. @Raghu do you have a high dpi display (do you use UI scaling)?

I see an additional line but it's on the side of the text, not underneath.

This is on Mint + Cinnamon + fusion, with some custom font.
Comment 8 Raghavendra kamath 2020-11-18 14:40:44 UTC
No I don't have hidpi display. My screen resolution is 2560 x 1440. 

The line moves alongside of the text if you use fusion but gets under the text if you use Breeze.
Comment 9 wolthera 2021-09-08 08:18:01 UTC
Another thing to keep in mind is that Raghukamath proly has a more up-to-date version of breeze.

I suspect this is a theme issue. If anyone wants to work on it, the code for the context menu is in KisSelectionToolHelper::getSelectionContextMenu(KisCanvas2* canvas) (kis_selection_tool_helper.cpp, ln 340), but as you can see there, there's no unique code there, only that the 'larger' text is in fact the 'section title', so someone would have to modify breeze?

I will mark this is as resolved/upstream, unless halla thinks it's better to move it to Breeze?
Comment 10 Raghavendra kamath 2021-09-08 10:57:09 UTC
This is an issue in Fusion too. In fusion instead of double outline we have half line in front of the title.
Comment 11 Halla Rempt 2023-01-09 14:23:44 UTC
QT 5.15 TEST