Bug 429225 - discover cannot be compiled against older appstream (bump required version)
Summary: discover cannot be compiled against older appstream (bump required version)
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-17 04:38 UTC by Leszek Lesner
Modified: 2020-11-17 17:34 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/discover/commit/166c45f8576980f3a1e658e2fc5d20ac3b243252
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Leszek Lesner 2020-11-17 04:38:22 UTC 
SUMMARY
Dependency for Appstream is too low. Does not compile with 0.12.5

STEPS TO REPRODUCE
1. Try compiling discover with appstream 0.12.5

OBSERVED RESULT
error: 'class AppStream::Pool' has no member named 'lastError'


EXPECTED RESULT
Compile fine

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: master
(available in About System)
KDE Plasma Version: master
KDE Frameworks Version: master
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Changing the requirement to 0.12.8 would be advises. This seems to be the lowest version it compiles correctly without above error.
Comment 1 Nate Graham 2020-11-17 17:32:46 UTC 
Oops. Will fix.
Comment 2 Nate Graham 2020-11-17 17:34:03 UTC 
Git commit 166c45f8576980f3a1e658e2fc5d20ac3b243252 by Nate Graham.
Committed on 17/11/2020 at 17:33.
Pushed by ngraham into branch 'master'.

Fix minimum required appstream version

It doesn't compile with anything earlier than 0.12.8, so let's make that
the minimum version.

M  +1    -1    CMakeLists.txt

https://invent.kde.org/plasma/discover/commit/166c45f8576980f3a1e658e2fc5d20ac3b243252