Bug 429167 - Appearance options aren't preserved
Summary: Appearance options aren't preserved
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-15 18:41 UTC by Richard Llom
Modified: 2020-12-03 07:38 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Llom 2020-11-15 18:41:54 UTC
The appearance options for a line chart, like smooth lines aren't preserved between application restarts.
Also the option "Show Title" doesn't seem to do anything for me...

See also  bug 429155
Comment 1 Bug Janitor Service 2020-11-24 08:44:15 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/101
Comment 2 David Redondo 2020-11-24 12:13:36 UTC
Git commit 744bccf477457e29da1dacda6d75ef05a0f4b15f by David Redondo.
Committed on 24/11/2020 at 12:12.
Pushed by davidre into branch 'master'.

Write entries if face config changes

If we should not sync we correctly disable autosave. This disables writing to
the config and syncing it. However we still want to write to the config even
if the config should not be synced automatically, so when it is externally
synced the values are saved. This is the same method uses for the other config
properties, for example compare with setTitle().
Related: bug 429155, bug 429367

M  +6    -0    faces/SensorFaceController.cpp

https://invent.kde.org/plasma/libksysguard/commit/744bccf477457e29da1dacda6d75ef05a0f4b15f
Comment 3 David Redondo 2020-11-24 12:14:34 UTC
Git commit 984148d39df3da1d726aec9bf8e741ec2c840541 by David Redondo.
Committed on 24/11/2020 at 12:14.
Pushed by davidre into branch 'Plasma/5.20'.

Write entries if face config changes

If we should not sync we correctly disable autosave. This disables writing to
the config and syncing it. However we still want to write to the config even
if the config should not be synced automatically, so when it is externally
synced the values are saved. This is the same method uses for the other config
properties, for example compare with setTitle().
Related: bug 429155, bug 429367


(cherry picked from commit 744bccf477457e29da1dacda6d75ef05a0f4b15f)

M  +6    -0    faces/SensorFaceController.cpp

https://invent.kde.org/plasma/libksysguard/commit/984148d39df3da1d726aec9bf8e741ec2c840541
Comment 4 Richard Llom 2020-11-28 20:41:21 UTC
For me its not fixed, same with bug 429155.

I'm using the AUR to build from source.
KDE Frameworks 5.76.0
Qt 5.15.1 (built against 5.15.1)
Comment 5 David Redondo 2020-11-30 11:28:50 UTC
Hmm the two things you mention are done in a different way. Does neither "Show title, nor "smooth lines" work?
Comment 6 Richard Llom 2020-11-30 20:38:36 UTC
Yes, neither of them works. Also Data Range isn't preserved.

Is there any way I can make sure I have the up to date version?

Under About it just says System Monitor 5.20.80 and the usual info (which I cannot select to copy, btw :-().
Comment 7 David Redondo 2020-12-01 07:30:34 UTC
Do you have libksysguard from master too? I suspect it could be that you have an older version given that "Show title" is not working either
Comment 8 Richard Llom 2020-12-02 19:41:16 UTC
Aw, my bad. Switched to libksysguard-git and this resolved those, however some other weird issues popped up. 
How/where can I delete the config for plasma-systemmonitor?
Comment 9 David Redondo 2020-12-03 07:38:09 UTC
To reset the default pages or delete  your custom ones you can either do it from plasma-systemmonitor "Edit Pages..." in the menu or delete the files ~/.local/share/plasma-systemmonitor.
The config is in  ~/.config/systemmonitorrc