Bug 429115 - Misaligned text in Discover and some KCMs
Summary: Misaligned text in Discover and some KCMs
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.76.0
Platform: Arch Linux Linux
: VHI normal
Target Milestone: Not decided
Assignee: Carl Schwan
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-11-14 20:51 UTC by Patrick Silva
Modified: 2020-11-18 15:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.77


Attachments
Touchpad KCM (65.94 KB, image/png)
2020-11-14 20:51 UTC, Patrick Silva
Details
Discover (224.27 KB, image/png)
2020-11-14 20:51 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-11-14 20:51:15 UTC
Created attachment 133340 [details]
Touchpad KCM

SUMMARY
This bug appeared on Arch Linux after update to frameworks 5.76, Neon unstable is also affected.
Discover and some KCMs (Touchpad, Mouse, Notifications, Display Configuration and General Behavior, for example) are affected.
See the attached screenshots showing Discover and Touchpad KCM please.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.1
Comment 1 Patrick Silva 2020-11-14 20:51:54 UTC
Created attachment 133341 [details]
Discover
Comment 2 Nate Graham 2020-11-16 19:36:27 UTC
I was just noticing this today and was about to file a bug. Can confirm. Most likely a regression in Kirigami Formlayout label alignment.
Comment 3 Nate Graham 2020-11-16 19:40:13 UTC
Caused by https://invent.kde.org/frameworks/kirigami/-/commit/e522336901d45b7ac517c1ce7d3e5dd9d03ce6ab.

Reverting that again... :(

Unfortunately the bad commit made it into frameworks 5.76 :( :(
Comment 4 Nate Graham 2020-11-16 19:43:52 UTC
Git commit 9286912501d734b10be3f53c35996fc2b4353b84 by Nate Graham.
Committed on 16/11/2020 at 19:41.
Pushed by ngraham into branch 'master'.

Revert "[FormLayout]: Wrap section headers"

This reverts commit e522336901d45b7ac517c1ce7d3e5dd9d03ce6ab.

This commit still caused regressions. Clearly FormLayout label
adjustments need a *lot* more testing before any changes are
made, and changes shouldn't be pushed right before Frameworks
tagging.
FIXED-IN: 5.77
CCMAIL: uhhadd@gmail.com

M  +1    -4    src/controls/FormLayout.qml

https://invent.kde.org/frameworks/kirigami/commit/9286912501d734b10be3f53c35996fc2b4353b84
Comment 5 Nate Graham 2020-11-16 20:00:14 UTC
Found another cause: https://invent.kde.org/frameworks/kirigami/-/merge_requests/146#note_137508

Carl, can you investigate and fix?
Comment 6 Nate Graham 2020-11-18 15:46:38 UTC
Fixed in Kirigami git master now, to be released with 5.77.