Bug 429039 - Setting play count does not work
Summary: Setting play count does not work
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-13 02:33 UTC by Nate Graham
Modified: 2020-11-17 22:28 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 20.12
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2020-11-13 02:33:18 UTC
Editing the play count of a file does not seem to work. The value always seems to be reset to its prior value.
Comment 1 Matthieu Gallien 2020-11-17 15:16:53 UTC
This was not intended as being modifiable by the user (at least as a first step).

This is the same for the other statistics related fields like (first play date, last play date, play frequency).

As a second step, we should again have a look at the possibility to save that in the music files. In this case, we should allow editing by the user.

Do you agree with this plan ?
Comment 2 Nate Graham 2020-11-17 17:46:37 UTC
Yeah, pretty much.

If these fields are not intended to be user-modifiable, then we should not allow them to be modified in the details window.

I agree with writing the data into the file. That would be nice. Not totally sure if it makes sense to allow the user to manually modify them though. Your call.
Comment 3 Bug Janitor Service 2020-11-17 20:43:52 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/189
Comment 4 Matthieu Gallien 2020-11-17 22:27:50 UTC
Git commit e7546560c3c1608a42745ad36b5196d5e2af7864 by Matthieu Gallien.
Committed on 17/11/2020 at 20:41.
Pushed by mgallien into branch 'release/20.12'.

use a role of the model to also choose the correct delegate for metadata

M  +35   -23   src/qml/MediaTrackMetadataView.qml

https://invent.kde.org/multimedia/elisa/commit/e7546560c3c1608a42745ad36b5196d5e2af7864