Can you please attach
smartctl --all --json /dev/sdc

Without that output I can't really tell anything at all.

Created attachment 133265 [details]
Output of sudo smartctl --all --json /dev/sdc

Andrius Štikonas <bugzilla_noreply@kde.org> requested the output.

Created attachment 133266 [details]
attachment-31212-0.html

I've added the output as an attachment to the bug report.

Thanks for looking into it.

On Thu, Nov 12, 2020 at 10:51 AM Andrius Štikonas <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=429028
>
> --- Comment #1 from Andrius Štikonas <andrius@stikonas.eu> ---
> Can you please attach
> smartctl --all --json /dev/sdc
>
> Without that output I can't really tell anything at all.
>
> --
> You are receiving this mail because:
> You reported the bug.

> I've added the output as an attachment to the bug report.
> 
> Thanks for looking into it.
> 

Thanks for attaching it. I haven't really looked at it much yet. And wouldn't have much time during workdays anyway. Maybe over weekend...

Does plasma-disks (accessible in Info Center) show SMART status for these drives?

Created attachment 133317 [details]
plasma-disks info center

Created attachment 133318 [details]
attachment-29622-0.html

The SMART status does show for these disks in Info Center.

On Fri, Nov 13, 2020 at 7:15 AM Nate Graham <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=429028
>
> Nate Graham <nate@kde.org> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |nate@kde.org
>
> --- Comment #5 from Nate Graham <nate@kde.org> ---
> Does plasma-disks (accessible in Info Center) show SMART status for these
> drives?
>
> --
> You are receiving this mail because:
> You reported the bug.

(In reply to Nathan Kinney from comment #6)
> Created attachment 133317 [details]
> plasma-disks info center

Thanks for confirming this (even though I expected plasma disks to work).

I guess it's a bug in parsing json structures that are returned by smartctl.

Same bug.
For 1 of my drives smartctl returns non 0 exit status.
Because exit status of smartctl is not simple success or failure report but a bitfield.

Citation from the man:
```
EXIT STATUS
The exit statuses of smartctl are defined by a bitmask.  If all is well with the disk, the  exit  status  (return  value)  of
smartctl  is  0  (all bits turned off).  If a problem occurs, or an error, potential error, or fault is detected, then a non-
zero status is returned.  In this case, the eight different bits in the exit status  have  the  following  meanings  for  ATA
disks; some of these values may also be returned for SCSI disks.

Bit 0: Command line did not parse.

Bit 1: Device open failed, device did not return an IDENTIFY DEVICE structure, or device is in a low-power mode (see '-n' op‐
tion above).

Bit 2: Some SMART or other ATA command to the disk failed, or there was a checksum error in a SMART data structure (see  '-b'
option above).

Bit 3: SMART status check returned "DISK FAILING".

Bit 4: We found prefail Attributes <= threshold.

Bit 5: SMART  status  check returned "DISK OK" but we found that some (usage or prefail) Attributes have been <= threshold at
some time in the past.

Bit 6: The device error log contains records of errors.

Bit 7: The device self-test log contains records of errors.  [ATA only] Failed self-tests outdated by a newer successful  ex‐
tended self-test are ignored.
```

And I see exitstatus 64 for /dev/sdb & partition manager traits this as error.
(see this check: https://invent.kde.org/system/kpmcore/-/blob/ad35460628f82c5025f7e5600b6d15cfcdf75d42/src/core/smartparser.cpp#L120).

(In reply to Yaroslav Sidlovsky from comment #9)
> Same bug.
> For 1 of my drives smartctl returns non 0 exit status.
> Because exit status of smartctl is not simple success or failure report but
> a bitfield.
> 
> Citation from the man:
> ```
> EXIT STATUS
> The exit statuses of smartctl are defined by a bitmask.  If all is well with
> the disk, the  exit  status  (return  value)  of
> smartctl  is  0  (all bits turned off).  If a problem occurs, or an error,
> potential error, or fault is detected, then a non-
> zero status is returned.  In this case, the eight different bits in the exit
> status  have  the  following  meanings  for  ATA
> disks; some of these values may also be returned for SCSI disks.
> 
> Bit 0: Command line did not parse.
> 
> Bit 1: Device open failed, device did not return an IDENTIFY DEVICE
> structure, or device is in a low-power mode (see '-n' op‐
> tion above).
> 
> Bit 2: Some SMART or other ATA command to the disk failed, or there was a
> checksum error in a SMART data structure (see  '-b'
> option above).
> 
> Bit 3: SMART status check returned "DISK FAILING".
> 
> Bit 4: We found prefail Attributes <= threshold.
> 
> Bit 5: SMART  status  check returned "DISK OK" but we found that some (usage
> or prefail) Attributes have been <= threshold at
> some time in the past.
> 
> Bit 6: The device error log contains records of errors.
> 
> Bit 7: The device self-test log contains records of errors.  [ATA only]
> Failed self-tests outdated by a newer successful  ex‐
> tended self-test are ignored.
> ```
> 
> And I see exitstatus 64 for /dev/sdb & partition manager traits this as
> error.
> (see this check:
> https://invent.kde.org/system/kpmcore/-/blob/
> ad35460628f82c5025f7e5600b6d15cfcdf75d42/src/core/smartparser.cpp#L120).

Thanks for looking into this. Now it makes sense why it fails.

Created attachment 136781 [details]
kpmcore-20.12.3-fix-exit-code-check.patch

Proposed patch. Or we can just try to parse JSON and if output is not JSON - fail?

(In reply to Yaroslav Sidlovsky from comment #11)
> Created attachment 136781 [details]
> kpmcore-20.12.3-fix-exit-code-check.patch
> 
> Proposed patch. Or we can just try to parse JSON and if output is not JSON -
> fail?

This should work but can you submit it via merge request on https://invent.kde.org/system/kpmcore

https://invent.kde.org/system/kpmcore/-/merge_requests/28

Git commit 8746ef72fd1b84a665f3bb6abbc8d765affa9ed6 by Yaroslav Sidlovsky.
Committed on 17/03/2021 at 13:03.
Pushed by stikonas into branch 'master'.

Fix smartctl exit status success check

According to the smartctl man page:
```
EXIT STATUS
The  exit  statuses of smartctl are defined by a bitmask.  If all is well with the disk, the exit status (return value) of smartctl is 0 (all bits turned off).  If a problem occurs, or an error, potential error, or fault is detected, then a non-zero status is
returned.  In this case, the eight different bits in the exit status have the following meanings for ATA disks; some of these values may also be returned for SCSI disks.

Bit 0: Command line did not parse.

Bit 1: Device open failed, device did not return an IDENTIFY DEVICE structure, or device is in a low-power mode (see '-n' option above).

Bit 2: Some SMART or other ATA command to the disk failed, or there was a checksum error in a SMART data structure (see '-b' option above).

Bit 3: SMART status check returned "DISK FAILING".

Bit 4: We found prefail Attributes <= threshold.

Bit 5: SMART status check returned "DISK OK" but we found that some (usage or prefail) Attributes have been <= threshold at some time in the past.

Bit 6: The device error log contains records of errors.

Bit 7: The device self-test log contains records of errors.  [ATA only] Failed self-tests outdated by a newer successful extended self-test are ignored.
```

M  +5    -1    src/core/smartparser.cpp

https://invent.kde.org/system/kpmcore/commit/8746ef72fd1b84a665f3bb6abbc8d765affa9ed6

Git commit 2ea9ff49124750ece175cb1f27a1492fc50287a3 by Andrius Štikonas, on behalf of Yaroslav Sidlovsky.
Committed on 17/03/2021 at 13:18.
Pushed by stikonas into branch 'release/21.04'.

Fix smartctl exit status success check

According to the smartctl man page:
```
EXIT STATUS
The  exit  statuses of smartctl are defined by a bitmask.  If all is well with the disk, the exit status (return value) of smartctl is 0 (all bits turned off).  If a problem occurs, or an error, potential error, or fault is detected, then a non-zero status is
returned.  In this case, the eight different bits in the exit status have the following meanings for ATA disks; some of these values may also be returned for SCSI disks.

Bit 0: Command line did not parse.

Bit 1: Device open failed, device did not return an IDENTIFY DEVICE structure, or device is in a low-power mode (see '-n' option above).

Bit 2: Some SMART or other ATA command to the disk failed, or there was a checksum error in a SMART data structure (see '-b' option above).

Bit 3: SMART status check returned "DISK FAILING".

Bit 4: We found prefail Attributes <= threshold.

Bit 5: SMART status check returned "DISK OK" but we found that some (usage or prefail) Attributes have been <= threshold at some time in the past.

Bit 6: The device error log contains records of errors.

Bit 7: The device self-test log contains records of errors.  [ATA only] Failed self-tests outdated by a newer successful extended self-test are ignored.
```

M  +5    -1    src/core/smartparser.cpp

https://invent.kde.org/system/kpmcore/commit/2ea9ff49124750ece175cb1f27a1492fc50287a3