Fails to compile on debian buster, with default packages, cmake passes, but fails at make. STEPS TO REPRODUCE 1. cmake ../ -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=~/Apps/Kate/ 2. make OBSERVED RESULT [ 0%] Automatic MOC for target katebacktracebrowserplugin [ 0%] Built target katebacktracebrowserplugin_autogen Scanning dependencies of target katebacktracebrowserplugin [ 0%] Building CXX object addons/backtracebrowser/CMakeFiles/katebacktracebrowserplugin.dir/katebacktracebrowser.cpp.o In file included from /home/brian/Git-Repos/kate/addons/backtracebrowser/katebacktracebrowser.cpp:13: In file included from /usr/include/KF5/KConfigCore/KConfigGroup:1: /usr/include/KF5/KConfigCore/kconfiggroup.h:734:16: error: expected expression Q_FOREACH (const T &value, defaultValue) { ^ /usr/include/KF5/KConfigCore/kconfiggroup.h:739:16: error: expected expression Q_FOREACH (const QVariant &value, readEntry<QVariantList>(key, data)) { ^ /usr/include/KF5/KConfigCore/kconfiggroup.h:760:16: error: expected expression Q_FOREACH (const T &value, list) { ^ 3 errors generated. make[2]: *** [addons/backtracebrowser/CMakeFiles/katebacktracebrowserplugin.dir/build.make:71: addons/backtracebrowser/CMakeFiles/katebacktracebrowserplugin.dir/katebacktracebrowser.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:901: addons/backtracebrowser/CMakeFiles/katebacktracebrowserplugin.dir/all] Error 2 make: *** [Makefile:141: all] Error 2 EXPECTED RESULT Complete to 100% SOFTWARE/OS VERSIONS Linux/KDE Plasma: Debian Buster (available in About System) KDE Plasma Version: 5.54 KDE Frameworks Version: None Qt Version: 5.11
I mean framework version is 5.54. Plasma is the one not installed.
FWIW works for me on openSUSE Tumbleweed with Qt 5.15.1, Frameworks 5.76, and gcc 10.
Kate is build with QT_NO_FOREACH active, which means that any code that uses Q_FOREACH will fail to build. KConfig 5.54 uses Q_FOREACH in a header that gets included in Kate, resulting in a failed build. Beginning with 5.56 KConfig does not use Q_FOREACH any more. Effectively this means Kate requires KConfig 5.56 and the stated min version of 5.40 is wrong. You can work around that by going to CMakeLists.txt in Kate and removing the line that says "add_definitions(-DQT_NO_FOREACH)"
(In reply to Nicolas Fella from comment #3) > Kate is build with QT_NO_FOREACH active, which means that any code that uses > Q_FOREACH will fail to build. > > KConfig 5.54 uses Q_FOREACH in a header that gets included in Kate, > resulting in a failed build. Beginning with 5.56 KConfig does not use > Q_FOREACH any more. Effectively this means Kate requires KConfig 5.56 and > the stated min version of 5.40 is wrong. > > You can work around that by going to CMakeLists.txt in Kate and removing the > line that says "add_definitions(-DQT_NO_FOREACH)" Nicolas are you able update the relevant header?
Okay, done as sudgested, removed the line from CMakeLists.txt about add_definitions(-DQT_NO_FOREACH) But, now there is a new problem: [ 0%] Automatic MOC for target katebacktracebrowserplugin [ 0%] Built target katebacktracebrowserplugin_autogen [ 3%] Built target katebacktracebrowserplugin [ 3%] Automatic MOC for target btbrowser_test [ 3%] Built target btbrowser_test_autogen [ 4%] Built target btbrowser_test [ 4%] Automatic MOC for target katecloseexceptplugin [ 4%] Built target katecloseexceptplugin_autogen [ 6%] Built target katecloseexceptplugin [ 6%] Automatic MOC for target katefilebrowserplugin [ 7%] Built target katefilebrowserplugin_autogen Scanning dependencies of target katefilebrowserplugin [ 7%] Building CXX object addons/filebrowser/CMakeFiles/katefilebrowserplugin.dir/katefilebrowser.cpp.o /home/brian/Git-Repos/kate/addons/filebrowser/katefilebrowser.cpp:46:10: fatal error: 'KApplicationTrader' file not found #include <KApplicationTrader> ^~~~~~~~~~~~~~~~~~~~ 1 error generated. make[2]: *** [addons/filebrowser/CMakeFiles/katefilebrowserplugin.dir/build.make:89: addons/filebrowser/CMakeFiles/katefilebrowserplugin.dir/katefilebrowser.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:1183: addons/filebrowser/CMakeFiles/katefilebrowserplugin.dir/all] Error 2 make: *** [Makefile:141: all] Error 2 It appears the file KApplicationTrader or kapplicationtrader.h isn't part of KDE 5.54, as on doing search it is supposed to be shipped with the libkf5service-dev in debian, but Debian Buster doesn't ship with it, appears to be only in newer versions, I don't really know starting from which version of KDE was this added.
With Debian always a bit further behind with updates might I suggest trying the snap/flatpak/appimage https://kate-editor.org/get-it/
KApplicationTrader was introduced in KDE Frameworks 5.68
(In reply to Brian from comment #5) > Okay, done as sudgested, removed the line from CMakeLists.txt about > add_definitions(-DQT_NO_FOREACH) > > But, now there is a new problem: > > [ 0%] Automatic MOC for target katebacktracebrowserplugin > [ 0%] Built target katebacktracebrowserplugin_autogen > [ 3%] Built target katebacktracebrowserplugin > [ 3%] Automatic MOC for target btbrowser_test > [ 3%] Built target btbrowser_test_autogen > [ 4%] Built target btbrowser_test > [ 4%] Automatic MOC for target katecloseexceptplugin > [ 4%] Built target katecloseexceptplugin_autogen > [ 6%] Built target katecloseexceptplugin > [ 6%] Automatic MOC for target katefilebrowserplugin > [ 7%] Built target katefilebrowserplugin_autogen > Scanning dependencies of target katefilebrowserplugin > [ 7%] Building CXX object > addons/filebrowser/CMakeFiles/katefilebrowserplugin.dir/katefilebrowser.cpp.o > /home/brian/Git-Repos/kate/addons/filebrowser/katefilebrowser.cpp:46:10: > fatal error: 'KApplicationTrader' file not found > #include <KApplicationTrader> > ^~~~~~~~~~~~~~~~~~~~ > 1 error generated. > make[2]: *** > [addons/filebrowser/CMakeFiles/katefilebrowserplugin.dir/build.make:89: > addons/filebrowser/CMakeFiles/katefilebrowserplugin.dir/katefilebrowser.cpp. > o] Error 1 > make[1]: *** [CMakeFiles/Makefile2:1183: > addons/filebrowser/CMakeFiles/katefilebrowserplugin.dir/all] Error 2 > make: *** [Makefile:141: all] Error 2 > > > > > It appears the file KApplicationTrader or kapplicationtrader.h isn't part of > KDE 5.54, as on doing search it is supposed to be shipped with the > libkf5service-dev in debian, but Debian Buster doesn't ship with it, appears > to be only in newer versions, I don't really know starting from which > version of KDE was this added. It looks like you'll need 5.68 or later to compile kate. If you really want to compile instead of using a universal package like flatpak you'll need to compile and install those libraries first or use kdesrc-build which will bring in all the needed dependencies for you.
Git commit e017ac7f434b55ae93eda1154855872ffb8ff154 by Christoph Cullmann, on behalf of Nicolas Fella. Committed on 22/11/2020 at 12:17. Pushed by cullmann into branch 'master'. Require KF 5.68 We use API from 5.68 unconditionally, e.g. KApplicationTrader M +1 -1 CMakeLists.txt https://invent.kde.org/utilities/kate/commit/e017ac7f434b55ae93eda1154855872ffb8ff154
Requirements fixed, you should now get an early error. If somebody wants to improve this (e.g. allow again older frameworks to be usable), feel free to submit some merge request for that.