Bug 428811 - Visual regression: margins no longer honored for Folder View in applet mode
Summary: Visual regression: margins no longer honored for Folder View in applet mode
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: libplasma (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-11-07 22:48 UTC by Luca Beltrame
Modified: 2020-11-09 15:59 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Plasmoidviewer showing the issue (look at the plasmoid margins in the top left corner) (180.67 KB, image/png)
2020-11-07 22:48 UTC, Luca Beltrame
Details
Detail of a folder view instance on the desktop showing folders overflowing (64.68 KB, image/png)
2020-11-07 22:50 UTC, Luca Beltrame
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Luca Beltrame 2020-11-07 22:48:26 UTC
Created attachment 133123 [details]
Plasmoidviewer showing the issue (look at the plasmoid margins in the top left corner)

SUMMARY

In latest master, the margins of the folder view are no longer respected: you get at best two lines which go beyond the screen (see attached screenshot).

I tried locating the commit which broke it, but I could not find anything suspicious in plasma-{framework, desktop, workspace) or in kdeclarative or in kitemmodels. 

STEPS TO REPRODUCE
1. Load a Folder View in standalone mode (or use plasmoidviewer) in a folder with many items

OBSERVED RESULT

Rows overflow the plasmoid borders and go beyond the screen / window

EXPECTED RESULT

Plasmoid margins are respected.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: latest maaster
(available in About System)
KDE Plasma Version: latest master
KDE Frameworks Version: latest master
Qt Version: 5.15.0
Comment 1 Luca Beltrame 2020-11-07 22:50:48 UTC
Created attachment 133124 [details]
Detail of a folder view instance on the desktop showing folders overflowing
Comment 2 Nate Graham 2020-11-08 14:08:27 UTC
Regression from 18ee2d9eed780cc52381362c370d0359fb872944 in plasma-framework.

Unfortunately this made it into the 5.76 tar, so we need an emergency fix or a reversion. Marco, can you take care of this?
Comment 3 Marco Martin 2020-11-09 15:59:16 UTC
offending commit reverted