Bug 428744 - The steps that you have to take in order to remove a page are not intuitive
Summary: The steps that you have to take in order to remove a page are not intuitive
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2020-11-05 20:38 UTC by Vlad Zahorodnii
Modified: 2020-12-03 15:57 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vlad Zahorodnii 2020-11-05 20:38:44 UTC
SUMMARY
Currently, you need to access the "Edit page" dialog via the hamburger menu in order to remove a page.

It might be a good idea to provide the following ways in which a system monitor page can be removed:

* By clicking the page in the overview sidebar and then pressing Del button on keyboard
* Right click the page in the overview sidebar and then click "Delete..." or something

Warning: I'm not a designer and UX/UI is not my domain, so take my words with a grain of salt.
Comment 1 Vlad Zahorodnii 2020-11-05 20:45:30 UTC
s/Del button/Del key/
Comment 2 Justin Zobel 2020-11-06 09:28:23 UTC
I can't even see a way to delete pages once in Edit Mode.

I agree there needs to be an easy way (or at least obvious) to do this.

Perhaps when in edit mode icons come up next to each page in the left sidebar, one for rename, one for delete.
Comment 3 Arjen Hiemstra 2020-11-06 11:01:24 UTC
Deleting is a rather destructive action. So I do not really want to make that simpler, the current dialog acts as a form of confirmation. It also contains logic to deal with the difference between system-supplied and local pages, which would need to be recreated, another reason to I'd prefer not to do that.

What might be possible however is to have a context menu that shows a few of the actions in the overflow menu. We may also be able to find a better name for the action that makes clear it includes removing pages.
Comment 4 Nate Graham 2020-11-06 18:11:17 UTC
I agree that we don't want to make deletion too easy. People will delete default pages and not know now to get them back. A context menu action for the list items could make sense though, yeah.
Comment 5 Justin Zobel 2020-11-07 01:35:04 UTC
(In reply to Nate Graham from comment #4)
> I agree that we don't want to make deletion too easy. People will delete
> default pages and not know now to get them back. A context menu action for
> the list items could make sense though, yeah.

Like all destructive tasks in KDE use the popup to allow an Undo, easy fix. :)
Comment 6 Nate Graham 2020-11-07 15:29:09 UTC
That's a very good point!
Comment 7 Bug Janitor Service 2020-11-16 12:33:30 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/72
Comment 8 Arjen Hiemstra 2020-12-03 15:57:44 UTC
Git commit c0435edc10fcf8cfc299858a776b5fe4a7ea78eb by Arjen Hiemstra.
Committed on 03/12/2020 at 14:36.
Pushed by ahiemstra into branch 'master'.

Rename "Edit Pages" action to "Edit or Remove Pages"

To make it more clear that you can remove pages with that action.

M  +1    -1    src/main.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/c0435edc10fcf8cfc299858a776b5fe4a7ea78eb
Comment 9 Arjen Hiemstra 2020-12-03 15:57:52 UTC
Git commit ffb02d5e50b5c4050fb3e4557b4b82832fd533cd by Arjen Hiemstra.
Committed on 03/12/2020 at 14:36.
Pushed by ahiemstra into branch 'master'.

Add a context menu to the global drawer

It shows a subset of actions from the toolbar, primarily the "edit or
remove pages" action.

M  +18   -0    src/main.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/ffb02d5e50b5c4050fb3e4557b4b82832fd533cd