Bug 428741 - If several pages share the same name and either one of them is active, both pages will be highlighted in the page overview sidebar
Summary: If several pages share the same name and either one of them is active, both p...
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-05 20:01 UTC by Vlad Zahorodnii
Modified: 2020-11-11 12:28 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
screenshot that demonstrates the problem (73.63 KB, image/png)
2020-11-05 20:01 UTC, Vlad Zahorodnii
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vlad Zahorodnii 2020-11-05 20:01:43 UTC
Created attachment 133063 [details]
screenshot that demonstrates the problem

STEPS TO REPRODUCE
1. Click "Add new page" button several times
2. Click one of the newly added pages

OBSERVED RESULT
All new pages will be highlighted in the page overview tab (not sure how it's called)

EXPECTED RESULT
Only one item in the page overview tab is highlighted

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Justin Zobel 2020-11-06 09:28:58 UTC
Confirmed on plasma-systemmonitor from git master.
Comment 2 Arjen Hiemstra 2020-11-06 10:57:53 UTC
https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/51 should have made sure there are no duplicate pages. It seems that fails.
Comment 3 David Redondo 2020-11-09 13:45:46 UTC
We actually end up using different files anda data objects, will investigate why multiple are highlighted.
Comment 4 David Redondo 2020-11-11 12:28:05 UTC
Git commit aab3d22d35a9680c18844ae85868a9831051aa91 by David Redondo.
Committed on 11/11/2020 at 12:25.
Pushed by davidre into branch 'master'.

Use unique Urls

Otherwise Kirigami gets confused

M  +1    -1    src/page/EditablePageAction.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/aab3d22d35a9680c18844ae85868a9831051aa91