Bug 428740 - System Monitor doesn't switch to a newly added page
Summary: System Monitor doesn't switch to a newly added page
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-05 19:52 UTC by Vlad Zahorodnii
Modified: 2020-11-11 12:27 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-systemmonitor/commit/646d2382623678d5eedabb101d5780a2131780ca
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Vlad Zahorodnii 2020-11-05 19:52:55 UTC 
STEPS TO REPRODUCE
1. Add a new page

OBSERVED RESULT
PSM doesn't switch to the new page.

EXPECTED RESULT
PSM switches to the new page.

---

Warning: I'm not a designer and UX/UI is not my domain.

I can't provide you any explanation why the proposed behavior is better, but it feels like something is off if system monitor doesn't switch to the newly added page.
Comment 1 Justin Zobel 2020-11-06 09:34:58 UTC 
Confirmed it doesn't switch, it should. You're creating a new page to add things to it.
Comment 2 Arjen Hiemstra 2020-11-06 10:56:37 UTC 
This should already have been implemented with https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/43 . It seems that doesn't work.
Comment 3 David Redondo 2020-11-11 12:27:57 UTC 
Git commit 646d2382623678d5eedabb101d5780a2131780ca by David Redondo.
Committed on 11/11/2020 at 12:25.
Pushed by davidre into branch 'master'.

Fix automatically opening files

The model now finds a not taken fileName in addPage(). We have to compare
against the file name that the page will actually use in the end.

M  +1    -2    src/main.qml
M  +0    -1    src/page/EditablePageAction.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/646d2382623678d5eedabb101d5780a2131780ca