Bug 428739 - Remove the lines in the list view
Summary: Remove the lines in the list view
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Other
: NOR wishlist
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-05 19:03 UTC by postix
Modified: 2020-11-12 14:35 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.77
Sentry Crash Report:


Attachments
Screenshot (110.90 KB, image/png)
2020-11-05 19:03 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2020-11-05 19:03:49 UTC
Created attachment 133061 [details]
Screenshot

For visual consistency with other Kirigami lists there are now horizontal lines in all places with list views like the System Settings or the Infocenter. (Please see the attached screenshot.)

I'd propose to go the other way around and to remove them altogether for a clearer look.
Comment 1 Nate Graham 2020-11-05 19:26:09 UTC
As the person who implemented this change, I'm inclined to agree. All those lines just feel kind of unnecessary in most places.
Comment 2 Bug Janitor Service 2020-11-05 19:39:42 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/151
Comment 3 Bug Janitor Service 2020-11-09 20:16:37 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/158
Comment 4 Nate Graham 2020-11-12 14:35:02 UTC
Git commit 0003547f494fde79465388adf0a8eb104f9cfe2b by Nate Graham.
Committed on 12/11/2020 at 14:34.
Pushed by ngraham into branch 'master'.

Refine list separator appearance

The lines are now a little bit lighter in weight and no longer span the
full width of the list item; now they have margins equal to `largeSpacing`,
which is used for the items inside the list item itself. This makes the
lones no longer so visually objectionable, which makes them suitable for
keeping as the default appearance in list views.

Also, the top separator is removed because it is unneeded; only having one
separator at the bottom of each list item is visually sufficient, and fixes a
bug preventing you from removing the separators inside a list item when it
has a colored rectangle, since the bottom-most line is actually drawn by the
item below it.
FIXED-IN: 5.77

M  +1    -1    src/controls/Separator.qml
M  +14   -15   src/controls/private/DefaultListItemBackground.qml

https://invent.kde.org/frameworks/kirigami/commit/0003547f494fde79465388adf0a8eb104f9cfe2b