Bug 428725 - Double click on user doesn't open user details
Summary: Double click on user doesn't open user details
Status: RESOLVED WORKSFORME
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_users (other bugs)
Version First Reported In: 5.20.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2020-11-05 13:24 UTC by medin
Modified: 2020-11-05 18:54 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Double click on user doesn't open user detail (255.21 KB, video/mp4)
2020-11-05 13:24 UTC, medin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description medin 2020-11-05 13:24:04 UTC
Created attachment 133049 [details]
Double click on user doesn't open user detail

In Settings>Manage_Users when I double click on an user the user name appear in top navigator but doesn't switch to it. It's like it opens user details but switch back to Manage Users. See attached video for more info.
I know single click open user details but double should also do it.

Operating System: Manjaro Linux
KDE Plasma Version: 5.20.2
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.1
Kernel Version: 5.4.74-1-MANJARO
OS Type: 64-bit
Comment 1 Nate Graham 2020-11-05 14:04:43 UTC
I see the bug, fixing it.
Comment 2 Nate Graham 2020-11-05 14:13:50 UTC
Actually, fixing this by adding an onDoubleClicked() handler makes it worse (it pushes two pages; somehow both onClicked() and onDoubleClicked() get triggered).

Furthermore I cannot reproduce the original issue. Double-clicking opens it just fine for me.

Gotta close this, sorry. Just single-click it. :) Even when you're using the systemwide double-click setting, that only applies to files and folders, never list items
Comment 3 medin 2020-11-05 16:59:18 UTC
(In reply to Nate Graham from comment #2)
> Actually, fixing this by adding an onDoubleClicked() handler makes it worse
> (it pushes two pages; somehow both onClicked() and onDoubleClicked() get
> triggered).
> 
> Furthermore I cannot reproduce the original issue. Double-clicking opens it
> just fine for me.
> 
> Gotta close this, sorry. Just single-click it. :) Even when you're using the
> systemwide double-click setting, that only applies to files and folders,
> never list items

Can't double click event be forwarded to single click handler method or simply call single click handler method from double one ?

Or are you saying both single and double clicks call single click handler method ? (if it's then bad framework)

Even if it's called two times shouldn't user details view be singleton (because only one view appears at time) that get populated by selected user data ?

You know this gives me desire to revive my C++ knowledge and dig deep into this  :)
Comment 4 Nate Graham 2020-11-05 18:54:23 UTC
(In reply to medin from comment #3)
> (In reply to Nate Graham from comment #2)
> Can't double click event be forwarded to single click handler method or
> simply call single click handler method from double one ?
In this case, not really, no. Seems like the double click handler is not even implemented in the framework. I guess nobody ever considered that anyone would double-click a list item. :)

> Even if it's called two times shouldn't user details view be singleton
> (because only one view appears at time) that get populated by selected user
> data ?
Yes, this is a separate bug in Kirigami. Indeed, you should not be able to push the same page twice. Can you file a bug report for that? I think this may be the root of the problem.


> You know this gives me desire to revive my C++ knowledge and dig deep into
> this  :)
Go for it!

https://community.kde.org/Get_Involved/development