Bug 428372 - Kate's toolbar shifts because a button ("Save As..."/"Save As") has more than one name
Summary: Kate's toolbar shifts because a button ("Save As..."/"Save As") has more than...
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: part (other bugs)
Version First Reported In: 20.08.2
Platform: Debian testing Linux
: NOR minor
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-28 03:26 UTC by jbn
Modified: 2022-08-17 20:55 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Kate's shifting toolbar due to this SaveAs button naming bug. (1.65 MB, video/x-matroska)
2020-10-28 03:26 UTC, jbn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jbn 2020-10-28 03:26:20 UTC
Created attachment 132823 [details]
Kate's shifting toolbar due to this SaveAs button naming bug.

SUMMARY
Kate's "Save As..." button shows up as "Save As..." on initial document (the document you get when you first launch Kate) and "Save As" on other new documents.

STEPS TO REPRODUCE
1. Launch Kate normally and make sure that the "Save As" button is part of your toolbar. Quit and relaunch Kate. Notice that a document has been started and the "Save As..." button shows up with the ellipsis.
2. Start a new document. A new tab appears and the "Save As" button shows up without the ellipsis.
3. Switch between the two tabs noticing how the toolbar shifts around slightly.
4. Close the initial document and start a new document. "Save As" without the ellipsis is the button name for both documents.

OBSERVED RESULT
Neighboring toolbar buttons probably had to shift slightly to accommodate the change in "Save As..." button width.

EXPECTED RESULT
I expect buttons to have a consistent naming regardless of what document they're a part of. I only expect button names/titles to change depending on either editing context (in the case of buttons that change function) or changing UI language mid-session.

SOFTWARE/OS VERSIONS
Operating System: Debian GNU/Linux 
KDE Plasma Version: 5.17.5
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2
Kernel Version: 5.9.0-1-amd64
OS Type: 64-bit
Processors: 8 × AMD FX(tm)-8150 Eight-Core Processor
Memory: 31.3 GiB of RAM

ADDITIONAL INFORMATION
I've attached a movie demonstrating the effect. I don't know if this affects other buttons, but it might be worth reviewing all of the button names/titles to make sure any differences are intentional. I'm guessing that this changing name/title was unintentional.
Comment 1 Justin Zobel 2020-10-29 00:47:47 UTC
Can confirm on Neon Unstable.
Comment 2 Christoph Cullmann 2020-12-13 14:45:35 UTC
:P Strange, no idea why that happens, but can reproduce that :/
Comment 3 Christoph Cullmann 2022-04-07 21:26:28 UTC
Can still reproduce this, very strange, no idea why this happens.
There is just one Save As... action around >(
Comment 4 Bug Janitor Service 2022-08-17 12:48:20 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/404
Comment 5 Christoph Cullmann 2022-08-17 20:55:02 UTC
Git commit 3d1141db4d86f8583e13b19b178b29cf40b52b6f by Christoph Cullmann.
Committed on 17/08/2022 at 20:54.
Pushed by cullmann into branch 'master'.

ensure consistent ... removal in iconText

otherwise, we add the ... back that Qt removed before
=> inconsistent toolbar entries

M  +1    -1    src/kacceleratormanager.cpp

https://invent.kde.org/frameworks/kwidgetsaddons/commit/3d1141db4d86f8583e13b19b178b29cf40b52b6f