Bug 427935 - Make Highlight Changed Settings More Consistent
Summary: Make Highlight Changed Settings More Consistent
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: sidebarview (other bugs)
Version First Reported In: 5.20.0
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-18 17:10 UTC by Andres Betts
Modified: 2020-10-21 13:26 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.21
Sentry Crash Report:


Attachments
highlightchangeditems (113.64 KB, image/png)
2020-10-18 17:10 UTC, Andres Betts
Details
Proposal (216.74 KB, image/jpeg)
2020-10-20 18:10 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Betts 2020-10-18 17:10:37 UTC
Created attachment 132531 [details]
highlightchangeditems

SUMMARY
When enabled, highlight changed settings displaces the navigational icons in the system settings navigation ">" to add space for the circle that denotes the changed settings.

This makes it so that the UI becomes less predictable and polished. It also places the circle further away from the related item that is actually changing.

Attached is a proposal to make this more intuititve.

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Andres Betts 2020-10-20 13:29:14 UTC
Through discussion, the team also proposed placing the highlight dot just before the arrow icon. This will keep a straight consistent line and there would not be a shift with the arrows.
Comment 2 Nate Graham 2020-10-20 18:03:37 UTC
The problem with that approach is that it looks really weird for items and sections that don't have arrows.
Comment 3 Nate Graham 2020-10-20 18:10:07 UTC
Created attachment 132590 [details]
Proposal

Here's how that would look. Do you think it's better?
Comment 4 Bug Janitor Service 2020-10-20 18:52:50 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/34
Comment 5 Nate Graham 2020-10-21 13:26:51 UTC
Git commit fcdfc86d40794621e80c9c05be0b96f3f6211a5a by Nate Graham.
Committed on 21/10/2020 at 13:26.
Pushed by ngraham into branch 'master'.

[sidebar view] Re-position defaults indicators

Previously, they were always the right-most item in their list items,
and could cause the arrow to move around. Now they're left of the arrow
so nothing moves around. The indicators still line up vertically.
FIXED-IN: 5.21

M  +17   -12   sidebar/package/contents/ui/CategoryItem.qml

https://invent.kde.org/plasma/systemsettings/commit/fcdfc86d40794621e80c9c05be0b96f3f6211a5a