Bug 427864 - PlasmoidHeading area has wrong color when using Breeze Dark plasma theme
Summary: PlasmoidHeading area has wrong color when using Breeze Dark plasma theme
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: 5.75.0
Platform: Arch Linux Linux
: VHI normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords: regression
: 428050 428092 428371 428566 428761 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-10-17 13:41 UTC by Grzegorz
Modified: 2020-11-06 18:20 UTC (History)
9 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/plasma-framework/commit/79cbd1ba7441fd1429bc44380abdd01de55f6b43
Version Fixed In: 5.76
Sentry Crash Report:

Attachments
popup (21.20 KB, image/png)
2020-10-17 13:41 UTC, Grzegorz 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz 2020-10-17 13:41:50 UTC 
Created attachment 132472 [details]
popup

SUMMARY

on breeze dark I have bad color in title bar in popup (attachment) after upgrade to 5.20.0 


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 5.20.0
(available in About System)
KDE Plasma Version:  5.20.0
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.1
Comment 1 Grzegorz 2020-10-17 13:55:47 UTC 
after upgrade from 5.19.5 to 5.20.0, this problem appears after second reboot.

on new account problem doesent appears, but i try remove my all config files from ~/.config in main account and set everything manualy one more time, it was ok, but after reboot the problem again appeared
Comment 2 Nate Graham 2020-10-21 04:12:13 UTC 
Ugh! I was under the impression that this was only happening for the pre-release stuff.

Can you confirm that you're using Plasma 5.20 with Frameworks 5.75 and not newer or git master versions?

Also can you mention what plasma theme and color scheme you're using?
Comment 3 Grzegorz 2020-10-21 08:26:17 UTC 
Yes, for now I'm using framework 5.75 and plasma 5.20.1 and problem still exists.
Comment 4 Grzegorz 2020-10-21 08:27:26 UTC 
Dark breeze + color scheme breeze
Comment 5 Patrick Silva 2020-10-21 13:04:57 UTC 
to reproduce on both Arch (Plasma 5.20.1 and frameworks 5.75) and neon unstable:
1. set global theme to Breeze
2. set Plasma style to Breeze Dark
Comment 6 Nate Graham 2020-10-21 17:14:33 UTC 
Can confirm. :(

How can this be happening?!
Comment 7 Nate Graham 2020-10-21 17:18:05 UTC 
Maybe the problem is that we need a separate dark version of the SVG for breeze dark? Does that make any sense? Or maybe its color-changing aspect is broken.
Comment 8 Nate Graham 2020-10-21 17:50:22 UTC 
We found the problem: it's my change to have the PlasmoidHeading use Header colors if available. There's a problem with the "if available" heuristic such that it ends up thinking that header colors *are* available even when they aren't.
Comment 9 Patrick Silva 2020-10-21 19:18:46 UTC 
*** Bug 428050 has been marked as a duplicate of this bug. ***
Comment 10 The Feren OS Dev 2020-10-22 04:29:54 UTC 
I think I just indirectly made a fix to this bug without even knowing about this bug report: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/124
Comment 11 Patrick Silva 2020-10-22 09:38:47 UTC 
*** Bug 428092 has been marked as a duplicate of this bug. ***
Comment 12 Nate Graham 2020-10-29 19:15:26 UTC 
*** Bug 428371 has been marked as a duplicate of this bug. ***
Comment 13 Nate Graham 2020-11-01 17:03:11 UTC 
*** Bug 428566 has been marked as a duplicate of this bug. ***
Comment 14 Nate Graham 2020-11-01 17:04:36 UTC 
Will be fixed for users in Frameworks 5.76, one way or another. I have a merge request ready to merge that contains a workaround, just in case we don't manage to fix the root cause before then.
Comment 15 spphinslove 2020-11-02 14:22:34 UTC 
(In reply to Nate Graham from comment #14)
> 将以一种或另一种方式在Frameworks 5.76中为用户修复。
> 我有一个准备合并的合并请求，其中包含一个解决方法，以防万一在此之前我们无法解决根本原因。

what about GTK application?Can it fix need reboot to apply  dark theme for GTK application?
Comment 16 Nate Graham 2020-11-03 18:30:18 UTC 
Git commit 79cbd1ba7441fd1429bc44380abdd01de55f6b43 by Nate Graham, on behalf of Dominic Hayes.
Committed on 03/11/2020 at 18:30.
Pushed by ngraham into branch 'master'.

Lock the header colours of Breeze Dark and Breeze Light

This MR locks the header colours of Breeze Dark and Breeze Light, for
Plasma 5.21/master, to the colours for the titlebars and window colours
that they currently use in 5.20 (from their respective colour schemes),
so that the locked appearance is consistent with how the background of
these Plasma Styles is already locked, as well as fixing an issue with
the header looking wrong on light colour schemes + Breeze Dark and
vice-versa. Breeze itself will still colour just as completely as usual,
though.
FIXED-IN: 5.76

M  +14   -0    src/desktoptheme/breeze-dark/colors
M  +14   -0    src/desktoptheme/breeze-light/colors

https://invent.kde.org/frameworks/plasma-framework/commit/79cbd1ba7441fd1429bc44380abdd01de55f6b43
Comment 17 Nate Graham 2020-11-06 18:20:32 UTC 
*** Bug 428761 has been marked as a duplicate of this bug. ***