Bug 427854 - Option to display a warning when closing multiple tabs doesn't do anything when using the "state saving" feature and doesn't indicate this
Summary: Option to display a warning when closing multiple tabs doesn't do anything wh...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 20.08.2
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2020-10-17 09:18 UTC by Nick Stefanov
Modified: 2020-10-18 15:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Stefanov 2020-10-17 09:18:24 UTC 
SUMMARY
Dolphin doesn't show a warning when closing multiple tabs. In Dolphin's settings it's set to confirm on "Closing windows with multiple tabs". It is working fine in Dolphin 20.04.

STEPS TO REPRODUCE
1. Open Dolphin.
2. Open 2 or more tabs.
3. Close Dolphin.

OBSERVED RESULT
Dolphin doesn't show a warning, just closes.

EXPECTED RESULT
Show a warning.

SOFTWARE/OS VERSIONS
Arch Linux
Linux/KDE Plasma: 
KDE Plasma Version: 5.20
KDE Frameworks Version: 5.75
Qt Version: 5.15.1
Comment 1 Nate Graham 2020-10-17 13:50:05 UTC 
Yes, this was an intentional change when using the "remember state from last time" setting, because the tabs are saved, so there's no need to warn you about it. See https://invent.kde.org/system/dolphin/-/merge_requests/70.

Maybe we can show a KMessageWidget in the settings window indicating that the warning will be suppressed because the state saving feature is active? Or maybe that's so minor that it's not worth doing?

What do you think, Elvis?
Comment 2 Nick Stefanov 2020-10-17 14:08:16 UTC 
But they are not saved. When I start Dolphin it doesn't open the previous session.
Btw, where is this option to "remember state from last time"? I can't find it.
Comment 3 Nate Graham 2020-10-17 15:29:19 UTC 
Settings window > Startup page > Show On startup: Folders, tabs, and window state from last time.

is that option in use?
Comment 4 Nick Stefanov 2020-10-17 16:18:03 UTC 
Ah, I found it, thanks :) It's selected but obviously not working :(
Comment 5 Nick Stefanov 2020-10-17 16:20:57 UTC 
Hmm, actually if I choose to show my home folder, there is confirmation dialog again which is ok for me. However "Folders, tabs, and window state from last time" doesn't wotk and that's a bug, at least on my end.
Comment 6 Nate Graham 2020-10-18 15:27:21 UTC 
Okay, so if the state saving feature isn't working at all for you, that's a separate bug. :) I'll be happy to investigate it with you and fix it if I can. Can you file another bug report to track that issue? Thanks!
Comment 7 Nick Stefanov 2020-10-18 15:40:46 UTC 
For now it's ok for me for I need only the confirmation warning. Thank you :)