Bug 427812 - Improve handling of trailing white spaces in file names when saving
Summary: Improve handling of trailing white spaces in file names when saving
Status: CONFIRMED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: Open/save dialogs (other bugs)
Version First Reported In: 5.75.0
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: KIO Bugs
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2020-10-16 15:07 UTC by Claudius Ellsel
Modified: 2020-10-24 06:16 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Claudius Ellsel 2020-10-16 15:07:58 UTC
There has been a recent merge request that simply removes trailing spaces (https://invent.kde.org/frameworks/kio/-/merge_requests/98). I'd prefer a solution where a warning is displayed (inline), when hitting the save button (see https://invent.kde.org/frameworks/kio/-/merge_requests/98#note_93873).
Comment 1 2wxsy58236r3 2020-10-19 03:41:40 UTC
How about a popup dialog like this?

> The name has trailing space(s), are you sure?
> Trailing spaces can cause issues on Windows in shared environments.
> 
> [X] Automatically remove trailing whitespace in the future (Checkbox, checked by default)
> 
> Button 1: [Cancel] (Returns to rename window)
> Button 2: [Continue] (Keep trailing space)
> Button 3: [Trim trailing space]
Comment 2 Claudius Ellsel 2020-10-19 06:56:51 UTC
That might be an option, although the merge request has been started to remove those pop ups if I am not mistaken.
Comment 3 Nate Graham 2020-10-21 03:31:51 UTC
Showing multiple dialog son top of one another is generally not super user-friendly. Having the message appear only when saving is reasonable.
Comment 4 Nate Graham 2020-10-21 03:32:11 UTC
I can look into this when I get a moment of spare time.
Comment 5 Claudius Ellsel 2020-10-21 09:57:46 UTC
Thanks and no rush :)
Comment 6 Méven Car 2020-10-24 06:16:45 UTC
With https://invent.kde.org/frameworks/kio/-/merge_requests/180
We now have a delay before we check filename validity, this should help fix this one.