Bug 427772 - Installing kdenetwork-filesharing results in two "Share" tabs in Dolphin
Summary: Installing kdenetwork-filesharing results in two "Share" tabs in Dolphin
Alias: None
Product: kdenetwork-filesharing
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Harald Sitter
: 435046 435218 (view as bug list)
Depends on:
Reported: 2020-10-15 18:33 UTC by Jordan Hull
Modified: 2021-04-01 14:03 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.12

Screenshot of bug. (11.75 KB, image/png)
2020-10-15 18:33 UTC, Jordan Hull

Note You need to log in before you can comment on or make changes to this bug.
Description Jordan Hull 2020-10-15 18:33:20 UTC
Created attachment 132391 [details]
Screenshot of bug.

Hello all, not sure if this should be filed here or under Dolphin . . . installing package "kdenetwork-filesharing" on latest KDE Neon User Edition results in two "Share" tabs when opening any folder's "Properties" dialog box via Dolphin.

1. Install above-mentioned version of package "kdenetwork-filesharing" on a system with above-mentioned version of Dolphin.
2. Launch Dolphin, right click on any folder, and click "Properties".

OBSERVED RESULT: Two different "Share" tabs in Dolphin's "Properties" dialog box; one blank tab and one tab as expected.

EXPECTED RESULT: One "Share" tab in Dolphin's "Properties" dialog box.


Linux: KDE Neon User Edition (20201015_0947)
(available in About System)
KDE Plasma Version: 5.20.0
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.0
Dolphin: 20.08.2
kdenetwork-filesharing: 4:20.08.2-0xneon+20.04+focal+build7

**Screenshot attached
Comment 1 Nate Graham 2020-10-16 13:52:53 UTC
The QML rewrite hasn't been released yet, so I suspect a packaging issue in Neon.
Comment 2 Fernando Alvarez 2020-10-21 04:23:59 UTC
I confirm the bug.
Comment 3 Nate Graham 2020-10-21 14:23:23 UTC
Are you using Neon, or a different distro?
Comment 4 Harald Sitter 2020-10-21 14:45:43 UTC
preeeeetty sure that's a bug in 20.08

>     properties->addPage(vbox, i18n("&Share"));
>     properties->setFileSharingPage(vbox);
Comment 5 Fernando Alvarez 2020-10-21 14:47:20 UTC
(In reply to Nate Graham from comment #3)
> Are you using Neon, or a different distro?

Yes, I am using Neon 5.20.0
Comment 6 Harald Sitter 2020-10-22 11:54:52 UTC
KIO 5.75 repaired the filesharing page API which now means both lines I mention eventually result in addPage(). I do wonder how we should solve this though, the technically correct solution is to fix KIO by undoing the change and doing it with new API instead of fixing old one as practically KIO isn't meant to break compatibility. OTOH the breakage is already released and will only affect filesharing anyway, so we could just adjust filesharing.
Comment 7 Harald Sitter 2020-11-11 11:14:46 UTC
This is actually already fixed for 20.12, or rather, it wasn't a problem with the newly rewritten code anyway.
Comment 8 Montchenot 2021-02-10 20:55:21 UTC
Still an issue in Fedora KDE Plasma

Fedora 33
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.78.0
Qt Version: 5.15.2
Kernel Version: 5.10.13-200.fc33.x86_64
Dolphin Version: 20.12.2
kdenetwork-filesharing Version: 20.08.1
Comment 9 Montchenot 2021-02-10 21:07:35 UTC
samba-client        Version 4.13.4 Release 0.fc33
samba-client-libs   Version 4.13.4 Release 0.fc33
samba-common        Version 4.13.4 Release 0.fc33
samba-common-libs   Version 4.13.4 Release 0.fc33
samba-libs          Version 4.13.4 Release 0.fc33
Comment 10 Harald Sitter 2021-03-30 13:04:20 UTC
*** Bug 435046 has been marked as a duplicate of this bug. ***
Comment 11 Nate Graham 2021-04-01 14:03:55 UTC
*** Bug 435218 has been marked as a duplicate of this bug. ***