Bug 427669 - Title / header text is duplicated in many settings panes
Summary: Title / header text is duplicated in many settings panes
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: 5.19.90
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-14 01:17 UTC by Adam Fontenot
Modified: 2024-03-04 20:04 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
mockup screenshot (182.55 KB, image/png)
2021-05-21 01:28 UTC, Adam Fontenot
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Fontenot 2020-10-14 01:17:59 UTC
SUMMARY

The same text will frequently appear 3+ times on the same settings window. For example, https://i.imgur.com/F4vXE6O.png "Application Style" appears four times. I can make excuses for three of them in this case, i.e. the window title definitely needs it, the "back" button is identifying which pane you're on, and in this case there's an "Application Style" sub-pane to the main "Application Style" pane.

But the one that seems obviously redundant in every situation I've come across is the one in the largest font, just under the window title. I can't think of any good reason to show this, it doesn't resolve an ambiguity and (IMO) it's rather ugly.

SOFTWARE/OS VERSIONS
Linux: Arch Linux 5.9.0-arch1-1
KDE Plasma Version: 5.20.0 (no option for this in the version box yet)
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.1
Comment 1 Nate Graham 2020-10-16 14:21:12 UTC
Heh yeah.
Comment 2 Adam Fontenot 2021-01-22 03:29:11 UTC
Looking at the 5.21 beta release notes, it seems like this issue is not fixed. https://kde.org/announcements/plasma/5/20.90/kcm_access.png

Has anyone from VDG had a chance to look at this?

(Let me know if it's considered bad etiquette on this bug tracker to ping older issues that there's been no movement on, and I'll stop.)
Comment 3 Nate Graham 2021-01-25 15:42:55 UTC
No, as you can see, nobody has had time to look into this. :) Pinging for old bugs is generally considered unnecessary. If the bug isn't getting done, it means people are overloaded with other work that's considered higher priority. Perhaps you could look into it?
Comment 4 Adam Fontenot 2021-02-17 22:53:09 UTC
(In reply to Nate Graham from comment #3)
> No, as you can see, nobody has had time to look into this. :) Pinging for
> old bugs is generally considered unnecessary. If the bug isn't getting done,
> it means people are overloaded with other work that's considered higher
> priority. Perhaps you could look into it?

Thanks, Nate. I'd be happy to look into improving this, but I was under the impression that things like this were in the domain of the VDG. In other words, don't I need to get a go-ahead from them before trying to change something like this? If not I'm happy to try submitting a patch.
Comment 5 Nate Graham 2021-02-18 01:26:23 UTC
Nope, go right ahead! We don't have a hierarchical or permission-based system here; you work on what you want and submit whatever proposed changes you want. That doesn't mean that they will necessarily be approved of course, but such is life. :)

The real issue here is not so much technical, but rather design. We all know there is a problem here, but fixing it is tricky without radically, fundamentally changing the design or breaking edge cases that have gotten handled over the years.
Comment 6 Nate Graham 2021-04-23 04:26:50 UTC
Well, we're down to three now. :)

Clearly we can't remove the name of the KCM from the list, so our only remaining options are to remove it from the titlebar, the header, or both.

I think it's probably important to have it in at least one of those two places. Having the same title shown in both a list and also the view itself isn't uncommon at all and probably tolerable. :)

So the question is, which one can we remove?

If we remove the one in the titlebar and just make the window title always say, "System Settings", then we'll lose the ability to see the name of the active KCM in Task Manager items and tooltips. This is maybe not that big of a deal, but would technically be a feature regression.

If we remove the the in the header, then we have a giant empty header area with nothing in it, which is pretty awkward-looking IMO.

So I think we probably need to either remove the KCM name from the titlebar text, or else find a way to export the full title to the Task Manager, while only showing "System Settings" in the titlebar itself.
Comment 7 Adam Fontenot 2021-05-21 01:28:50 UTC
Created attachment 138630 [details]
mockup screenshot
Comment 8 Adam Fontenot 2021-05-21 01:30:41 UTC
(In reply to Nate Graham from comment #6)
> Well, we're down to three now. :)
> 
> Clearly we can't remove the name of the KCM from the list, so our only
> remaining options are to remove it from the titlebar, the header, or both.
> 
> I think it's probably important to have it in at least one of those two
> places. Having the same title shown in both a list and also the view itself
> isn't uncommon at all and probably tolerable. :)
> 
> So the question is, which one can we remove?
> 
> If we remove the one in the titlebar and just make the window title always
> say, "System Settings", then we'll lose the ability to see the name of the
> active KCM in Task Manager items and tooltips. This is maybe not that big of
> a deal, but would technically be a feature regression.
> 
> If we remove the the in the header, then we have a giant empty header area
> with nothing in it, which is pretty awkward-looking IMO.
> 
> So I think we probably need to either remove the KCM name from the titlebar
> text, or else find a way to export the full title to the Task Manager, while
> only showing "System Settings" in the titlebar itself.

I added a mockup in an attachment, it doesn't seem so bad to me. I don't mind the empty area so much. It would be fine if KCMs needed to be handled different when displayed outside the System Settings application, I think.

An alternative is suggested by how the "Users" pane is currently handled. Here the header text doesn't just repeat "Users", it instead says something about the purpose of the KCM: "Manage Users". I don't know if it would be possible to do that for all of them, but maybe it's worth looking into.

It's still possible to get more than three copies of a description on the screen at once, by the way. In fact it's now possible to get *five*. If you click "Shortcuts", you'll get it once in the first pane (where you selected it), once in the first header (to show that it's selected), once in the second pane (because the normal shortcuts are separated from custom shortcuts), once in the second header (to show that it's selected), and once in the window title. It's bad looking, or at least confusing, IMO.
Comment 9 Nate Graham 2021-05-21 02:04:47 UTC
You don't think the big empty area looks weird? I kinda think it looks weird.

Yeah "Shortcuts" is bad though. Once we remove KHotkeys (aka "Custom Shortcuts") then we can collapse the group into being just one KCM and we'll be down to just three.

But I get your point.
Comment 10 Adam Fontenot 2024-03-04 20:04:46 UTC
I'm pretty satisfied with the way this looks now in Plasma 6 - a lot more care has been taken in providing a proper system settings hierarchy and the labeling is less haphazard. If a KDE dev or someone in VDG disagree, feel free to re-open.