Bug 427655 - Bugfixes and Improvements to Search
Summary: Bugfixes and Improvements to Search
Status: RESOLVED NOT A BUG
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.11.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-13 19:37 UTC by Clarc
Modified: 2020-10-25 16:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Bug-Screenshot (6.96 KB, image/png)
2020-10-13 19:38 UTC, Clarc
Details
Search-Sidebar (294.10 KB, image/png)
2020-10-13 19:38 UTC, Clarc
Details
Highlight_All-qpdfview (227.31 KB, image/png)
2020-10-13 19:39 UTC, Clarc
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Clarc 2020-10-13 19:37:27 UTC
1. Bug: (See attached Bug-Screenshot) Arrow-icons are cut off at their top/bottom edge.

2. Feature Request: Add option to highlight all occurrences of the search-term. This should make spotting them way easier, even if you're not clicking through every single instance to highlight them one after the other.
Many PDF-readers have this useful feature and I think it's important for Okular to add it as well.
I added a screenshot from "qpdfview" to highlight what I'm talking about.

3. Feature Request: Display the number of occurrences of the search-term. Not as important as the previous feature request, but still a functionality that should make searching way more comfortable.

4. Feature Request: Use the sidebar in the search. Two Options:
4.1. When the user searches, create a fifth sidebar-tab that shows the page and roughly the environment of each found occurrence. (see Sidebar-Screenshot).
4.2 In the sidebar-tab titled "Contents", when the user searches for a term, the chapters that contain the search-term should get highlighted (yellow to keep it consistent)
In my opinion 4.2 seems more important; both could be implemented at the same time though.


Okular seems to me like an amazing, feature-packed pdf-reader. Improvements to the search are pretty much the only thing that is missing for me, personally.



SYSTEM INFORMATION
Linux Mint 20
KDE Frameworks 5.74.0
Qt 5.15.1 (built against 5.15.1)
The xcb windowing system
Comment 1 Clarc 2020-10-13 19:38:02 UTC
Created attachment 132330 [details]
Bug-Screenshot
Comment 2 Clarc 2020-10-13 19:38:28 UTC
Created attachment 132331 [details]
Search-Sidebar
Comment 3 Clarc 2020-10-13 19:39:56 UTC
Created attachment 132332 [details]
Highlight_All-qpdfview
Comment 4 Nate Graham 2020-10-16 17:08:48 UTC
I'm afraid you'll need to re-submit this with each issue in its own bug report. I appreciate the time you took to write all of that down in a single one, but we can't really handle multiple requests in a single bug report. I'd be much obliged if you could file four bug reports, one for each item. Thanks!

See also https://community.kde.org/Get_Involved/Issue_Reporting#One_issue_per_Bugzilla_ticket
Comment 5 Clarc 2020-10-20 19:24:00 UTC
You know, this bugtracker somehow feels so much more painful to use than Github... LibreOffice has the same issue.

However, I appreciate the warm welcome and will eventually create separate issues, once I have time.
Comment 6 Nate Graham 2020-10-20 19:25:31 UTC
FWIW we'd tell you the same thing if we were using bug tracking software. However I feel your pain and I hope that one way we move to Gitlab issues on our Gitlab instance. It's something I support. :)
Comment 7 Clarc 2020-10-25 09:46:51 UTC
They should be created now. No idea where to find them (as "my requests" doesn't seem to do anything), they should exist somewhere though.  :)
Comment 8 Nate Graham 2020-10-25 16:46:41 UTC
Thanks. :)