Bug 427638 - System Tray selection box is too small width-wise
Summary: System Tray selection box is too small width-wise
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray (show other bugs)
Version: 5.19.90
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Konrad Materka
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-10-13 15:05 UTC by The Feren OS Dev
Modified: 2020-10-24 22:22 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/commit/6b25f37496c1a1338b27491afc6dfd548001e4e1
Version Fixed In: 5.20.2

Attachments
the bug in action (1.71 KB, image/jpeg)
2020-10-13 15:06 UTC, The Feren OS Dev 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description The Feren OS Dev 2020-10-13 15:05:04 UTC 
SUMMARY
The 5.20 system tray selection box has been shortened in width compared to 5.19's one, thus meaning it looks ugly on every Plasma Style that has a selection box style that fills (nearly) all of the box.

STEPS TO REPRODUCE
1. Apply a Plasma Style that does that, I guess
2. Be on Plasma 5.20
3. Profit

OBSERVED RESULT
You get the point.

EXPECTED RESULT
The box would be as wide as it is in 5.19 at the very least.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: KDE neon 5.20.0
(available in About System)
KDE Plasma Version: 5.20.0
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.0

ADDITIONAL INFORMATION
....
Comment 1 The Feren OS Dev 2020-10-13 15:06:51 UTC 
Created attachment 132323 [details]
the bug in action
Comment 2 Nate Graham 2020-10-13 18:49:15 UTC 
Can confirm. Let's see if I can fix it.
Comment 3 Nate Graham 2020-10-13 20:23:20 UTC 
In main.qml, the issue seems to be that activeApplet.parent has smaller dimensions than what's visible in the UI.
Comment 4 Nate Graham 2020-10-13 20:39:16 UTC 
Changing

changeHighlightedItem(activeApplet.parent);

to 

changeHighlightedItem(tasksGrid.currentItem.item);

Seems to fix it, but then the highlight effect doesn't move anymore as the active applet is changed.

Giving up for now.
Comment 5 The Feren OS Dev 2020-10-14 10:45:51 UTC 
Could spacing be potentially decreased while then increasing the width of the parent's box as to counteract the spacing decrease, potentially, maybe?
Comment 6 Nate Graham 2020-10-14 14:56:53 UTC 
That's not really a correct change and wouldn't fix it anyway due to the above bug

Needs further investigation.
Comment 7 Bug Janitor Service 2020-10-23 16:41:08 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/383
Comment 8 Konrad Materka 2020-10-23 16:42:48 UTC 
I think I have a fix:
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/383

You can manually apply this by modifying files in:
/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/
Comment 9 Konrad Materka 2020-10-24 22:14:53 UTC 
Git commit db009f5af5a1519d7d2fc536b604d98cbaf52cad by Konrad Materka.
Committed on 24/10/2020 at 22:13.
Pushed by kmaterka into branch 'master'.

[applets/systemtray] Make highlight wider

Make current item highlight wider, to fill width of active area of applet.
FIXED-IN: 5.21

M  +1    -0    applets/systemtray/package/contents/ui/items/AbstractItem.qml
M  +1    -1    applets/systemtray/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/db009f5af5a1519d7d2fc536b604d98cbaf52cad
Comment 10 Konrad Materka 2020-10-24 22:22:56 UTC 
Git commit 6b25f37496c1a1338b27491afc6dfd548001e4e1 by Konrad Materka.
Committed on 24/10/2020 at 22:19.
Pushed by kmaterka into branch 'Plasma/5.20'.

[applets/systemtray] Make highlight wider

Make current item highlight wider, to fill width of active area of applet.
FIXED-IN: 5.20.2

M  +1    -0    applets/systemtray/package/contents/ui/items/AbstractItem.qml
M  +1    -1    applets/systemtray/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/6b25f37496c1a1338b27491afc6dfd548001e4e1