Bug 427511 - Build fails with quazip 1.0
Summary: Build fails with quazip 1.0
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 4.3.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-10 12:22 UTC by Luigi Baldoni
Modified: 2020-10-12 09:54 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Build log snippet for krita 4.3.0 and quazip 1.0 (1.74 KB, text/plain)
2020-10-10 12:22 UTC, Luigi Baldoni
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Luigi Baldoni 2020-10-10 12:22:07 UTC
Created attachment 132260 [details]
Build log snippet for krita 4.3.0 and quazip 1.0

SUMMARY
Using openSUSE Tumbleweed with cmake 3.18.3

STEPS TO REPRODUCE
1. Install quazip 1.0
2. Run cmake as per attachment

OBSERVED RESULT
Quazip detection fails (see attached log snippet)

EXPECTED RESULT
Quazip being properly detected, as it was until version 0.9

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Tumbleweed
(available in About System)
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 20.04.2
Qt Version: 5.15.1

ADDITIONAL INFORMATION
Comment 1 Halla Rempt 2020-10-10 12:24:25 UTC
This is not a build failure, of course. The package cannot be found at all:

--   Package 'quazip', required by 'virtual:world', not found

Are you sure you installed the qt5 version of the quazip package?
Comment 2 Luigi Baldoni 2020-10-10 12:30:07 UTC
> Are you sure you installed the qt5 version of the quazip package?

Yes, I am. Quazip 1.0 now uses a different suffix (-Qt5 instead of 5).
Comment 3 Bug Janitor Service 2020-10-11 04:33:15 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 4 Wolfgang Bauer 2020-10-11 14:58:10 UTC
This is fixed by https://invent.kde.org/graphics/krita/-/merge_requests/513 .

Unfortunately, it broke again with quazip 1.1...
Comment 5 Bug Janitor Service 2020-10-11 15:18:14 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/531
Comment 6 Bug Janitor Service 2020-10-11 21:08:12 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/532
Comment 7 Antonio Rojas 2020-10-12 07:52:50 UTC
Git commit f7b17aed7c7b4e7de8b19ce13edc3eab2bc5f7f3 by Antonio Rojas.
Committed on 11/10/2020 at 21:06.
Pushed by rempt into branch 'master'.

More robust check for quazip 1.x

Search for quazip's own cmake config first, and fallback to finding the libraries and include dirs manually as before

M  +11   -7    cmake/modules/FindQuaZip.cmake

https://invent.kde.org/graphics/krita/commit/f7b17aed7c7b4e7de8b19ce13edc3eab2bc5f7f3
Comment 8 Halla Rempt 2020-10-12 09:00:58 UTC
Git commit 7576587df89b2aed16a5fe2e1ee59504e7ab1cba by Boudewijn Rempt, on behalf of Antonio Rojas.
Committed on 12/10/2020 at 09:00.
Pushed by rempt into branch 'krita/4.3'.

More robust check for quazip 1.x

Search for quazip's own cmake config first, and fallback to finding the libraries and include dirs manually as before
(cherry picked from commit f7b17aed7c7b4e7de8b19ce13edc3eab2bc5f7f3)

M  +8    -4    cmake/modules/FindQuaZip.cmake

https://invent.kde.org/graphics/krita/commit/7576587df89b2aed16a5fe2e1ee59504e7ab1cba
Comment 9 Dmitry Kazakov 2020-10-12 09:54:25 UTC
Git commit 44697d282f56007e7a94a5fcdad8e7698cca2fb6 by Dmitry Kazakov, on behalf of Antonio Rojas.
Committed on 12/10/2020 at 09:48.
Pushed by dkazakov into branch 'krita/4.4.0'.

More robust check for quazip 1.x

Search for quazip's own cmake config first, and fallback to finding the libraries and include dirs manually as before
(cherry picked from commit f7b17aed7c7b4e7de8b19ce13edc3eab2bc5f7f3)

M  +8    -4    cmake/modules/FindQuaZip.cmake

https://invent.kde.org/graphics/krita/commit/44697d282f56007e7a94a5fcdad8e7698cca2fb6