Bug 427422 - Option to draw turquoise line under the titlebar in Breeze window decoration theme conflicts with line drawn by Breeze widget theme
Summary: Option to draw turquoise line under the titlebar in Breeze window decoration ...
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: window decoration (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-10-07 16:22 UTC by popov895
Modified: 2021-09-16 21:13 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.24
Sentry Crash Report:


Attachments
Option is disabled (115.58 KB, image/png)
2020-10-07 16:23 UTC, popov895
Details
Option is enabled (119.23 KB, image/png)
2020-10-07 16:23 UTC, popov895
Details

Note You need to log in before you can comment on or make changes to this bug.
Description popov895 2020-10-07 16:22:16 UTC
SUMMARY

The separator under the window's titlebar is shown even if the option (Application Style > Window Decoration > Breeze > Edit Breeze Theme > Draw separator under active window's titlebar) is disabled. When this option is enabled, two separators are shown.

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.0
Comment 1 popov895 2020-10-07 16:23:21 UTC
Created attachment 132193 [details]
Option is disabled
Comment 2 popov895 2020-10-07 16:23:38 UTC
Created attachment 132194 [details]
Option is enabled
Comment 3 Nate Graham 2020-10-07 19:10:47 UTC
Ugh, that setting!

Now we have a separate setting in the widget theme to disable the unified toolbar+titlebar appearance, which effectively does the same thing, but at the level of the widget theme rather than the window decoration, and with a different-colored separator.

Given that this setting to draw the cyan separator has been off by default for years because users didn't like it, I propose that we delete it and use the new unified-or-not-setting in the window decoration for this.
Comment 4 popov895 2020-10-08 07:42:26 UTC
(In reply to Nate Graham from comment #3)
> Now we have a separate setting in the widget theme to disable the unified
> toolbar+titlebar appearance, which effectively does the same thing, but at
> the level of the widget theme rather than the window decoration, and with a
> different-colored separator.
So is this unified toolbar+titlebar appearance a piece of the Breeze Evolution? Can't find an option to disable it.

> Given that this setting to draw the cyan separator has been off by default
> for years because users didn't like it, I propose that we delete it and use
> the new unified-or-not-setting in the window decoration for this.
In this case, this option looks like redundant.
Comment 5 popov895 2020-10-17 08:16:12 UTC
Will it be possible to disable this unified toolbar+titlebar appearance?
Comment 6 Nate Graham 2020-10-17 13:56:08 UTC
Yes, simply don't use a color scheme with Header colors in it. Then, the unified appearance will be disabled. and no extra line will be drawn once https://invent.kde.org/plasma/breeze/-/merge_requests/39 is merged.

Either way, when the unified appearance is being used, we should probably suppress this turquoise line.
Comment 7 Bug Janitor Service 2021-09-16 20:01:52 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/138
Comment 8 Nate Graham 2021-09-16 21:13:49 UTC
Git commit 660b7ecca77371a47b01886d7d07f87c8b5d1915 by Nate Graham.
Committed on 16/09/2021 at 20:09.
Pushed by ngraham into branch 'master'.

Remove "Draw separator under active window's titlebar" windeco option

This option is off by default and has been for several years, after it
was briefly turned on by default and proved to be unpopular with users,
generating many complaints and bug reports. The line uses a semantically
inappropriate highlight color which is far too visually bright, and it
doesn't look good with any of our header-color-using color schemes.
Arguably it never looked good with older color schemes where the titlebar
and window background use different colors either. Let's remove this
option.
FIXED-IN: 5.24

M  +0    -25   kdecoration/breezedecoration.cpp
M  +0    -1    kdecoration/breezedecoration.h
M  +0    -4    kdecoration/breezesettingsdata.kcfg
M  +0    -5    kdecoration/config/breezeconfigwidget.cpp
M  +0    -8    kdecoration/config/ui/breezeconfigurationui.ui

https://invent.kde.org/plasma/breeze/commit/660b7ecca77371a47b01886d7d07f87c8b5d1915