Bug 427251 - Systray icons limited to 2 rows on very thick panels
Summary: Systray icons limited to 2 rows on very thick panels
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray (show other bugs)
Version: 5.19.90
Platform: Other Linux
: VHI minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-10-02 14:37 UTC by agentxlax
Modified: 2020-10-02 22:37 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.20


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description agentxlax 2020-10-02 14:37:04 UTC
Instead of waiting on the Plasma 5.20 release to run a fresh install of EOS I decided to go ahead and install EOS and install the Plasma 5.20 beta. Almost everything I want installed using yay and flatpak, mostly tweaked and really looking good. The only thing I can't seem to find is a workaround for the systray Icons. As you can see from the image I have two rows, but with the width / height I have the panel there should be three rows. I would prefer three rows so items on the right don’t get pushed too far left. Has anyone else tested out the beta for Plasma and maybe know of a fix for the systray? Thanks

https://i.imgur.com/bNAOFbI.png

https://forum.kde.org/viewtopic.php?f=289&t=168077

https://forum.endeavouros.com/t/limited-number-of-rows-for-systray-icons/8540
Comment 1 Konrad Materka 2020-10-02 15:20:51 UTC
Nate, as I can see from commit log, this is intended, right?
Comment 2 Nate Graham 2020-10-02 15:28:50 UTC
Currently yes. Easily changeable though. I can look into it, since I can see that this is indeed a minor regression for people with really really thick panels.
Comment 3 Bug Janitor Service 2020-10-02 15:57:25 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/317
Comment 4 Nate Graham 2020-10-02 15:57:52 UTC
Please test the above if possible :)
Comment 5 agentxlax 2020-10-02 19:17:10 UTC
WOW looks like you guys are right on top of this. I'm assuming the link in the above post is for internal testing for right now?
Comment 6 Konrad Materka 2020-10-02 20:01:17 UTC
Nate created a fix in 8 minutes, which is impressively super fast!

@agentxlax you can test this fix without compiling Plasma from sources, just modify:
/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/main.qml
and change line:
> readonly property int rowsOrColumns: autoSize || cellThickness <= smallIconSize * 2 ? 1 : 2
to
> readonly property int rowsOrColumns: autoSize ? 1 : Math.max(1, Math.floor(cellThickness / smallIconSize))
Comment 7 Nate Graham 2020-10-02 20:45:51 UTC
Git commit 649b50cdfe5e177f03e4cc075a8e50507eb47636 by Nate Graham.
Committed on 02/10/2020 at 20:45.
Pushed by ngraham into branch 'master'.

[applets/systemtray] Fix size of grid on really thick panels

Now the grid can have more than 2 rows/columns on really thick panels,
just like in Plasma 5.19 and earlier.
FIXED-IN: 5.20

M  +1    -1    applets/systemtray/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/649b50cdfe5e177f03e4cc075a8e50507eb47636
Comment 8 Nate Graham 2020-10-02 20:46:41 UTC
Git commit a54d1901bdb4ee1fe2aeb22786893997173d31f1 by Nate Graham.
Committed on 02/10/2020 at 20:46.
Pushed by ngraham into branch 'Plasma/5.20'.

[applets/systemtray] Fix size of grid on really thick panels

Now the grid can have more than 2 rows/columns on really thick panels,
just like in Plasma 5.19 and earlier.
FIXED-IN: 5.20


(cherry picked from commit 649b50cdfe5e177f03e4cc075a8e50507eb47636)

M  +1    -1    applets/systemtray/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/a54d1901bdb4ee1fe2aeb22786893997173d31f1
Comment 9 Nate Graham 2020-10-02 20:47:33 UTC
Too late, someone else reviewed it and I merged. :)
Comment 10 agentxlax 2020-10-02 22:25:16 UTC
Thanks looks perfect, greatly appreciated.

blob:blob://https://imgur.com/713d92aa-63b1-4835-9a03-a75868eb30c3