Bug 427172 - Some texts in the window's specific preferences dialog appear untranslated
Summary: Some texts in the window's specific preferences dialog appear untranslated
Status: RESOLVED FIXED
Alias: None
Product: i18n
Classification: Translations
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Albert Astals Cid
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-30 18:40 UTC by Eloy Cuadra
Modified: 2020-10-01 18:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.20
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eloy Cuadra 2020-09-30 18:40:44 UTC
SUMMARY

If you click the right mouse button on the title bar of any window and select the option "More actions -> Configure special window preferences", the dialog that appears shows some texts untranslated into the user's language. Texts for the radio buttons "Yes" and "No", the buttons "Add Properties" and "Detect Window Properties" at the bottom, and the texts "Instantly" and "After X seconds" appear in English. But if you go to the System Settings, "Workspace" section, "Window management -> Window rules", the same texts appear fully translated into the user's language.

Tested in Spanish and Catalan, but I guess this issue affects all languages.

STEPS TO REPRODUCE
1. Click the right mouse button on the title bar of any window in Plasma.
2. Select "More Actions -> Configure Special Window Settings..."

OBSERVED RESULT
Some text are not translated in the dialog that appear.

EXPECTED RESULT
All text should be translated in that dialog.

SOFTWARE/OS VERSIONS
Linux: 5.3.18 (openSUSE Leap 15.2)
KDE Plasma Version: 5.19 and 5.19.90
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.1

ADDITIONAL INFORMATION
Tested only on openSUSE Leap 15.2, but it may affect other (or all) distros.
Comment 1 Bug Janitor Service 2020-09-30 22:30:04 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/311
Comment 2 Albert Astals Cid 2020-10-01 00:48:43 UTC
Git commit 743b06d3a18728077f20c4e8879c86e4ca44c635 by Albert Astals Cid.
Committed on 30/09/2020 at 22:29.
Pushed by apol into branch 'master'.

Fix kwin_rules_dialog not showing translated strings

M  +3    -0    kcmkwin/kwinrules/main.cpp

https://invent.kde.org/plasma/kwin/commit/743b06d3a18728077f20c4e8879c86e4ca44c635
Comment 3 Aleix Pol 2020-10-01 10:34:59 UTC
Git commit 1dfbac734849365014f23a780a18af74242bbc14 by Aleix Pol Gonzalez, on behalf of Albert Astals Cid.
Committed on 01/10/2020 at 10:34.
Pushed by apol into branch 'Plasma/5.20'.

Fix kwin_rules_dialog not showing translated strings


(cherry picked from commit 743b06d3a18728077f20c4e8879c86e4ca44c635)

M  +3    -0    kcmkwin/kwinrules/main.cpp

https://invent.kde.org/plasma/kwin/commit/1dfbac734849365014f23a780a18af74242bbc14
Comment 4 Eloy Cuadra 2020-10-01 10:49:40 UTC
Thank you very much for solving so quickly!