Bug 427171 - Negative Text color is barely readable with Breeze Dark color scheme
Summary: Negative Text color is barely readable with Breeze Dark color scheme
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: general (show other bugs)
Version: 5.19.90
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-30 18:33 UTC by Patrick Silva
Modified: 2020-10-09 02:13 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/plasma-framework/commit/21b27e90bf938bc66b555f108c8114d74a678bf6
Version Fixed In: 5.76
Sentry Crash Report:

Attachments
screenshot (50.90 KB, image/png)
2020-09-30 18:33 UTC, Patrick Silva 		Details
RGB font rendering (310.91 KB, image/png)
2020-10-07 03:38 UTC, Patrick Silva 		Details
Real negative text vs modified negative text (22.48 KB, image/png)
2020-10-07 04:54 UTC, Noah Davis 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-09-30 18:33:54 UTC 
Created attachment 132029 [details]
screenshot

STEPS TO REPRODUCE
1. have an internal device with low free space available in its partition
2. set global theme to Breeze Dark
3. open Disks & Devices applet
4. set "Show" combobox on top to "Non-removable devices"

OBSERVED RESULT
barely readable free space in red, see the attached screenshot please.

EXPECTED RESULT
better readability

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.19.90
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.1
Comment 1 Nate Graham 2020-10-05 20:22:09 UTC 
I wouldn't exactly call that "barely readable," but I see what you mean. The contrast isn't amazing. Since we're just using the standard "Negative Text" color from the color scheme, this would be a potential bug with the Breeze Dark color scheme.
Comment 2 Noah Davis 2020-10-07 01:28:57 UTC 
Just to be sure that this is not a font configuration issue, do you have a BGR screen and are you using BGR sub-pixel font rendering?
Comment 3 Noah Davis 2020-10-07 01:35:47 UTC 
I ask because it appears that you are using BGR sub-pixel font rendering, which is different from what I've seen most monitors use (RGB)
Comment 4 Patrick Silva 2020-10-07 03:38:53 UTC 
Created attachment 132183 [details]
RGB font rendering

I was using BGR font rendering, I changed to RGB and the issue persists.
Comment 5 Noah Davis 2020-10-07 04:54:38 UTC 
Created attachment 132184 [details]
Real negative text vs modified negative text

Ok, I think I know what the issue is. The small text that uses NegativeText also has reduced opacity, which causes the legibility to be significantly reduced.
Comment 6 Nate Graham 2020-10-07 14:30:34 UTC 
Ah, maybe this is a bug with the component itself though. We do typically use smaller and less-opaque text for the subtitle of this kind of list item. I guess that doesn't work so well for colored text. I'll see what I can do with it.
Comment 7 Bug Janitor Service 2020-10-07 15:03:46 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/107
Comment 8 Nate Graham 2020-10-09 02:13:39 UTC 
Git commit 21b27e90bf938bc66b555f108c8114d74a678bf6 by Nate Graham.
Committed on 09/10/2020 at 02:13.
Pushed by ngraham into branch 'master'.

[ExpandableListItem] Make colored text 100% opaque

Otherwise it can be difficult to see, especially with dark backgrounds.
Also, let's set the opacity directly rather than using the enabled
property to approximate it.
FIXED-IN: 5.76

M  +3    -1    src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

https://invent.kde.org/frameworks/plasma-framework/commit/21b27e90bf938bc66b555f108c8114d74a678bf6