Bug 427076 - Minimized window thumbnails show both icon and content
Summary: Minimized window thumbnails show both icon and content
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager (show other bugs)
Version: 5.19.90
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords: wayland
Depends on:
Blocks:
 
Reported: 2020-09-28 15:45 UTC by tromzy
Modified: 2020-09-30 14:24 UTC (History)
5 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/commit/250efd62ef5c4a121d775498b73d01e5f7b01975
Version Fixed In: 5.20

Attachments
The thumbnail show both icon and content (234.74 KB, image/png)
2020-09-28 15:45 UTC, tromzy 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description tromzy 2020-09-28 15:45:55 UTC 
Created attachment 131988 [details]
The thumbnail show both icon and content

SUMMARY
In Plasma Wayland 5.19.90, when a window is minimized, the thumbnail show both its icon and its content (see attached screenshot). I think it should show only the icon.

STEPS TO REPRODUCE
1. Open an app in a Wayland session
2. Minimize it
3. Put mouse pointer on its icon in Icon-only task manager

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.19.90
KDE Frameworks Version: 5.74
Qt Version: 5.15.1

ADDITIONAL INFORMATION
Comment 1 Patrick Silva 2020-09-29 17:20:01 UTC 
I can confirm this bug on Arch Linux. Classic task manager is also affected.

Operating System: Arch Linux
KDE Plasma Version: 5.19.90
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.1
Comment 2 Nate Graham 2020-09-29 18:26:44 UTC 
heh oops!
Comment 3 Nate Graham 2020-09-29 18:52:03 UTC 
Fixing it might be as simple as something like this:

diff --git applets/taskmanager/package/contents/ui/ToolTipInstance.qml applets/taskmanager/package/contents/ui/ToolTipInstance.qml
index 24d131a92..0a0b51011 100644
--- applets/taskmanager/package/contents/ui/ToolTipInstance.qml
+++ applets/taskmanager/package/contents/ui/ToolTipInstance.qml
@@ -230,7 +230,7 @@ ColumnLayout {
             source: thumbnailSourceItem.isMinimized && !albumArtImage.visible && Number.isInteger(thumbnailSourceItem.winId) ? icon : ""
             animated: false
             usesPlasmaTheme: false
-            visible: valid
+            visible: valid && !pipeWireLoader.active
         }
 
         ToolTipWindowMouseArea {


I'll test soon.
Comment 4 Bug Janitor Service 2020-09-30 14:17:15 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/168
Comment 5 Nate Graham 2020-09-30 14:23:09 UTC 
Git commit 5a049e833c611b1d57c6b7a3b9a7a60ed99ccad7 by Nate Graham.
Committed on 30/09/2020 at 14:13.
Pushed by ngraham into branch 'master'.

[applets/taskmanager] Don't show icons on top of thumbnails on Wayland
FIXED-IN: 5.20

M  +1    -1    applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://invent.kde.org/plasma/plasma-desktop/commit/5a049e833c611b1d57c6b7a3b9a7a60ed99ccad7
Comment 6 Nate Graham 2020-09-30 14:24:11 UTC 
Git commit 250efd62ef5c4a121d775498b73d01e5f7b01975 by Nate Graham.
Committed on 30/09/2020 at 14:24.
Pushed by ngraham into branch 'Plasma/5.20'.

[applets/taskmanager] Don't show icons on top of thumbnails on Wayland
FIXED-IN: 5.20


(cherry picked from commit 5a049e833c611b1d57c6b7a3b9a7a60ed99ccad7)

M  +1    -1    applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://invent.kde.org/plasma/plasma-desktop/commit/250efd62ef5c4a121d775498b73d01e5f7b01975