Bug 427032 - System Activity window ignores window border size option
Summary: System Activity window ignores window border size option
Status: RESOLVED DUPLICATE of bug 315400
Alias: None
Product: ksysguard
Classification: Applications
Component: Process Controller - krunner part (show other bugs)
Version: 5.19.90
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-27 15:01 UTC by popov895
Modified: 2020-09-29 20:20 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Border size set to none (90.48 KB, image/png)
2020-09-27 15:01 UTC, popov895 		Details
Border size set to normal (90.85 KB, image/png)
2020-09-27 15:01 UTC, popov895 		Details
Before commit 42e2078cfd41396ceb6d78746f2ebbdd53b11ee8 (103.48 KB, image/png)
2020-09-28 09:48 UTC, popov895 		Details
Different margin sizes (652.18 KB, image/png)
2020-09-29 20:03 UTC, popov895 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description popov895 2020-09-27 15:01:00 UTC 
Created attachment 131967 [details]
Border size set to none

SUMMARY

I prefer to set window border size to none, which is default value for Breeze theme, and all applications follow this value except System Activity window. Moreover, if set window border size to normal, then the border size of System Activity window becomes huge. This came after the commit 42e2078cfd41396ceb6d78746f2ebbdd53b11ee8. I guess that margins should only be around the buttons, not the ListView.

OBSERVED RESULT

System Activity window ignores window border size option

EXPECTED RESULT

System Activity window follows window border size option

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 7.75.0
Qt Version: 5.15.0
Comment 1 popov895 2020-09-27 15:01:28 UTC 
Created attachment 131968 [details]
Border size set to normal
Comment 2 David Redondo 2020-09-28 08:46:42 UTC 
There is no window border here, the border you are seeing is drawn by the application inside the window, not the window (decoration)
Comment 3 Christoph Feck 2020-09-28 09:31:05 UTC 
> margins should only be around the buttons, not the ListView

Makes sense.
Comment 4 popov895 2020-09-28 09:48:30 UTC 
Created attachment 131980 [details]
Before commit 42e2078cfd41396ceb6d78746f2ebbdd53b11ee8
Comment 5 Christoph Feck 2020-09-28 11:03:57 UTC 
Actually there have previously been margins around the complete window in older Plasma/frameworks versions, but some refactoring incorrectly removed them, which regressed the missing margins around the buttons.

See also bug 315400.
Comment 6 Nate Graham 2020-09-29 18:01:17 UTC 
It's not ignoring the border size option; the window itself adds margins around the content items *in addition* to any borders provided by the window decoration theme. Being a dialog window, the margins that it adds are larger than the margins added by non-dialog windows.

Before 42e2078cfd41396ceb6d78746f2ebbdd53b11ee8, the effect that you want was still not possible. Rather, the list view frame was still drawn, but it was touching the window edges, which looks bad. What (I think) you want is for the list view to have no visible frame and to touch the left, right, and bottom edges of the window. In order to do that, we need to make a lot of other UI changes, such as turning off the listview frame and all internal margins, and then add margins to the button row. Basically we have to stop assuming that there will always be some kind of margin around the window itself.

This is a duplicate of the issue that Bug 315400 was attempting to report. I have re-opened it, as it seems that I closed it in error.

*** This bug has been marked as a duplicate of bug 315400 ***
Comment 7 popov895 2020-09-29 20:03:18 UTC 
Created attachment 132013 [details]
Different margin sizes

Ok, but could you please make these margins smaller?
Comment 8 Nate Graham 2020-09-29 20:20:13 UTC 
Yes, see the duped bug.