Bug 426898 - Dolphin not opening
Summary: Dolphin not opening
Status: RESOLVED DUPLICATE of bug 429628
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 20.08.1
Platform: Neon Linux
: NOR crash
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: drkonqi
: 427418 430758 430831 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-09-23 11:01 UTC by Dr.Dev
Modified: 2020-12-28 20:41 UTC (History)
11 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Valgrind log (72.65 KB, text/plain)
2020-12-02 08:02 UTC, Tony
Details
New crash information added by DrKonqi (7.84 KB, text/plain)
2020-12-16 11:47 UTC, joecitizen555
Details
New crash information added by DrKonqi (8.97 KB, text/plain)
2020-12-18 07:41 UTC, Ali
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dr.Dev 2020-09-23 11:01:56 UTC
Application: dolphin (20.08.1)

Qt Version: 5.15.0
Frameworks Version: 5.74.0
Operating System: Linux 5.4.0-48-generic x86_64
Windowing system: X11
Distribution: KDE neon User Edition 5.19

-- Information about the crash:
dolphin not opening and crash every time.

The crash can be reproduced every time.

-- Backtrace:
Application: Dolphin (dolphin), signal: Segmentation fault

[KCrash Handler]
#4  0x00007f834f02f38d in DolphinViewContainer::url (this=0x0) at ./src/dolphinviewcontainer.cpp:273
#5  0x00007f834f0269c5 in DolphinMainWindow::preferredSearchTool (this=this@entry=0x560b35bb7c70) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:794
#6  0x00007f834f026ce5 in DolphinMainWindow::updateOpenPreferredSearchToolAction (this=0x560b35bb7c70) at ./src/dolphinmainwindow.cpp:994
#7  0x00007f834cc37129 in QObject::event (this=this@entry=0x560b35bb7c70, e=e@entry=0x560b3604b130) at kernel/qobject.cpp:1314
#8  0x00007f834d861d5d in QWidget::event (this=this@entry=0x560b35bb7c70, event=event@entry=0x560b3604b130) at kernel/qwidget.cpp:9088
#9  0x00007f834d97aa18 in QMainWindow::event (this=this@entry=0x560b35bb7c70, event=event@entry=0x560b3604b130) at widgets/qmainwindow.cpp:1341
#10 0x00007f834e35bc3b in KMainWindow::event (this=this@entry=0x560b35bb7c70, ev=ev@entry=0x560b3604b130) at ./src/kmainwindow.cpp:911
#11 0x00007f834e3a68eb in KXmlGuiWindow::event (this=0x560b35bb7c70, ev=0x560b3604b130) at ./src/kxmlguiwindow.cpp:109
#12 0x00007f834f01f958 in DolphinMainWindow::event (this=<optimized out>, event=<optimized out>) at ./src/dolphinmainwindow.cpp:2339
#13 0x00007f834d81ecc3 in QApplicationPrivate::notify_helper (this=this@entry=0x560b35b61830, receiver=receiver@entry=0x560b35bb7c70, e=e@entry=0x560b3604b130) at kernel/qapplication.cpp:3671
#14 0x00007f834d827c70 in QApplication::notify (this=0x7ffea0f9aab0, receiver=0x560b35bb7c70, e=0x560b3604b130) at kernel/qapplication.cpp:3417
#15 0x00007f834cc096aa in QCoreApplication::notifyInternal2 (receiver=0x560b35bb7c70, event=0x560b3604b130) at ../../include/QtCore/5.15.0/QtCore/private/../../../../../src/corelib/thread/qthread_p.h:325
#16 0x00007f834cc0bfa1 in QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=0, data=0x560b35b56ee0) at kernel/qcoreapplication.cpp:1815
#17 0x00007f834cc64837 in postEventSourceDispatch (s=0x560b35bb54c0) at kernel/qeventdispatcher_glib.cpp:277
#18 0x00007f834a9f3fbd in g_main_context_dispatch () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#19 0x00007f834a9f4240 in ?? () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#20 0x00007f834a9f42e3 in g_main_context_iteration () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#21 0x00007f834cc63e92 in QEventDispatcherGlib::processEvents (this=0x560b35bc4d20, flags=...) at kernel/qeventdispatcher_glib.cpp:423
#22 0x00007f834cc081bb in QEventLoop::exec (this=this@entry=0x7ffea0f9a380, flags=..., flags@entry=...) at ../../include/QtCore/../../src/corelib/global/qflags.h:141
#23 0x00007f834da2a20d in QDialog::exec (this=this@entry=0x7ffea0f9a410) at ../../include/QtCore/../../src/corelib/global/qflags.h:121
#24 0x00007f834da641f6 in showNewMessageBox (parent=<optimized out>, icon=icon@entry=QMessageBox::Critical, title=..., text=..., buttons=..., defaultButton=defaultButton@entry=QMessageBox::NoButton) at dialogs/qmessagebox.cpp:1647
#25 0x00007f834da6431a in QMessageBox::critical (parent=<optimized out>, title=..., text=..., buttons=..., buttons@entry=..., defaultButton=defaultButton@entry=QMessageBox::NoButton) at dialogs/qmessagebox.cpp:1779
#26 0x00007f834eb76d38 in KBookmarkManager::saveAs (this=0x560b3609d2e0, filename=..., toolbarCache=toolbarCache@entry=true) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qflags.h:121
#27 0x00007f834ec1ffbe in KFilePlacesModel::KFilePlacesModel (this=<optimized out>, alternativeApplicationName=..., parent=<optimized out>) at ./src/filewidgets/kfileplacesmodel.cpp:364
#28 0x00007f834f0365fb in DolphinPlacesModelSingleton::DolphinPlacesModelSingleton (this=0x7f834f0caad8 <DolphinPlacesModelSingleton::instance()::s_self>) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qstringbuilder.h:147
#29 0x00007f834f03671c in DolphinPlacesModelSingleton::instance () at ./src/dolphinplacesmodelsingleton.cpp:34
#30 0x00007f834f030da5 in DolphinViewContainer::DolphinViewContainer (this=0x560b35fabcd0, url=..., parent=<optimized out>) at ./src/dolphinviewcontainer.cpp:99
#31 0x00007f834f037a05 in DolphinTabPage::createViewContainer (this=this@entry=0x560b35fabc60, url=...) at ./src/dolphintabpage.cpp:370
#32 0x00007f834f037c43 in DolphinTabPage::DolphinTabPage (this=0x560b35fabc60, primaryUrl=..., secondaryUrl=..., parent=<optimized out>) at ./src/dolphintabpage.cpp:43
#33 0x00007f834f0399a4 in DolphinTabWidget::openNewTab (this=this@entry=0x560b35c129a0, primaryUrl=..., secondaryUrl=..., tabPlacement=tabPlacement@entry=DolphinTabWidget::AfterLastTab) at ./src/dolphintabwidget.cpp:171
#34 0x00007f834f039ba2 in DolphinTabWidget::openNewActivatedTab (this=this@entry=0x560b35c129a0, primaryUrl=..., secondaryUrl=...) at ./src/dolphintabwidget.cpp:163
#35 0x00007f834f039fee in DolphinTabWidget::openDirectories (this=0x560b35c129a0, dirs=..., splitView=splitView@entry=false) at ./src/dolphintabwidget.cpp:219
#36 0x00007f834f01d490 in DolphinMainWindow::openDirectories (this=this@entry=0x560b35bb7c70, dirs=..., splitView=splitView@entry=false) at ./src/dolphinmainwindow.cpp:230
#37 0x00007f834f01920b in kdemain (argc=<optimized out>, argv=<optimized out>) at ./src/main.cpp:176
#38 0x00007f834edff0b3 in __libc_start_main (main=0x560b34c12060 <main>, argc=1, argv=0x7ffea0f9ac58, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffea0f9ac48) at ../csu/libc-start.c:308
#39 0x0000560b34c1209e in _start ()
[Inferior 1 (process 6736) detached]

Reported using DrKonqi
Comment 1 Nate Graham 2020-09-23 14:54:22 UTC
[KCrash Handler]
#4  0x00007f834f02f38d in DolphinViewContainer::url (this=0x0) at ./src/dolphinviewcontainer.cpp:273
#5  0x00007f834f0269c5 in DolphinMainWindow::preferredSearchTool (this=this@entry=0x560b35bb7c70) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:794
#6  0x00007f834f026ce5 in DolphinMainWindow::updateOpenPreferredSearchToolAction (this=0x560b35bb7c70) at ./src/dolphinmainwindow.cpp:994

That's odd.
Comment 2 Christoph Feck 2020-09-23 19:41:50 UTC
KBookmarkManager::saveAs() shows a critical messagebox at #25, which runs a nested event loop. The object tree is probably modified because of user actions that are handled there.
Comment 3 Nate Graham 2020-10-07 13:59:50 UTC
*** Bug 427418 has been marked as a duplicate of this bug. ***
Comment 4 Nate Graham 2020-10-07 14:00:35 UTC
[KCrash Handler]
#4  0x00007f834f02f38d in DolphinViewContainer::url (this=0x0) at ./src/dolphinviewcontainer.cpp:273
#5  0x00007f834f0269c5 in DolphinMainWindow::preferredSearchTool (this=this@entry=0x560b35bb7c70) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:794
#6  0x00007f834f026ce5 in DolphinMainWindow::updateOpenPreferredSearchToolAction (this=0x560b35bb7c70) at ./src/dolphinmainwindow.cpp:994
Comment 5 Tony 2020-12-02 08:02:20 UTC
Created attachment 133797 [details]
Valgrind log

I am not entirely sure if am hitting this one, please check the attachment.

In my case if i run dolphin throw valgrind it will crash immediately.
Running it normally it will open but as soon as i right click over any white space or over folder/file in the dolphin window it will crash with no logs or dumps indicating what happen.
Comment 6 Martin Sandsmark 2020-12-11 15:13:30 UTC
Introduced by this, I think:

commit 9f268f5f76a4a4f0c91abcc213e159c8bde4869c
  Author: Kai Uwe Broulik <kde@privat.broulik.de>
  Date:   Tue May 5 12:05:18 2020 +0200
  
      Don't use local URL for KMoreTool
      
      This method is called a billion times and spawns a blocking(!) StatJob.
      KFind can search local URLs, too, so I don't see why this is necessary.
      Either way, I'd rather have a non-KDE search tool broken than the app.
      Ideally, I'd like this entire thing redone to use an async StatJob, if any.
      Fwiw the KMoreTools in the free space bar doesn't use a local URL either.
      
      BUG: 420911
      FIXED-IN: 20.04.1
      
      Differential Revision: https://phabricator.kde.org/D29442
  
  diff --git src/dolphinmainwindow.cpp src/dolphinmainwindow.cpp
  index f88bc3f44..7ad136fe7 100644
  --- src/dolphinmainwindow.cpp
  +++ src/dolphinmainwindow.cpp
  @@ -956,7 +956,7 @@ QPointer<QAction> DolphinMainWindow::preferredSearchTool()
   {
       m_searchTools.clear();
       KMoreToolsMenuFactory("dolphin/search-tools").fillMenuFromGroupingNames(
  -        &m_searchTools, { "files-find" }, QUrl::fromLocalFile(activeContainerLocalPath())
  +        &m_searchTools, { "files-find" }, m_activeViewContainer->url()
       );
       QList<QAction*> actions = m_searchTools.actions();
       if (actions.isEmpty()) {
Comment 7 Nate Graham 2020-12-11 15:38:53 UTC
MRs welcome :)
Comment 8 Martin Sandsmark 2020-12-14 12:57:33 UTC
Don't really know how to fix it easily apart from reverting the implementation commits, I don't think it is easily fixable without re-implementing the commits introducing this.
Comment 9 Martin Sandsmark 2020-12-14 13:45:13 UTC
FWIW, what I mean (and I might be wrong): the common thing with a lot of the recently introduced crashes is that people are removing the ::exec()-s, without fixing the original reasons they weren't asynchronous.

So the easiest fix is to revert back to the old synchronous behavior, and then cleaning up the "architecture" (in this case I think there is an assumption on ordering wrt. creation of widgets and actions that is broken).
Comment 10 joecitizen555 2020-12-16 11:47:59 UTC
Created attachment 134114 [details]
New crash information added by DrKonqi

dolphin (20.12.0) using Qt 5.15.2

- What I was doing when the application crashed:

The first time was after opening qBittorrent. After that, Dolphin won't start.

-- Backtrace (Reduced):
#4  0x00007fd89965c63b in KUrlNavigator::locationUrl(int) const () from /lib/x86_64-linux-gnu/libKF5KIOFileWidgets.so.5
#5  0x00007fd899a42af8 in DolphinViewContainer::setSearchModeEnabled (this=this@entry=0x559a56253110, enabled=true) at /usr/include/c++/9/bits/atomic_base.h:413
#6  0x00007fd899a44399 in DolphinViewContainer::DolphinViewContainer (this=0x559a56253110, url=..., parent=<optimized out>) at ./src/dolphinviewcontainer.cpp:188
#7  0x00007fd899a4ac45 in DolphinTabPage::createViewContainer (this=this@entry=0x559a56262240, url=...) at ./src/dolphintabpage.cpp:432
#8  0x00007fd899a4af4f in DolphinTabPage::DolphinTabPage (this=0x559a56262240, primaryUrl=..., secondaryUrl=..., parent=<optimized out>) at ./src/dolphintabpage.cpp:34
Comment 11 Ali 2020-12-18 07:41:07 UTC
Created attachment 134168 [details]
New crash information added by DrKonqi

dolphin (20.12.0) using Qt 5.15.2

Last night I updated 6 apps using the discover app:
 libpipewire-0.3-0:amd64 (0.3.17-0xneon+20.04+focal+build8, 0.3.18-0xneon+20.04+focal+build10), pipewire:amd64 (0.3.17-0xneon+20.04+focal+build8, 0.3.18-0xneon+20.04+focal+build10), distro-release-notifier:amd64 (0.0+p20.04+git20201129.0022-0, 0.0+p20.04+git20201216.0022-0), libspa-0.2-modules:amd64 (0.3.17-0xneon+20.04+focal+build8, 0.3.18-0xneon+20.04+focal+build10), libpipewire-0.3-modules:amd64 (0.3.17-0xneon+20.04+focal+build8, 0.3.18-0xneon+20.04+focal+build10), pipewire-bin:amd64 (0.3.17-0xneon+20.04+focal+build8, 0.3.18-0xneon+20.04+focal+build10)

And today I wanted to open the Dolphin app, which gave me an error every time

-- Backtrace (Reduced):
#4  0x00007f3eb58cd63b in KUrlNavigator::locationUrl(int) const () from /lib/x86_64-linux-gnu/libKF5KIOFileWidgets.so.5
#5  0x00007f3eb5cb3af8 in DolphinViewContainer::setSearchModeEnabled (this=this@entry=0x55bfcaea8a70, enabled=true) at /usr/include/c++/9/bits/atomic_base.h:413
#6  0x00007f3eb5cb5399 in DolphinViewContainer::DolphinViewContainer (this=0x55bfcaea8a70, url=..., parent=<optimized out>) at ./src/dolphinviewcontainer.cpp:188
#7  0x00007f3eb5cbbc45 in DolphinTabPage::createViewContainer (this=this@entry=0x55bfcaf55d70, url=...) at ./src/dolphintabpage.cpp:432
#8  0x00007f3eb5cbbf4f in DolphinTabPage::DolphinTabPage (this=0x55bfcaf55d70, primaryUrl=..., secondaryUrl=..., parent=<optimized out>) at ./src/dolphintabpage.cpp:34
Comment 12 Martin Sandsmark 2020-12-21 17:04:45 UTC
this issue is pretty bad, dolphin is basically impossible to use without manually finding the config file and deleting it.

can anyone experiencing this try reverting 9f268f5f76a4a4f0c91abcc213e159c8bde4869c and see if that helps?
Comment 13 Martin Sandsmark 2020-12-21 17:07:06 UTC
never mind, I think it is fixed by this: https://invent.kde.org/system/dolphin/-/commit/c95d7fae79a309ed7f2df393fa20257cb20d54a8

so test with current git master and see if it is fixed, I guess
Comment 14 Ali 2020-12-24 13:06:15 UTC
I took a screenshot and when I wanted to determine the path of the save, I tried it with dolphin and now it has been fixed!
Comment 15 Christoph Feck 2020-12-27 03:12:34 UTC
*** Bug 430831 has been marked as a duplicate of this bug. ***
Comment 16 Christoph Feck 2020-12-27 03:12:51 UTC
*** Bug 430758 has been marked as a duplicate of this bug. ***
Comment 17 Elvis Angelaccio 2020-12-28 20:41:58 UTC
Closing as duplicate, if someone can still reproduce it even with the fix applied, please reopen it.

*** This bug has been marked as a duplicate of bug 429628 ***