Bug 426884 - Geolocation Editor discards changes without warning
Summary: Geolocation Editor discards changes without warning
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-GeolocationEdit (show other bugs)
Version: 7.1.0
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-22 19:52 UTC by hmueller
Modified: 2020-09-22 20:34 UTC (History)
0 users

See Also:
Latest Commit: https://invent.kde.org/graphics/digikam/commit/2eaad17a538aa0ba2419287066190f32099d8393
Version Fixed In: 7.2.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description hmueller 2020-09-22 19:52:35 UTC 
SUMMARY
Pressing <Escape> does not act like the close button.

STEPS TO REPRODUCE
1. Open Geolocation Editor
2. Change GPS data of an image
3. Press the <Escape> key

OBSERVED RESULT
The Geolocation Editor closes without any message.

EXPECTED RESULT
Like the close button it should ask if the changes should be saved.

SOFTWARE/OS VERSIONS
macOS: 10.15.6
(available in About System)
KDE Frameworks 5.74.0
Qt 5.14.2 (built against 5.14.2)
The cocoa windowing system

ADDITIONAL INFORMATION
The bus is also seen in 7.2.0-beta1
Comment 1 Maik Qualmann 2020-09-22 20:34:26 UTC 
Git commit 2eaad17a538aa0ba2419287066190f32099d8393 by Maik Qualmann.
Committed on 22/09/2020 at 20:33.
Pushed by mqualmann into branch 'master'.

ask the user also after pressing the ESC key
FIXED-IN: 7.2.0

M  +1    -1    NEWS
M  +5    -0    core/dplugins/generic/metadata/geolocationedit/dialog/geolocationedit.cpp
M  +2    -1    core/dplugins/generic/metadata/geolocationedit/dialog/geolocationedit.h

https://invent.kde.org/graphics/digikam/commit/2eaad17a538aa0ba2419287066190f32099d8393