Bug 426823 - Can not paste into empty diff text window
Summary: Can not paste into empty diff text window
Status: RESOLVED FIXED
Alias: None
Product: kdiff3
Classification: Applications
Component: application (other bugs)
Version First Reported In: 1.8.4
Platform: Other All
: NOR major
Target Milestone: ---
Assignee: michael
URL:
Keywords:
: 426945 430708 431667 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-09-21 17:14 UTC by David
Modified: 2021-01-16 00:39 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 1.8.5
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David 2020-09-21 17:14:19 UTC
I just started to use the KDiff 3v1.8.4 (coming from the unmantained v0.9.98) and the main usage I do of the tool does not seem to work.


STEPS TO REPRODUCE
1. Open KDiff3
2. Cancel the popup window
3. Copy some lines of code
4. Focus the A in KDiff3
5. Paste the content using Ctr+V or the button in the toolbar

OBSERVED RESULT
A popup window with progress bar seems to open and then close as usual, but the content is not pasted into A. The URL says "Clipboard" but the content is empty.

EXPECTED RESULT
The content should be pasted.


SOFTWARE/OS VERSIONS
Windows: 10 64 bits

ADDITIONAL INFORMATION
Comment 1 michael 2020-10-22 03:08:51 UTC
*** Bug 426945 has been marked as a duplicate of this bug. ***
Comment 2 Gustaw Smolarczyk 2020-10-23 11:01:11 UTC
I can confirm this issue on Linux (Fedora 32, official package).

This is a regression from version 1.8.3 which worked, albeit not perfectly.

In some previous version (don't know which) the functionality worked flawlessly. After pasting data from the clipboard into one side of the comparison it would show. After pasting some other content to the other side it would perform the diff.

In version 1.8.3 (and maybe a few versions before) it worked but with a graphical glitch. Pasting data into one side would not show up anything, like in this bug. However, after pasting into the other side, both sides would show up and a diff would be performed. As such, it was just a minor annoyance.

In version 1.8.4 that is no longer the case, as explained in the first message. I can no longer see the diff even after pasting into both of the sides.
Comment 3 Gustaw Smolarczyk 2020-10-23 11:18:51 UTC
The result of git-bisect between 1.8.3 and 1.8.4:

174d2872d08878e806c4200cfc51643cee9bd177 is the first bad commit
commit 174d2872d08878e806c4200cfc51643cee9bd177
Author: Michael Reeves <reeves.87@gmail.com>
Date:   Mon Jul 13 23:53:14 2020 -0400

    Don't run SourceData::readAndPreprocess if m_fileAccess is invalid

 src/SourceData.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


Reverting this commit on top of the current master branch fixes this issue.
Comment 4 michael 2020-10-24 00:04:09 UTC
Git commit 96ddd8473ce4d069507c814231fab994b8ced372 by Michael Reeves.
Committed on 23/10/2020 at 23:24.
Pushed by mreeves into branch 'master'.

Revert "Don't run SourceData::readAndPreprocess if m_fileAccess is invalid"

This reverts commit 93293351431c5adf28a74d96314c79a56da7c940.
FIXED-IN:1.8.4

M  +1    -4    src/SourceData.cpp

https://invent.kde.org/sdk/kdiff3/commit/96ddd8473ce4d069507c814231fab994b8ced372
Comment 5 michael 2020-10-24 00:04:16 UTC
Git commit 9641e7fd456b09ec7873305b145a3c41bf011a7e by Michael Reeves.
Committed on 23/10/2020 at 23:20.
Pushed by mreeves into branch '1.8'.

Revert "Don't run SourceData::readAndPreprocess if m_fileAccess is invalid"

This reverts commit 174d2872d08878e806c4200cfc51643cee9bd177.
FIXED-IN:1.8.4

M  +1    -4    src/SourceData.cpp

https://invent.kde.org/sdk/kdiff3/commit/9641e7fd456b09ec7873305b145a3c41bf011a7e
Comment 6 michael 2020-12-28 05:04:14 UTC
*** Bug 430708 has been marked as a duplicate of this bug. ***
Comment 7 michael 2021-01-16 00:39:52 UTC
*** Bug 431667 has been marked as a duplicate of this bug. ***