Bug 426775 - Highlight changed settings not working in workspace category
Summary: Highlight changed settings not working in workspace category
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_workspace (show other bugs)
Version: 5.19.90
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-20 14:24 UTC by Nishith Khanna
Modified: 2021-06-10 13:46 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22


Attachments
Screenshot showing highlight changed setting not working in General behavior tab (175.00 KB, image/png)
2020-09-20 14:24 UTC, Nishith Khanna
Details
Screenshot showing highlight changed setting not working in Window behavior (183.39 KB, image/png)
2020-09-20 14:26 UTC, Nishith Khanna
Details
Screenshot showing highlight changed setting not working in Task switcher (187.85 KB, image/png)
2020-09-20 14:26 UTC, Nishith Khanna
Details
Here is the screenshot for file search showing incorrect info that something was changed but it wasn't. (148.46 KB, image/png)
2020-10-31 06:54 UTC, Nishith Khanna
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nishith Khanna 2020-09-20 14:24:56 UTC
Created attachment 131808 [details]
Screenshot showing highlight changed setting not working in General behavior tab

SUMMARY
Hello, So as this was a new feature for this release i.e 5.20 so decided to try it out. I found some inconsistency so thought to report it. 

In workspace behavior > General Behavior I changed click behavior it is single click by default but I changed it to double click. When clicking on highlight changed settings in menu it shows that the settings is changed but in sidebar there is orange dot visible.

In Windows management > Window behavior I changed windows activation policy. It is Click to focus by default but I changed it to focus follows mouse. This neither shows as changed in page and in sidebar.
Same behavior can be observed in task switcher setting which is Breeze by default but I changed it to thumbnail grid.
Maybe pages which have dropdown options are not supported. I am sorry if it is already known couldn't find it here so thought to report it.

Operating System: Arch Linux
KDE Plasma Version: 5.19.90
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.1
Kernel Version: 5.8.10-arch1-1
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-6200U CPU @ 2.30GHz
Memory: 11.6 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 520
Comment 1 Nishith Khanna 2020-09-20 14:26:05 UTC
Created attachment 131809 [details]
Screenshot showing highlight changed setting not working in Window behavior
Comment 2 Nishith Khanna 2020-09-20 14:26:46 UTC
Created attachment 131810 [details]
Screenshot showing highlight changed setting not working in Task switcher
Comment 3 Nishith Khanna 2020-09-20 14:27:58 UTC
As it can be seen in the screenshot that Defaults option is not greyed out so that means I am not using default settings on these particular pages. Hope this helps.
Comment 4 Nishith Khanna 2020-09-23 20:29:15 UTC
Edit in first post

In workspace behavior > General Behavior I changed click behavior it is single click by default but I changed it to double click. When clicking on highlight changed settings in menu it shows that the settings is changed but in sidebar orange dot is NOT visible.
Comment 5 Cyril Rossi 2020-09-25 15:14:21 UTC
Hi, thank you for your detailed report.

Hopefully, Task switcher and Window behavior will quickly follow. see https://invent.kde.org/plasma/kwin/-/merge_requests/177
Comment 6 Nishith Khanna 2020-10-06 06:54:19 UTC
Hey Cyril, So I was  excited to try this therefore installed neon developer edition in VM. In task switcher I see orange outline in drop down box but I don't see orange dot in sidebar and in submenu sidebar. Sorry if you are already aware about this. I don't know if I could comment on your merge request as that is not the place to report bugs therefore I am doing it here. If you need any more info I will be happy to help.
Comment 7 Nishith Khanna 2020-10-06 06:58:51 UTC
I tried Windows Behavior too it has same outline but no orange dot.

Also I saw one more thing in Search KCM I see orange dot in File Search but I haven't changed any setting in it. As its just did stock kde neon install. And If there was some changes its not being highlighted. 

Sorry if I am nitpicking a lot just trying to help as much as I can
Comment 8 Nishith Khanna 2020-10-06 07:01:27 UTC
Edit on File Search KCM. I clicked on Default button it didn't change any setting but it fixed the dot
Comment 9 Cyril Rossi 2020-10-14 12:10:41 UTC
Git commit d11daecce5514fd4855153e6362b5d495e30ba55 by Cyril Rossi.
Committed on 14/10/2020 at 12:10.
Pushed by crossi into branch 'master'.

KCM KWinTabbox use KCModuleData

Allow to display a dot in the category list when settings has changed
from default.

M  +1    -0    kcmkwin/kwintabbox/CMakeLists.txt
A  +59   -0    kcmkwin/kwintabbox/kwintabboxdata.cpp     [License: GPL(v2.0+)]
A  +50   -0    kcmkwin/kwintabbox/kwintabboxdata.h     [License: GPL(v2.0+)]
M  +42   -46   kcmkwin/kwintabbox/main.cpp
M  +2    -7    kcmkwin/kwintabbox/main.h

https://invent.kde.org/plasma/kwin/commit/d11daecce5514fd4855153e6362b5d495e30ba55
Comment 10 Cyril Rossi 2020-10-29 08:08:34 UTC
Git commit 23d221319820f27368929d30392289b33fdf535a by Cyril Rossi.
Committed on 28/10/2020 at 09:33.
Pushed by crossi into branch 'master'.

KCM WorkspaceOptions use KCModuleData to highlight the module when settings have changed

M  +10   -0    kcms/workspaceoptions/CMakeLists.txt
M  +5    -5    kcms/workspaceoptions/workspaceoptions.cpp
M  +2    -2    kcms/workspaceoptions/workspaceoptions.h

https://invent.kde.org/plasma/plasma-desktop/commit/23d221319820f27368929d30392289b33fdf535a
Comment 11 Cyril Rossi 2020-10-29 08:34:25 UTC
Task Switcher, Window Behavior and Workspace/General Behavior are now implemented.
Comment 12 Nishith Khanna 2020-10-31 06:52:57 UTC
Hey, I tested it and its working fine thanks for your hard work. I also found out that its not working in Mouse settings any changed setting there is not highlighted. 
Also it is showing a changed setting in file search even though nothing was changed. I am uploading a screenshot regarding same
Comment 13 Nishith Khanna 2020-10-31 06:54:31 UTC
Created attachment 132903 [details]
Here is the screenshot for file search showing incorrect info that something was changed but it wasn't.
Comment 14 Claudius Ellsel 2020-10-31 13:18:45 UTC
(In reply to Nishith Khanna from comment #12)
> Hey, I tested it and its working fine thanks for your hard work. I also
> found out that its not working in Mouse settings any changed setting there
> is not highlighted. 
> Also it is showing a changed setting in file search even though nothing was
> changed. I am uploading a screenshot regarding same

Thanks for reporting your findings. This bug report has been about specific missing items, which got added now in between, though.

To make it easier to distinguish between fixed and not fixed things, can you please open two new bugs for the other new findings? Ideally link them here when done, then we can close this bug again.
Comment 15 Nishith Khanna 2021-06-10 07:33:03 UTC
Most of the reported pages now support highlight changed settings in Plasma 5.22. As mentioned in the last comment I will open a bug page for missing entry. Thanks so much for this feature its a godsend. Congrats on the new release.
Comment 16 Nate Graham 2021-06-10 13:46:54 UTC
You're welcome! I'm glad you're happy!