Created attachment 131789 [details] All screenshots with comments SUMMARY This is very minor, but it's still an inconsistency in design. While most icons on System Settings are now colorful, some are still monochrome. I've also found some colorful icons in places where they should be monochromatic (like buttons). I've attached screenshots, they're all in a ZIP file (I think I got all of them). SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.19.90 KDE Frameworks Version: 5.75.0 Qt Version: 5.15.0 Kernel Version: 5.4.0-47-generic OS Type: 64-bit Processors: 4 × Intel® Core™ i5-9400F CPU @ 2.90GHz Memory: 3.8 GiB of RAM Graphics Processor: SVGA3D; build: RELEASE; LLVM;
As you can see, we're rather inconsistent here. :) Fixing this is a rather involved task, though it's not really very hard. Each system settings module has its own code and we actually don't have a firm guideline regarding when we use monochrome icons and when we use colorful icons. This is compounded by the fact that we often can't deterministically say when to use one and when to use the other. See https://phabricator.kde.org/T10413.
Let's use this bug report to track the main sidebar's icons. We're much closer to having it all fixed now and I'll see if I can finalize that soon. From what I can see, the other icons are mostly improved here as well. Some are intentional, such as the buttons with colorful icons that open KCMs; the icon in the button is the icon of the KCM that will be opened. The KRunner KCM's icons are still inconsistent, but that one will be more challenging since we don't have colorful icons for most of the ones that are only monochrome. We should get another separate bug report to track that since the issue is specific to only that KCM. Can you do that?
(In reply to Nate Graham from comment #2) > Let's use this bug report to track the main sidebar's icons. We're much > closer to having it all fixed now and I'll see if I can finalize that soon. > > From what I can see, the other icons are mostly improved here as well. Some > are intentional, such as the buttons with colorful icons that open KCMs; the > icon in the button is the icon of the KCM that will be opened. > > The KRunner KCM's icons are still inconsistent, but that one will be more > challenging since we don't have colorful icons for most of the ones that are > only monochrome. We should get another separate bug report to track that > since the issue is specific to only that KCM. Can you do that? Done: https://bugs.kde.org/show_bug.cgi?id=475184
Git commit 48626e05d70785586232fdd496e3832fd60e4ffe by Nate Graham. Committed on 04/10/2023 at 01:48. Pushed by ngraham into branch 'master'. Use colorful icon for Disks & Cameras group Icon added to breeze-icons in c4ca1f47db03a85d783e77d0ec6b6fb074b9e6af. M +1 -1 categories/settings-hardware-removable-storage.desktop https://invent.kde.org/plasma/systemsettings/-/commit/48626e05d70785586232fdd496e3832fd60e4ffe
(In reply to Nate Graham from comment #2) > The KRunner KCM's icons are still inconsistent, but that one will be more > challenging since we don't have colorful icons for most of the ones that are > only monochrome. We should get another separate bug report to track that > since the issue is specific to only that KCM. Can you do that? I didn't pay close attention to this part at all XD. Here you go: https://bugs.kde.org/show_bug.cgi?id=475199
Still need colorfulicons for: - Autostart - Advanced Power settings I'm not sure we have anything appropriate right now.
Git commit 893d38f245ca54e5e0b9039512d111d192e1c972 by Joshua Goins. Committed on 08/11/2024 at 22:04. Pushed by redstrate into branch 'master'. Add icon for keyboard shortcut preferences We currently lack such an icon, having to reuse the same over-used keyboard icon in the Shortcuts KCM. This adds a new, dedicated icon that can be used exclusively for shortcuts. A +1 -0 icons/preferences/22/preferences-desktop-keyboard-shortcut.svg A +1 -0 icons/preferences/32/preferences-desktop-keyboard-shortcut.svg https://invent.kde.org/frameworks/breeze-icons/-/commit/893d38f245ca54e5e0b9039512d111d192e1c972