Bug 426711 - Lock screen go button is much too narrow (PlasmaComponents3)
Summary: Lock screen go button is much too narrow (PlasmaComponents3)
Status: RESOLVED WORKSFORME
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: 5.74.0
Platform: Arch Linux Linux
: VHI normal
Target Milestone: ---
Assignee: Noah Davis
URL:
Keywords: regression
: 427322 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-09-19 09:07 UTC by Matej Mrenica
Modified: 2020-10-16 12:46 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Log out screen buttons (7.17 KB, image/png)
2020-09-19 09:07 UTC, Matej Mrenica
Details
Lock screen button (121.27 KB, image/jpeg)
2020-09-25 11:41 UTC, Matej Mrenica
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2020-09-19 09:07:59 UTC
Created attachment 131765 [details]
Log out screen buttons

Since Qt 5.15.1 or Kf 5.74 width of buttons matches their text width resulting in very small buttons in some cases. Screenshot shows buttons in log-out screen being smaller than before. Even better example is the session unlock screen where the confirm button is actually empty and is only ~2 millimeters wide.
Comment 1 Nate Graham 2020-09-23 18:27:01 UTC
There was a change in KF 5.74. You're seeing this in the Plasma 5.20 beta or with Plasma 5.19?
Comment 2 Matej Mrenica 2020-09-23 18:52:12 UTC
I am currently on Plasma 5.20 Beta but IIRC I had it on Plasma 5.19 too.
Comment 3 Nate Graham 2020-09-23 20:56:38 UTC
Darn. :(
Comment 4 Nate Graham 2020-09-23 21:05:26 UTC
The button width matching the text content is intentional as of 5.74. We previously had a hardcoded minimum width for text buttons which looked kind of odd, so we removed it.

The issue you;re seeing with the button in the lockscreen is a different issue and is definitely NOT intentional! :( It looks good for me in Plasma 5.20 presumably because we ported everything to PlasmaComponents3, but I guess we regressed PC2.
Comment 5 Matej Mrenica 2020-09-24 11:00:39 UTC
After a second look the ">" is not invisible, just the button is narrow, and probably should be at least a square.
Comment 6 Nate Graham 2020-09-24 20:07:06 UTC
And this problem doesn't go away if you clear the plasma SVG cache with `rm ~/.cache/plasma*; plasmashell --replace` and then lock the screen again?
Comment 7 Matej Mrenica 2020-09-25 11:41:45 UTC
Created attachment 131929 [details]
Lock screen button

This is how my lock screen button looks like. Is it the correct look? It looks too narrow to me. I also deleted my cache.
Comment 8 Noah Davis 2020-09-25 12:54:01 UTC
(In reply to Matej Mrenica from comment #7)
> Created attachment 131929 [details]
> Lock screen button
> 
> This is how my lock screen button looks like. Is it the correct look? It
> looks too narrow to me. I also deleted my cache.

That's not how it's supposed to be. Are you testing with both Plasma 5.20 and KF5.75? FWIW, I don't think PC2 was changed at all in KF5.74, so it should have worked as before.
Comment 9 Nate Graham 2020-09-25 13:25:10 UTC
Yes indeed, are you using Plasma 5.19 or the 5.20 beta?
Comment 10 Matej Mrenica 2020-09-25 13:39:17 UTC
This is Plasma 5.20 Beta and Kf 5.74 on Arch Linux.
Comment 11 Noah Davis 2020-09-25 13:42:03 UTC
Is there a date on the version of your beta? Maybe your version of the 5.20 branch isn't new enough?
Comment 12 Matej Mrenica 2020-09-25 13:48:48 UTC
According to the PKGBUILD file it was built from https://download.kde.org/unstable/plasma/5.19.90/ files available since September 17. It shouldn't be older than that, right?
Comment 13 Noah Davis 2020-09-25 13:58:09 UTC
The commit you need was added to the 5.20 branch on 2020-09-15, so I guess you should have it, but I don't know for sure. I was never able to reproduce the bug myself, so I really have no way of knowing for myself whether it was really fixed.
Comment 14 Nate Graham 2020-09-25 14:06:37 UTC
That's very odd. It looks totally fine for me using git master (which is not too far removed from the beta at this point). :/
Comment 15 Antonio Rojas 2020-09-25 14:23:33 UTC
This works fine for me on the beta and was broken in 5.19.5. Make sure to delete .cache/kscreenlocker_greet too.
Comment 16 Nate Graham 2020-09-28 15:19:59 UTC
Oh right, that other cache. That will thankfully be fixed by the fix for Bug 426674. Marking as a duplicate.

*** This bug has been marked as a duplicate of bug 426674 ***
Comment 17 Antonio Rojas 2020-10-04 13:30:11 UTC
*** Bug 427322 has been marked as a duplicate of this bug. ***
Comment 18 postix 2020-10-04 15:43:53 UTC
For what's its worth: Deleting the whole cache folder
~/.cache
and rebooting did not fix the issue for me about the tiny login button for the SDDM Breeze theme on Manjaro.
Comment 19 Matej Mrenica 2020-10-14 11:21:43 UTC
I am on Arch Linux, Plasma 5.20.0, I have used "rm -r ~/.cache/plasma*" and deleted ".cache/kscreenlocker_greet" and I still have this issue on lock screen. SDDM is fixed though.
Comment 20 Nate Graham 2020-10-14 14:54:39 UTC
Aargh, in 5.20!?!?!
Comment 21 Nate Graham 2020-10-14 14:54:51 UTC
I still cannot reproduce.

Are you using any non-standard fonts/font sizes/forced font DPI, icon themes, plasma themes, or a scale factor?
Comment 22 Matej Mrenica 2020-10-14 15:31:03 UTC
(In reply to Nate Graham from comment #21)
> I still cannot reproduce.
> 
> Are you using any non-standard fonts/font sizes/forced font DPI, icon
> themes, plasma themes, or a scale factor?

Font is the default one, there is forced font DPI of 120 set from the Screen settings (Global scaling of 125%) default icon and plasma theme. I will try with a new user just to be sure this is not a messed up config.
Comment 23 Matej Mrenica 2020-10-14 16:08:07 UTC
Oh, wow. It is working properly on a new profile.
Comment 24 Nate Graham 2020-10-14 16:55:05 UTC
If you delete the whole cache folder, and restart plasmashell (or the system I guess), does it get fixed for your existing user?
Comment 25 Matej Mrenica 2020-10-14 18:12:48 UTC
(In reply to Nate Graham from comment #24)
> If you delete the whole cache folder, and restart plasmashell (or the system
> I guess), does it get fixed for your existing user?

No, It doesn't. But I have found out why. I was using Breeze theme, but it was one loading from .local/share/ not /usr/share/. So any changes made to the Breeze theme didn't matter. I have noticed this while going through a system log investigating another issue. I am sorry for wasting your time.
Comment 26 Nate Graham 2020-10-16 12:30:43 UTC
Heh, that'd do it. The recent Plasma changes required Breeze theme changes, which would be masked by your local copy of the theme.

I wonder how you ended up with one anyway.
Comment 27 Matej Mrenica 2020-10-16 12:46:11 UTC
IIRC it was when sound and brightness OSDs were changed to the current look and I wanted to use them on Plasma 5.19 so I've built Breeze from master, placed it there and forgot.