Created attachment 131724 [details] screenshot SUMMARY My system can not hibernate because I have no swap partition/file, but "Hibernate" option is available in kickoff and kicker launchers anyway. The attached screenshot shows kickoff. EXPECTED RESULT Hde "Hibernate" option when hibernation is not supported SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.19.90 KDE Frameworks Version: 5.75.0 Qt Version: 5.15.0
I see from your screenshot that the option is slightly grayed out. Is it disabled, or can you click on it. If you do, what happens?
Nothing happens when I click on it. Same thing on Arch Linux running Plasma 5.20 beta.
Thanks. I guess by being grayed out, it seems to understand that it'snot supported, but something must have regressed recently to make it get displayed. I also notice that you have a grayed out "Save Session" item, which I notice I have too (shows you how often I open Kickoff's Leave page lol)
This was caused by https://invent.kde.org/plasma/plasma-workspace/-/commit/05414ed58d43d87d907326636faac53ae2e7bd and https://invent.kde.org/plasma/plasma-desktop/-/commit/59ac49ace991ffb3ffaf1a24013aca9aaad8b123 Technically this change was intentional, though arguably it was therefore a questionable idea. :) Making these items disabled instead of hidden doesn't really work since they still have a hover effect and are clickable, so they just look broken. Even if we fix that, it will still be odd to have non-interactive entries in those UIs. Just changing enabled: to visible: won't work since the items will still take up space in the UI. I think we need to remove them from the model, or add a proxy model that filters them out or something.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/336
Git commit fcdbbda3965d73900c415071ad882f550994fdc2 by Eike Hein. Committed on 07/10/2020 at 18:37. Pushed by hein into branch 'master'. [kicker] Don't add invalid actions to the system action model The system actions model recently changed behavior to always present all possible actions, with `AbstractEntry::isValid` driving the model role `Kicker::DisabledRole` so that views can e.g. grey out unavailable actions. This was perceived as a regression by users who are annoyed at e.g. `Hibernate` being visible when their system setup precludes it more or less permanently. This patch reverts this behavior. Note that the dynamic approach we had permanently wasn't very great anyway, as the associated favorites models would remove entries when they became invalid, and they wouldn't come back automatically when the entry were to become valid again. In effect that means when you added one of these actions to e.g. the Kicker sidebar and it became unavailable it would disappear until re-added anyways. I can imagine use cases where dynamic behavior would be useful to have - let's say disabling Shutdown/Reboot while a critical system update is being performed. But in that case we'd need to fix the favorites behavior and add some way to inform the user why the action is disabled for a good user experienced anyhow. M +32 -23 applets/kicker/plugin/systemmodel.cpp M +3 -1 applets/kicker/plugin/systemmodel.h https://invent.kde.org/plasma/plasma-workspace/commit/fcdbbda3965d73900c415071ad882f550994fdc2
Git commit d80f738fc7ebb8c1324e0c75e433b319a8e13aef by Nate Graham, on behalf of Eike Hein. Committed on 07/10/2020 at 18:55. Pushed by ngraham into branch 'Plasma/5.20'. [kicker] Don't add invalid actions to the system action model The system actions model recently changed behavior to always present all possible actions, with `AbstractEntry::isValid` driving the model role `Kicker::DisabledRole` so that views can e.g. grey out unavailable actions. This was perceived as a regression by users who are annoyed at e.g. `Hibernate` being visible when their system setup precludes it more or less permanently. This patch reverts this behavior. Note that the dynamic approach we had permanently wasn't very great anyway, as the associated favorites models would remove entries when they became invalid, and they wouldn't come back automatically when the entry were to become valid again. In effect that means when you added one of these actions to e.g. the Kicker sidebar and it became unavailable it would disappear until re-added anyways. I can imagine use cases where dynamic behavior would be useful to have - let's say disabling Shutdown/Reboot while a critical system update is being performed. But in that case we'd need to fix the favorites behavior and add some way to inform the user why the action is disabled for a good user experienced anyhow. (cherry picked from commit fcdbbda3965d73900c415071ad882f550994fdc2) M +32 -23 applets/kicker/plugin/systemmodel.cpp M +3 -1 applets/kicker/plugin/systemmodel.h https://invent.kde.org/plasma/plasma-workspace/commit/d80f738fc7ebb8c1324e0c75e433b319a8e13aef