SUMMARY If you try to use Format -> Underline, it works just fine, but if you try to use Format -> Strike-through, it changes in the rich text editor, but it isn't rendered on the canvas. STEPS TO REPRODUCE 1. Create text shape, open the editor. 2. Select whole text. 3. Use Format -> Strikethrough. 4. Select all, Save. OBSERVED RESULT Text in the rich text editor has the strike-through line, but text on canvas doesn't have it. EXPECTED RESULT Both text in the rich text editor and on the canvas have the line. SOFTWARE/OS VERSIONS Krita 4.3.0 Linux Mint 19.3
This seems to be a problem in passing data from the rich text editor to the .svg content of the text object. If you use the SVG Source editor and apply text-decoration="line-through" then it does show the strikethrough on the canvas. (Why on earth do they use "line-through" when it's called 'strikethrough'?)
Git commit b35c7822378b54d049bf84a4417ac2dae3ac2af0 by Agata Cacko. Committed on 21/09/2020 at 11:26. Pushed by tymond into branch 'master'. Fix strike-through in converstion rich text -> svg Before this commit, strike-through would work if the user adds `line-decoration=line-through` in svg, but it doesn't work if the user uses the strike-through option in "Format" submenu, because rich text -> svg conversion didn't keep it. This commit fixes it and if the user does it, the strike-through appears both in canvas and in the rendered svg. Note: the bug regarding weird painting of the strike-through on the canvas (parts inside black letters are white) is still present both before and after the bug fix. M +47 -22 libs/flake/text/KoSvgTextShapeMarkupConverter.cpp https://invent.kde.org/graphics/krita/commit/b35c7822378b54d049bf84a4417ac2dae3ac2af0
Git commit 7a052f9c3e75871f1116d19ea9996075951904df by Agata Cacko. Committed on 16/10/2020 at 14:21. Pushed by tymond into branch 'krita/4.3'. Fix strike-through in converstion rich text -> svg Before this commit, strike-through would work if the user adds `line-decoration=line-through` in svg, but it doesn't work if the user uses the strike-through option in "Format" submenu, because rich text -> svg conversion didn't keep it. This commit fixes it and if the user does it, the strike-through appears both in canvas and in the rendered svg. Note: the bug regarding weird painting of the strike-through on the canvas (parts inside black letters are white) is still present both before and after the bug fix. M +47 -22 libs/flake/text/KoSvgTextShapeMarkupConverter.cpp https://invent.kde.org/graphics/krita/commit/7a052f9c3e75871f1116d19ea9996075951904df