Bug 426537 - widgets/plasmoidheading.svgz not visible when using Breeze Dark plasma style
Summary: widgets/plasmoidheading.svgz not visible when using Breeze Dark plasma style
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: 5.74.0
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-14 19:42 UTC by popov895
Modified: 2020-10-01 23:33 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.75
Sentry Crash Report:


Attachments
Before (95.06 KB, image/png)
2020-09-14 19:49 UTC, popov895
Details
After (92.80 KB, image/png)
2020-09-14 19:49 UTC, popov895
Details

Note You need to log in before you can comment on or make changes to this bug.
Description popov895 2020-09-14 19:42:32 UTC
SUMMARY

Currently, when switching the global theme, the popup applets don't display the headers correctly. Most likely plasmoidheading.svgz is in the wrong location: now it is in /usr/share/plasma/desktoptheme/breeze-dark, but should be in /usr/share/plasma/desktoptheme/breeze-dark/widgets (same for /usr/share/plasma/desktoptheme/breeze-light). Moving plasmoidheading.svgz to a "widgets" folder fix this issue. It looks like commit d874449ad333c900b2e6d5f129bbe130ce479909 broke that. Sorry if I'm wrong.

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: KDE neon 5.19 User Edition
KDE Plasma Version: 5.19.5
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.0
Comment 1 popov895 2020-09-14 19:49:38 UTC
Created attachment 131648 [details]
Before

Before moving plasmoidheading.svgz
Comment 2 popov895 2020-09-14 19:49:59 UTC
Created attachment 131649 [details]
After

After moving plasmoidheading.svgz
Comment 3 Nate Graham 2020-09-15 02:12:57 UTC
Hmm, looks okay on my system with Frameworks 5.74:

$ ls -la /usr/share/plasma/desktoptheme/breeze-*/widgets/plasmoidheading.svgz
lrwxrwxrwx 1 root root 42 Aug 25 17:00 /usr/share/plasma/desktoptheme/breeze-dark/widgets/plasmoidheading.svgz -> ../../default/widgets/plasmoidheading.svgz
lrwxrwxrwx 1 root root 42 Aug 25 17:00 /usr/share/plasma/desktoptheme/breeze-light/widgets/plasmoidheading.svgz -> ../../default/widgets/plasmoidheading.svgz

Is this not what it looks like for you?
Comment 4 popov895 2020-09-15 08:15:19 UTC
$ ls -la /usr/share/plasma/desktoptheme/breeze-*/widgets/plasmoidheading.svgz
ls: cannot access '/usr/share/plasma/desktoptheme/breeze-*/widgets/plasmoidheading.svgz': No such file or directory
$ ls -la /usr/share/plasma/desktoptheme/breeze-*/plasmoidheading.svgz
-rw-r--r-- 1 root root 874 Sep 11 13:16 /usr/share/plasma/desktoptheme/breeze-dark/plasmoidheading.svgz
-rw-r--r-- 1 root root 874 Sep 11 13:16 /usr/share/plasma/desktoptheme/breeze-light/plasmoidheading.svgz

Same on live image.
Comment 6 Nate Graham 2020-09-15 16:30:29 UTC
Yes, that's what I would expect. However Eugene is saying he thinks this was *broken* by that commit.

Eugene, can you clarify?
Comment 7 popov895 2020-09-15 16:55:12 UTC
I'm not sure. As I can see only commit d874449ad333c900b2e6d5f129bbe130ce479909 affects plasmoidheading.svgz. At the same time, Nate said that he didn't notice this problem on his system. So maybe this issue is specific to Neon only?
Comment 8 popov895 2020-09-21 18:57:44 UTC
Same on the latest openSUSE Krypton. So the issue isn't Neon specific only.
Comment 9 Nate Graham 2020-09-22 20:16:13 UTC
We are getting reports of this from people using multiple distros; re-opening.

Still, it looks sane in the code, and I don't see the issue in my built-from-source issue. Either it was fixed after 5.74 was released, or something very odd is going on.
Comment 10 Hannah von Reth 2020-09-23 06:37:44 UTC
Could the distro packages have problems replacing the old unusual sym links with actual files?
Comment 11 Nate Graham 2020-09-23 14:18:40 UTC
Hmm, that seems like it could be a solid lead.
Comment 12 Fabian Vogt 2020-09-24 16:02:47 UTC
(In reply to popov895 from comment #8)
> Same on the latest openSUSE Krypton. So the issue isn't Neon specific only.

You might be running into https://github.com/rpm-software-management/rpm/issues/1278.
The commit replaced symlinks with copies, so on upgrades from the state with symlinks to the state with copies (which get converted into hardlinks), the added hardlinks would get created with no content. To confirm:

ll /usr/share/plasma/desktoptheme/breeze-*/widgets/plasmoidheading.svgz (should show a size of 0 and a mode of w--)
zypper install --force plasma-framework (should fix the missing files)
Comment 13 Harald Sitter 2020-09-30 10:37:31 UTC
https://invent.kde.org/frameworks/plasma-framework/-/commit/d874449ad333c900b2e6d5f129bbe130ce479909 installs to the wrong directory though?

Originally it installed the **directory** 'widgets' to ${PLASMA_DATA_INSTALL_DIR}/desktoptheme/breeze-dark which would lead to the actual output being

> ${PLASMA_DATA_INSTALL_DIR}/desktoptheme/breeze-dark/widgets/foo.svgz

The diff changed that to install the **file** svgz to the directory ${PLASMA_DATA_INSTALL_DIR}/desktoptheme/breeze-dark (the location hasn't changed to a subdir!) effectively this is

> ${PLASMA_DATA_INSTALL_DIR}/desktoptheme/breeze-dark/foo.svgz

Here the relevant lines from the neon unstable build log

> -- Installing: /workspace/build/debian/tmp/usr/share/plasma/desktoptheme/breeze-dark/plasmoidheading.svgz
> -- Installing: /workspace/build/debian/tmp/usr/share/plasma/desktoptheme/breeze-light/plasmoidheading.svgz


That is exactly what was shown in comment #4 though, so is that meant to be like that? :O (an strace of plasmashell says it shouldn't be, but maybe I'm missing something)
Comment 14 Nate Graham 2020-10-01 23:25:08 UTC
Good catch. It's not supposed to be like that, no. I'll fix it.
Comment 15 Nate Graham 2020-10-01 23:33:38 UTC
Git commit 7f9fe64f9bfa12462c0fae3c941ad1c2e73dcb20 by Nate Graham.
Committed on 01/10/2020 at 23:28.
Pushed by ngraham into branch 'master'.

Fix plasmoidheading.svgz being installed to the wrong place

This was causing it to not show up for people using the Breeze Dark
Plasma theme (but not the default Plasma theme with a dark color scheme)
FIXED-IN: 5.75
CCMAIL: vonreth@kde.org

M  +1    -1    src/desktoptheme/breeze-dark/CMakeLists.txt
M  +1    -1    src/desktoptheme/breeze-light/CMakeLists.txt

https://invent.kde.org/frameworks/plasma-framework/commit/7f9fe64f9bfa12462c0fae3c941ad1c2e73dcb20