Bug 426529 - Option to ensure the display of all wallpapers in each configured folder before moving onto the wallpapers in the next folder
Summary: Option to ensure the display of all wallpapers in each configured folder befo...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Image Wallpaper (show other bugs)
Version: 5.19.5
Platform: Other Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-14 16:26 UTC by Dante Igashu
Modified: 2021-08-09 22:04 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dante Igashu 2020-09-14 16:26:27 UTC
SUMMARY
Hello!
I would like to kindly make a request to add an additional option to arrange the order of the wallpapers.
I always use a few different folders for my wallpapers expecting to be able to see them arranged in the order I intent (by folder and in alphabetical order) but the option is not available in the plasma default wallpaper "app" nor in any other that is available in the "new plugins" section. I tried "Vallpaper", it actually reads the wallpapers "by folder" but it gets the images randomly and apparently it doesn't "remember" in which image it was after turning the PC off, so every time you start a new session, it just starts over, in a few words, it doesn't do what I would like it to do.
Also, the only wallpaper "app" that I like until now is the one that comes by default in Plasma but there's just that feature "missing", so I would like to please ask you, if it is possible and it doesn't cause any inconvenient trouble for you, if you could please add an "Order" option called something like "By Folder" in which it reads the folders and images in alphabetical order and, like it does now, it remembers where it stopped, so my desktop shows the wallpaper where I "left" before turning off the PC.

STEPS TO REPRODUCE
1. Set Wallpapers order to "A - Z"

OBSERVED RESULT
It "plays" the wallpapers in "alphabetical order" as if all of them were in the exact same folder but not actually in alphabetical order, or numerical order in fact, it seems to have a limit of numerical names below 1000 and it arranges files with a number >= 1000 apparently only considering the hundreds portion of the name.

EXPECTED RESULT
To be able to read from folders in alphabetical order and "play" the wallpapers in alphabetical order too. Remember where it "stopped" after starting a new session.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 5.8.8-arch1-1
(available in About System)
KDE Plasma Version: 5.19.5
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.1

ADDITIONAL INFORMATION

THANKS IN ADVANCE! :D

HAVE A GREAT DAY
Comment 1 Nate Graham 2020-09-15 02:59:50 UTC
There appears to be some demand for something like this, as someone submitted a merge request that *I think* would resolve it: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/120

Unfortunately that MR seems to have gotten stalled amidst disputes about the UI. The UI proposed there is much too complicated.

It's still not 100% clear to me what the problem is. This sentence is confusing to me:

> It "plays" the wallpapers in "alphabetical order" as if all of them were in the
> exact same folder but not actually in alphabetical order, or numerical order in
> fact
Are the wallpapers sorted alphabetically or not? I don't understand.
Comment 2 Dante Igashu 2020-09-15 16:59:03 UTC
Hello Nate Graham!
Okay, no problem, I will try to explain it in a way that makes it clear by being more explicit:

As I mentioned I have my wallpapers in different folders, in order to arrange them in categories, like "Anime", "City"..."Nature", etc, because I wanted the wallpapers to be "played" in the order the folders are arranged, in this case in alphabetical order, but I also wanted the images inside each folder to be read in alphabetical order, so the first folder would get all its images read first, then the second would get all its images read and so on.
In this case, with the "Slideshow" plug-in included in Plasma, it kind of does the job, the problem is that it doesn't seem to take in consideration the "categories", in this case the folders, it just takes all the images from all the folders, puts them together as if there were no folders (categories) and it sorts them all together as if there was just one folder.
Now, the arrangement of the images seems to have limitations too, so to explain this point I have to mention that some of my folders have already reached more than 1000 images and I decided to name them in a numerical way, 001,002, etc, and as I recently just reached 1000 in one folder, once that happened I noticed that the images >= 1000 get sorted in a way I wasn't expecting, instead of following the sequence from 999, it jumps back to 0 it seems, as 1000 is read as 100, apparently considering just the first three digits from left to right so 1000 is read as 100 and zero or 100-0 and because of that, it places the 1001, 1002, etc in the same spot where the actually named 100 images but seems to do something like "oh! there's another number after 100, it is a zero", and 1000 is next to 100 and then it says "this is 100-1, 100-2, etc", then it reaches the real 101 images and for the 1010's images it says "oh! this one has a 101 too" when it is actually a 1010, so it places them together with the 101 images and apparently it considers them to be something like "oh! this is image 101-0, and this 101-1, and this 101-2..." instead of 1010, 1011, 1012....
So, as you may be imagining now, it is "chaos" in there and all my sorting just gets wasted by converting it in to a clutter (LOL).
I checked the Merge Request you mentioned, and it seems it would actually solve the problem for me, but the way it is displayed in the menu, as it is mentioned there, seems to be kind of unnecessary for most users and I am able to see why, it seems to "violate" the KISS approach, yet, it seems to be really useful for people like me but it doesn't seem that they would actually add all that stuff in the official release. Wish that guy had made a plug-in that we could download somewhere. In my case I may just use the option that seems to be the "By folder and file name".
I guess I may try by renaming files and see if I can obtain the result I want. The options mentioned in the merge request seem to be actually useful for some of us though.

THANKS Nate Graham! and I hope there's is a way that merge request, or at least part of it, can be added.

HAVE A GREAT DAY! :D
Comment 3 Nate Graham 2020-09-15 18:23:59 UTC
Thanks, that's helpful. So to paraphrase:

- Right now we aggregate all configured images into a single giant set of wallpapers irrespective of their location on disk, and then we sort that big combined set alphabetically/by date/etc.

- You want each wallpaper's on-disk location to be taken into account, such that there are actually n sets of wallpapers, not just one. Each set of wallpapers corresponds to all of the images in a specific folder on disk. The system then goes through these sets one by one, alphabetically.

This seems reasonable. What's needed is a way to tell the system to not combine all the images in all the configured folders into one giant set when sorting. Maybe when multiple folders of images have been added in the sidebar, we could have a checkbox called something like "Display all wallpapers in a folder before moving onto the next folder". And when the checkbox is checked, a sort order chooser for the folders themselves would be visible.
Comment 4 Nate Graham 2020-09-15 18:24:06 UTC
What do you think about that?
Comment 5 Dante Igashu 2020-09-15 21:42:39 UTC
Yes, that sounds like what I want to happen to the way my wallpapers are shown :D
"Display all wallpapers in a folder before moving onto the next folder" + the alphabetical part for the files and the the part that allows the system to "count" beyond 999 if possible :b.

<<...we could have a checkbox called something like "Display all wallpapers in a folder before moving onto the next folder". And when the checkbox is checked, a sort order chooser for the folders themselves would be visible.>>

Wow that sound great! [except for the name, "Display all wallpapers in a folder before moving onto the next folder", (LOL ;b)]. That way the UI wouldn't look overloaded with so many options, unless you want it too and it would give users the options to give order to their massive collection of wallpapers.

I think that would work fine for those who don't care about messing with that many options, that just want to see the wallpapers no matter the order they are in and would give options to those who like to "have more control".

THANKS! Nate Graham.
Comment 6 Nate Graham 2021-08-09 22:04:06 UTC
Git commit 690617382670cc60fe2da0f206992a3941c13580 by Nate Graham, on behalf of Mihai Sorin Dobrescu.
Committed on 09/08/2021 at 22:04.
Pushed by ngraham into branch 'master'.

[wallpapers/image] Allow grouping by folder in slideshow

This allows people to specify that all of the wallpapers in each folder
need to be displayed before moving onto wallpapers in the next folder.
FIXED-IN: 5.23

M  +24   -4    wallpapers/image/image.cpp
M  +8    -2    wallpapers/image/image.h
M  +77   -53   wallpapers/image/imagepackage/contents/ui/config.qml
M  +1    -0    wallpapers/image/imagepackage/contents/ui/main.qml
M  +64   -11   wallpapers/image/slidefiltermodel.cpp
M  +7    -2    wallpapers/image/slidefiltermodel.h
M  +5    -1    wallpapers/image/slideshowpackage/contents/config/main.xml

https://invent.kde.org/plasma/plasma-workspace/commit/690617382670cc60fe2da0f206992a3941c13580