Bug 426519 - Invalid state
Summary: Invalid state
Status: CONFIRMED
Alias: None
Product: kpat
Classification: Applications
Component: general (show other bugs)
Version: 20.04
Platform: Gentoo Packages Linux
: HI major
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
: 420547 448956 460855 470274 480189 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-09-14 13:30 UTC by Jimi
Modified: 2024-03-28 14:12 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
KPatience Save File (42.67 KB, application/xml)
2020-09-14 13:30 UTC, Jimi
Details
KPatience Screenshot (67.82 KB, image/jpeg)
2020-09-14 13:33 UTC, Jimi
Details
KPatience Screencapture (3.57 MB, image/gif)
2020-09-17 00:53 UTC, Jimi
Details
KPatience Screencapture-20200921 (59.97 KB, image/jpeg)
2020-09-21 16:41 UTC, Jimi
Details
KPatience Save File-20200921 (42.64 KB, application/xml)
2020-09-21 16:42 UTC, Jimi
Details
UnwinnableGameSinceTheNineWentDownWithTheAces.png (85.49 KB, image/png)
2024-01-23 23:08 UTC, Little Girl
Details
Entire column disappeared instead of just spades (804.10 KB, image/png)
2024-03-28 14:12 UTC, Jan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jimi 2020-09-14 13:30:46 UTC
Created attachment 131639 [details]
KPatience Save File

After completing the penultimate set of cards, the pile stayed instead of being filed away until the last stack was dealt. After a '9' card was placed on the pile, it was then moved off. This additional card was needed to solve the game, and was stuck with the pile that moved off. It was odd that there were was a spare king on the table.
Comment 1 Jimi 2020-09-14 13:33:19 UTC
Created attachment 131640 [details]
KPatience Screenshot

Screenshot of invalid state with a spare king and a missing '9' card needed to solve the game.
Comment 2 Albert Astals Cid 2020-09-14 20:44:46 UTC
just to confirm, if you load, press undo until the 9 is not on the bottom anymore and click on the pile, it gets put in the wrong place again?
Comment 3 Jimi 2020-09-15 11:20:03 UTC
I did not use the Undo function. However, moving the pile to a different slot would "wake" cause it to be moved off.
Comment 4 Albert Astals Cid 2020-09-15 18:35:55 UTC
I am not asking if you did use undo.

I'm asking if you do it *now*.

load the file, press undo until the 9 is not on the bottom anymore and click on the pile, it gets put in the wrong place again?
Comment 5 Jimi 2020-09-15 22:44:41 UTC
Clicking on the pile (just before the '9' is thrown on) has no effect. Taking part of the pile off and then placing it back on causes the whole pile to be moved off.
Comment 6 Albert Astals Cid 2020-09-15 22:55:38 UTC
Can you reproduce the same error using kpat from flathub? https://flathub.org/apps/details/org.kde.kpat
Comment 7 Jimi 2020-09-16 15:10:13 UTC
The flathub instance does not provide a dialog box to load the save file. (Neither 'Ctrl+O' nor the 'Game -> Load' option works.)
Comment 8 Albert Astals Cid 2020-09-16 20:03:04 UTC
please run 

flatpak update

You'll get an update of kpat where opening files should work
Comment 9 Jimi 2020-09-16 22:22:48 UTC
Done. The error was reproduced using the updated package. Of course, when I go to the step prior and set up the pile correctly, it is moved off before dealing the last deck (which avoids the issue with the '9' card.)

This occurs in both versions of the KPatience package.
Comment 10 Albert Astals Cid 2020-09-16 22:27:03 UTC
Can you please record a screencapture and upload somewhere to see what you do?

Because with the new kpatience version i can't reproduce the error so probably i'm not understanding what you do.
Comment 11 Jimi 2020-09-17 00:53:08 UTC
Created attachment 131711 [details]
KPatience Screencapture

Requested screencapture attached.
Comment 12 Albert Astals Cid 2020-09-19 00:21:11 UTC
Can you explain what is wrong in that video? It all looks reasonable to me and the 9 doesn't end up in the bottom left anymore, no?
Comment 13 Jimi 2020-09-19 03:35:42 UTC
There was an invalid state during normal play where the completed stack was not automatically moved off. In this particular scenario, the stack could be moved around -- or broken up and rearranged -- to trigger the proper transition. It so happened in this particular scenario that there was room to complete that action. If there were no open slots, that could have prevented any further action.
Comment 14 Albert Astals Cid 2020-09-19 16:04:14 UTC
I'm sorry but i really don't understand what you're saying, i'll leave this in reported in case someone else does.
Comment 15 Jimi 2020-09-21 16:41:06 UTC
Created attachment 131838 [details]
KPatience Screencapture-20200921

Screenshot of another invalid date (captured 20200921.)
Comment 16 Jimi 2020-09-21 16:42:12 UTC
Created attachment 131839 [details]
KPatience Save File-20200921

Save file of another invalid date (20200921).
Comment 17 Stephan Kulow 2023-03-08 06:26:33 UTC
Actually during development I had several cases where the application crashed (in debug validations/asserts). Something is fishy with undo/redo
Comment 18 Stephan Kulow 2023-03-09 05:05:03 UTC
*** Bug 420547 has been marked as a duplicate of this bug. ***
Comment 19 Stephan Kulow 2023-03-09 05:28:52 UTC
*** Bug 460855 has been marked as a duplicate of this bug. ***
Comment 20 Stephan Kulow 2023-03-09 05:42:07 UTC
*** Bug 448956 has been marked as a duplicate of this bug. ***
Comment 21 Stephan Kulow 2023-06-10 06:46:41 UTC
*** Bug 470274 has been marked as a duplicate of this bug. ***
Comment 22 Little Girl 2024-01-23 23:05:15 UTC
I've experienced a similar situation, also with a 9 of spades being moved down into the completed stacks, in Kubuntu 22.04 LTS while playing Spider. In the message on the bottom left of the screen, the game is unsure whether the game can still be won or not, but my only move is to try to put the stack with an 8 of spades at the top of it onto the stack that has a 10 of spades at the bottom of it, which is an illegal move. It's an interesting bug.

SOFTWARE/OS VERSIONS
KPatience version: 21.12.3
Operating system: Kubuntu 22.04
KDE Plasma version: 5.24.7
KDE Frameworks version: 5.92.0
Qt version: 5.15.3
Kernel version: 5.15.0-91-generic (64-bit)
Graphics Platform: X11
Comment 23 Little Girl 2024-01-23 23:08:28 UTC
Created attachment 165172 [details]
UnwinnableGameSinceTheNineWentDownWithTheAces.png
Comment 24 Little Girl 2024-01-23 23:13:27 UTC
*** Bug 480189 has been marked as a duplicate of this bug. ***
Comment 25 Jan 2024-03-28 14:12:37 UTC
Created attachment 167890 [details]
Entire column disappeared instead of just spades