Bug 426450 - [Wayland] (Optionally) disable new layout OSD
Summary: [Wayland] (Optionally) disable new layout OSD
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: input (show other bugs)
Version: 5.18.5
Platform: Fedora RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on: 390079 418699
Blocks:
  Show dependency treegraph
 
Reported: 2020-09-12 17:17 UTC by Alexander Potashev
Modified: 2022-10-03 11:08 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
butirsky: Wayland+
butirsky: Decision-Required+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2020-09-12 17:17:50 UTC
SUMMARY
[Wayland] (Optionally) disable new layout OSD.

When switching keyboard layout in a Plasma Wayland session, the OSD with the new layout is always display. Please either remove this OSD or make it configurable with the option to disable the OSD.

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Alexander Potashev 2020-09-12 17:22:54 UTC
might be a duplicate of bug #418699
Comment 2 soredake 2020-09-15 13:16:45 UTC
https://bugs.kde.org/show_bug.cgi?id=376460
https://invent.kde.org/plasma/kwin/-/merge_requests/217#note_104982
Osd about volume change is useful, osd about changed playback device is useful, seeing osd about layout switching (which i do A LOT) is very distracting, annoying and useless as i use keyboard layout applet in tray. Please, add option to disable only this OSD notification.
Comment 3 Andrey 2020-09-22 11:52:02 UTC
There is two cases when OSD is shown:
- user actually changed layout (by a shortcut or so)
- start typing in window with new layout (when not on Global layout Policy)

What kind of OSD it's proposed to suppress here?
Comment 4 soredake 2020-09-22 12:31:17 UTC
(In reply to Andrey from comment #3)
> There is two cases when OSD is shown:
> - user actually changed layout (by a shortcut or so)
> - start typing in window with new layout (when not on Global layout Policy)
> 
> What kind of OSD it's proposed to suppress here?

I, for example, don't want to see any of this two.
Comment 5 Alexander Potashev 2020-09-22 21:58:02 UTC
(In reply to ruruoli from comment #4)
> I, for example, don't want to see any of this two.

+1
Comment 6 Andrey 2020-09-22 23:05:10 UTC
(In reply to ruruoli from comment #2)
> seeing osd about layout switching (which i do A LOT) is very
> distracting, annoying and useless as i use keyboard layout applet in tray.
> Please, add option to disable only this OSD notification.

What applet are you using? AFAIK it's not ready yet for Wayland.
Comment 7 soredake 2020-09-23 06:51:20 UTC
(In reply to Andrey from comment #6)
> (In reply to ruruoli from comment #2)
> > seeing osd about layout switching (which i do A LOT) is very
> > distracting, annoying and useless as i use keyboard layout applet in tray.
> > Please, add option to disable only this OSD notification.
> 
> What applet are you using? AFAIK it's not ready yet for Wayland.

I use standard applet on x11.
Comment 8 Andrey 2020-09-23 11:49:41 UTC
On X11 you shouldn't have such problem because it has no layout OSD when switching shortcut configured as "Primary"(IIRC) in Settings.
Comment 9 soredake 2020-09-23 12:28:21 UTC
(In reply to Andrey from comment #8)
> On X11 you shouldn't have such problem because it has no layout OSD when
> switching shortcut configured as "Primary"(IIRC) in Settings.

I want to switch to Wayland, and this keyboard layout OSD is the only thing that keeps me from doing this.
Comment 10 soredake 2020-09-23 12:29:20 UTC
(In reply to Andrey from comment #6)
> (In reply to ruruoli from comment #2)
> > seeing osd about layout switching (which i do A LOT) is very
> > distracting, annoying and useless as i use keyboard layout applet in tray.
> > Please, add option to disable only this OSD notification.
> 
> What applet are you using? AFAIK it's not ready yet for Wayland.

https://invent.kde.org/plasma/kwin/commit/cba895e7239e5919aa15adfb4e71ad72fb6c0806
Comment 11 Andrey 2020-09-23 13:10:11 UTC
(In reply to ruruoli from comment #10)
> (In reply to Andrey from comment #6)
> > What applet are you using? AFAIK it's not ready yet for Wayland.
> 
> https://invent.kde.org/plasma/kwin/commit/
> cba895e7239e5919aa15adfb4e71ad72fb6c0806

It's not the applet corresponding to X11's one :)

The fix just make it show layout correctly when you hover that "applet", but it doesn't show the layout permanently as X11 does.
The new applet is in developing now, but until it ready we really don't have other way to know current layout than OSD..
Comment 12 Patrick Silva 2020-11-01 17:25:23 UTC
That OSD can be disabled unchecking "Display visual feedback for status changes" in System Settings > Workspace Behavior > General Behavior.
Comment 13 soredake 2020-11-23 10:00:30 UTC
(In reply to Patrick Silva from comment #12)
> That OSD can be disabled unchecking "Display visual feedback for status
> changes" in System Settings > Workspace Behavior > General Behavior.

I want to disable only layout change OSD, not all, OSD related to volume change or changed audio output is useful.
Comment 14 soredake 2020-12-07 15:37:17 UTC
Layout indicator was fixed, any progress on disabling/removing these annoying osd?
Comment 15 Andrey 2020-12-07 21:35:51 UTC
It will be disabled permanently on Alt+Tab switching, if the windows have different keyboard layout.
I hoped it will solve major part of the problem, if you don't think so - please reply, preferably with argumentation.
We will have to think how to do that then, currently I have no ready solution.
Maybe it should be regulated on theme basis, I'm not sure this logic should be implemented in KWin itself.
Suggestions are welcome.
Comment 16 soredake 2020-12-08 11:56:03 UTC
(In reply to Andrey from comment #15)
> It will be disabled permanently on Alt+Tab switching, if the windows have
> different keyboard layout.
> I hoped it will solve major part of the problem, if you don't think so -
> please reply, preferably with argumentation.
> We will have to think how to do that then, currently I have no ready
> solution.
> Maybe it should be regulated on theme basis, I'm not sure this logic should
> be implemented in KWin itself.
> Suggestions are welcome.

>I hoped it will solve major part of the problem,
Not, it not. I switch language layouts A LOT, seeing an OSD for every change is very bad decision, i already see that layout is changed in applet in tray, why do i need an OSD for action that i perform tens of time per a minute? In windows, for example, i do not see an OSD for layout change when i press ctrl+shift, in x11 plasma there is no OSD too, thankfully, and i happy with it. If you want this OSD very bad, then please, make all OSD configurable (allowing me to disable this one leaving others intant), otherwise i will be forced to disable OSD (i don't want this),
Comment 17 Bug Janitor Service 2020-12-23 22:46:57 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/279
Comment 18 Andrey 2021-02-01 13:47:08 UTC
Git commit 61be205a0dd98bc6a56c34697490a86ad5118231 by Andrey Butirsky.
Committed on 01/02/2021 at 13:39.
Pushed by butirsky into branch 'master'.

feat: add option to disable OSD on keyboard layout change

Counterpart commit with the same title is in P-D
Related: bug 376460

M  +5    -3    shell/osd.cpp
M  +2    -1    shell/osd.h

https://invent.kde.org/plasma/plasma-workspace/commit/61be205a0dd98bc6a56c34697490a86ad5118231
Comment 19 Andrey 2021-02-01 13:57:56 UTC
Git commit 86381afb241ac0d3d70947819e8971a14300518a by Andrey Butirsky.
Committed on 01/02/2021 at 13:55.
Pushed by butirsky into branch 'master'.

feat: add option to disable OSD on keyboard layout change

Existing ability to disable OSD globally seems is not enough.
People see OSD on keyboard layout change especially annoying.
So provide the fine grained option.

Counterpart commit with the same title is in P-W
Related: bug 376460

M  +2    -0    kcms/keyboard/CMakeLists.txt
M  +8    -1    kcms/keyboard/kcm_keyboard.cpp
M  +2    -0    kcms/keyboard/kcm_keyboard.h
M  +7    -4    kcms/keyboard/kcm_keyboard.ui
M  +14   -2    kcms/keyboard/kcm_keyboard_widget.cpp
M  +4    -1    kcms/keyboard/kcm_keyboard_widget.h
A  +6    -0    kcms/keyboard/workspace_options.kcfgc
M  +6    -0    kcms/workspaceoptions/workspaceoptions_plasmasettings.kcfg

https://invent.kde.org/plasma/plasma-desktop/commit/86381afb241ac0d3d70947819e8971a14300518a