Bug 426417 - Files names are not vertically centered inside rows of Tracks view
Summary: Files names are not vertically centered inside rows of Tracks view
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
Depends on:
Reported: 2020-09-11 16:21 UTC by Patrick Silva
Modified: 2020-09-15 17:37 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.08.2

screenshot (195.24 KB, image/png)
2020-09-11 16:21 UTC, Patrick Silva
Working view from testing branch (128.27 KB, image/png)
2020-09-12 15:45 UTC, Maksym Hazevych

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-09-11 16:21:22 UTC
Created attachment 131566 [details]

Observe the files names in the attached screenshot.
They are not vertically centered inside their rows.

files names should be vertically centered inside the rows, like the icons.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.0
Comment 1 Maksym Hazevych 2020-09-12 15:45:50 UTC
Created attachment 131580 [details]
Working view from testing branch

I see this as different issue. It failing to show any metadata on that view - you can see length of audio not being present, too. Empty space is for Artist - Album, btw. I think it's not problem with reading, but displaying it on Tracks view, because Playlist view seems to work just fine.

Attaching screenshot of working view from Neon testing branch.
Comment 2 Patrick Silva 2020-09-12 16:09:31 UTC
possibly related to bug 425392
Comment 3 Maksym Hazevych 2020-09-12 16:48:23 UTC
We should now define - is this ticket about vertical alignment of file name if metadata isn't present, or about failing to show metadata? If first one - please, rename the issue.
Comment 4 Nate Graham 2020-09-14 23:26:40 UTC
The bug is that for tracks with just a name and no artist defined, the label should be vertically centered. The label for the artist is still taking up space even though it's empty. I'll fix it.
Comment 5 Bug Janitor Service 2020-09-14 23:38:30 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/168
Comment 6 Nate Graham 2020-09-15 17:37:35 UTC
Git commit dabac2291f335844420b1eb10ce74a586912c3a0 by Nate Graham.
Committed on 14/09/2020 at 23:35.
Pushed by ngraham into branch 'release/20.08'.

Fix list items with no subtitle not being centered
FIXED-IN: 20.08.2

M  +2    -5    src/qml/ListBrowserDelegate.qml