SUMMARY Code folding on "null record" does not work properly. OBSERVED RESULT If code is folded at a line like type thing is null record; then everything after that line down to the end of the file is folded. EXPECTED RESULT A fold should not be allowed instead. SOFTWARE/OS VERSIONS Linux/Xfce: 4.14 KDE Plasma Version: none KDE Frameworks Version: none Qt Version: 5.15.0 ADDITIONAL INFORMATION
Created attachment 131545 [details] wrong folded "null record"
Can you please supply the relevant code for testing purposes?
(In reply to Justin Zobel from comment #2) > Can you please supply the relevant code for testing purposes? Hi Justin, thanks for your work. Please find some examples on null-records here: https://github.com/Blunk-electronic/ada_training/blob/master/src/records_3/records_3.adb Best, Mario
Information supplied, moving back to reported status for investigation.
Thanks Mario, I can confirm this folds from null record; to the end of the file.
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/503
Git commit a22703c25934b7d1ff30e6b1dde47d94d1e2e19e by Christoph Cullmann, on behalf of Jonathan Poelen. Committed on 14/07/2023 at 21:31. Pushed by cullmann into branch 'master'. ADA: fix folding on "null record" ; add digit separator, based numeral and keywords - fix folding on `null record` ```ada type Car is record -- beginRegion=RecordRegion -- ..... end record -- endRegion=RecordRegion type Null_Record is null record; -- Before ~~~~~~ beginRegion=RecordRegion -- After ~~~~~~ no region ``` - new highlight: Base, Exponent ```ada 3#011201#e3 -- ^ Base -- ^ Decimal -- ^ Base -- ^ Exponent 3#0112401#e3 -- ^ Base -- ^ Decimal -- ^ Normal Text (4 is not valid in base 3) ``` A +164 -0 autotests/folding/test.adb.fold A +171 -0 autotests/html/test.adb.dark.html A +171 -0 autotests/html/test.adb.html A +164 -0 autotests/input/test.adb A +164 -0 autotests/reference/test.adb.ref M +167 -24 data/syntax/ada.xml https://invent.kde.org/frameworks/syntax-highlighting/-/commit/a22703c25934b7d1ff30e6b1dde47d94d1e2e19e