Bug 426344 - Please (re)consider adding a simple "Rename Tab" functionality in a tab's right-click menu
Summary: Please (re)consider adding a simple "Rename Tab" functionality in a tab's rig...
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: tabbar (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-09 16:05 UTC by shevegen
Modified: 2020-09-15 01:02 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.12
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shevegen 2020-09-09 16:05:43 UTC
I am running konsole 20.08.1 right now, compiled from source at:
    
    https://download.kde.org/stable/release-service/20.08.1/src/konsole-20.08.1.tar.xz

(I show the source so that this is not assumed to be a package-issue on
any distribution xyz; it is the vanilla source from upstream KDE. I tend
to stick to it without trying to make any modifications in general.)

Upon trying to rename the KDE konsole tab, via the right-click
mouse button press event, triggering a popup-widget, I get
these entries:

    Detach Tab
    Current Tab Settings
    Close

Close is quite simple to understand, and comes last, which makes sense to me.

Detach Tab I consider fairly useless but I don't mind really.

I actually tried to get a context menu entry point called "Rename Tab".

My memory may fail me, but wasn't there such an entry point available
in the past? I can rename the tab when I click on "Current Tab Settings",
and then on "Tab Title Format", but this requires two steps, whereas I
am almost sure that in the past a single step was enough.

My suggestion is:

- Could the "Rename Tab" be either brought back, or in the event that
it never existed in prior konsole versions (my memory is REALLY bad,
sorry), could it be added? I would suggest it to be situated above
"Close". Evidently putting "Close" on the bottom there makes sense,
so the only space would be above the "Close" entry point.

I also find it a bit strange, conceptually, to have users associate
"Rename Tab" with changing "Tab Title Format" - I don't quite want
to change the format, I only wanted to change the title of the tab
as-is. Or perhaps such an option exists and it was not compiled when
I batch-compiled KDE from source.

The above is really just a minor issue. I actually VERY rarely manually
rename tabs; I use ruby scripts. One uses qdbus (in the past dcop) to
quickly rename the tab e. g.

    rti Hello world!
    rti --unicode-snowman # We actually can use icons and
                          # unicode in the konsole tab; KDE konsole
                          # beats gnome-terminal with its eyes closed \o/
                          
Now you may rightfully ask "if you have a commandline script, why use
a GUI?" Yep, you are right in about 99.5% of the cases, but sometimes
I need to also make use of the GUI specifically. And that was one of
the cases. The reason was actually that I had data from a file displayed
via "cat bla.md", and I needed to write down that information onto a 
hard DVD, to keep track of some of the file content there (e. g. 
linux distributions). And by default, my ruby script shows the particular
qdbus command too (makes it easier to quickly copy/paste). I could
of course add --silent to that commandline script, but I'd still have to
hit enter and when you need to actually copy data from a computer to 
something like a DVD, when you also have multiple tabs to work with
at the same time (and KDE konsole is not the only application with
multiple tabs, e. g. palemoon typically has multiple tabs here too),
then you sort of don't want to touch/modify a particular KDE konsole
tab until you have finished that task. That is why in such a particular
case, I actually move that KDE tab to the very right side, so that I 
keep track of it, and have its content be as closely attached to the
bottom area in that tab as possible. I am not sure if that setup
makes sense to anyone else, but I almost use KDE konsole like a
mini-tabbed-WM. :)

Unfortunately I don't have an old copy of KDE konsole (I tend to
quickly clean up and remove old variants the moment I can compile
new stable KDE releases, which these days happens very well; almost
all the old issues I had in the last ~2 years went away, excluding
a few exceptions that may not be solely related to KDE itself), so
I can not easily test whether older KDE konsole releases showed
the same behaviour, or whether this was changed. I believe IF it
was changed, the reasoning behind that change could be reconsidered.

Worded differently: I don't mind more options, even if I don't use
them, but options that I think useful and that may be removed, I
do mind. Ideally we could have KDE transition into a totally 
user-customizable set of widgets, at all times, but I understand
that this is not within the scope of this suggestion - it's just
an idea. (I had very difficult discussions about UI design with
the gimp developers. IMO gimp's UI degraded over the years for
no reason that I can really understand. KDE kolourpaint is
literally awesome when it comes to UI, even though a few more 
features would be nice. Krita is way above my head, even though
it seems to be of high quality. I had a similar problem with
blender - great software, but too complicated. I was more
productive with wings3d. Sadly momentum in a project easily beats
any UI considerations in general, but I digress.)

So anyway for the TL; DR summary:

Please (re)consider adding a simple "Rename Tab" functionality,
above the "Close" Functionality, upon a right-click mouse
button press event on a tab in KDE Konsole.

PS: I am aware of the double left-mouse-button click, so the
above can be simplified a bit, but it is still two clicks,
and more importantly, my brain associates right button with
the context menu, and left click (one and double click) with
"actionables".
Comment 1 Maksym Hazevych 2020-09-09 22:22:33 UTC
Thanks for the report, but next time, please consider writing only tl;dr version. I'm shortening title.
Comment 2 Kevin Wilson 2020-09-11 23:19:05 UTC
I suppose we all differ, but I like the long bug report for context.  I think it's better to provide too much information than too little.  I agree that titles should be concise.
Comment 3 Nate Graham 2020-09-14 23:43:25 UTC
The wall of text is not particularly helpful for bug triagers. Easy fix though.
Comment 4 Bug Janitor Service 2020-09-14 23:49:37 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/214
Comment 5 Nate Graham 2020-09-15 01:02:43 UTC
Git commit c8bd9a816b4fd885f637a1c47d3ec0e0a85690ed by Nate Graham.
Committed on 14/09/2020 at 23:44.
Pushed by hindenburg into branch 'master'.

Re-word tab context menu's "Configure" item/dialog title for clarity

- Make it confirm to the Label HIG (must start with a verb)
- Remove the redundant word "Current", which is implied
- Add the word "Rename" for clarity
- Rename the name of the resulting dialog for clarity
FIXED-IN: 20.12

M  +1    -1    src/RenameTabDialog.cpp
M  +1    -1    src/session/SessionController.cpp
M  +1    -1    src/widgets/ViewContainer.cpp

https://invent.kde.org/utilities/konsole/commit/c8bd9a816b4fd885f637a1c47d3ec0e0a85690ed