Bug 426332 - Confirmed Face Tags Turned To Unconfirmed
Summary: Confirmed Face Tags Turned To Unconfirmed
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-Workflow (show other bugs)
Version: 7.2.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-09 07:21 UTC by rb2005
Modified: 2020-09-18 19:59 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/digikam/commit/b22be110df2d85da5c2563b6875314b4043b52dd
Version Fixed In: 7.2.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description rb2005 2020-09-09 07:21:12 UTC 
SUMMARY
Face tags previously confirmed turned to unconfirmed.

STEPS TO REPRODUCE
1. Scan for faces and enter names. Confirmed the tags name. Tags turned into "permanent" labels.
2. Move to the next image. Then return to the previous image with confirmed tags.
3. Tags confirmed have changed to "Confirm, cancel" prompts with the previously confirmed names in the suggestion label box.

OBSERVED RESULT
All previously confirmed tags turned into "Confirm-Cancel" prompts.

EXPECTED RESULT
Confirmed tags suppose to be labels in images.

SOFTWARE/OS VERSIONS
Windows: Windows 10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
digiKam-7.2.0-beta1-20200908T121020-Win64
Comment 1 rb2005 2020-09-09 07:41:04 UTC 
Correction: "Confirm-Remove" prompts
Comment 2 Maik Qualmann 2020-09-15 21:27:51 UTC 
Yes, the code is broken here at the moment, I'm fixing it step by step.

Maik
Comment 3 Maik Qualmann 2020-09-16 06:10:06 UTC 
Git commit b22be110df2d85da5c2563b6875314b4043b52dd by Maik Qualmann.
Committed on 16/09/2020 at 06:09.
Pushed by mqualmann into branch 'master'.

first step to fix AssignNameWidget
FIXED-IN: 7.2.0

M  +2    -1    NEWS
M  +2    -2    core/libs/database/tags/facetagsiface.cpp
M  +24   -7    core/utilities/facemanagement/items/facegroup.cpp
M  +3    -2    core/utilities/facemanagement/items/facegroup_p.cpp
M  +5    -2    core/utilities/facemanagement/widgets/assignnamewidget.cpp

https://invent.kde.org/graphics/digikam/commit/b22be110df2d85da5c2563b6875314b4043b52dd
Comment 4 rb2005 2020-09-18 18:59:25 UTC 
Tested and confirmed to be working as intended. Thanks for the up-keeping of this nice app.
Comment 5 caulier.gilles 2020-09-18 19:59:32 UTC 
Thanks for the feedback