Bug 426331 - The file digikam.exe contains no icons
Summary: The file digikam.exe contains no icons
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Bundle-Windows (show other bugs)
Version: 7.1.0
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-09 07:11 UTC by andrej.valencic
Modified: 2021-02-15 20:13 UTC (History)
12 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.2.0
Sentry Crash Report:


Attachments
Desktop shortcut (25.43 KB, image/jpeg)
2020-09-09 07:12 UTC, andrej.valencic
Details
Change icon dialog (280.62 KB, image/jpeg)
2020-09-09 07:12 UTC, andrej.valencic
Details
File Explorer view (127.50 KB, image/jpeg)
2020-09-09 07:13 UTC, andrej.valencic
Details
Uninstall.exe icon (63.14 KB, image/jpeg)
2020-09-09 12:38 UTC, andrej.valencic
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andrej.valencic 2020-09-09 07:11:45 UTC
SUMMARY
After update to 7.1.0 there is no DK icon for desktop shortcut and program itself.

STEPS TO REPRODUCE
1. Update DK from 7.0.0 to 7.1.0
2. Create a desktop shortcut - only the generic icon is present
3. Try to change icon via Properties
4. The error message about no icon appears

OBSERVED RESULT
Can not get the DK icon from digikam.exe (the same goes for showfoto.exe!). Even in the Explorer the program displays with only the generic Windows icon. Please see the attachments for details.

EXPECTED RESULT
To see the icons as in all previous versions: on desktop, taksbar, File Explorer, Start ...

SOFTWARE/OS VERSIONS
Windows: 10 - latest updates
(available in About System)
KDE Frameworks 5.73.0
Qt 5.15.0 (built against 5.15.0)
The windows windowing system

ADDITIONAL INFORMATION
I've also tried the beta version 7.2.0, the same problem is present
Comment 1 andrej.valencic 2020-09-09 07:12:34 UTC
Created attachment 131503 [details]
Desktop shortcut
Comment 2 andrej.valencic 2020-09-09 07:12:59 UTC
Created attachment 131504 [details]
Change icon dialog
Comment 3 andrej.valencic 2020-09-09 07:13:36 UTC
Created attachment 131505 [details]
File Explorer view
Comment 4 caulier.gilles 2020-09-09 07:29:25 UTC
And with the 7.0.0, the application icon was here ?

https://download.kde.org/Attic/digikam/7.0.0/

Gilles Caulier
Comment 5 caulier.gilles 2020-09-09 07:32:21 UTC
*** Bug 426333 has been marked as a duplicate of this bug. ***
Comment 6 andrej.valencic 2020-09-09 12:31:46 UTC
(In reply to caulier.gilles from comment #4)
> And with the 7.0.0, the application icon was here ?
> 
> https://download.kde.org/Attic/digikam/7.0.0/
> 
> Gilles Caulier

Yes, with the version 7.0.0 (and all the previousas well) this problem never occured.
Comment 7 andrej.valencic 2020-09-09 12:37:34 UTC
I also noted now that for the Uninstall.exe the icon is present as expected (see the attachment).
Comment 8 andrej.valencic 2020-09-09 12:38:02 UTC
Created attachment 131510 [details]
Uninstall.exe icon
Comment 9 marcoemarghe@inwind.it 2020-09-12 07:59:54 UTC
I fully confirmed what has been reported by @andrej.valencic
Same happened to me upgrading from 7.0.0 to 7.1.0 (it was working fine before)

Windows 10 build 19041.450 (latest windows update)

I looked for any icon in the digikam folder but the only one available is the one for the uninstall.exe (as reported already by Andrej
Comment 10 rickscheibner 2020-09-14 20:26:34 UTC
I'm also confirming this bug. It disappeared on Win10 (latest build) as soon as I upgraded dK to 7.1.0.  At least one other dK user that I've communicated with has had the same problem.
Comment 11 caulier.gilles 2020-09-19 11:27:15 UTC
*** Bug 426717 has been marked as a duplicate of this bug. ***
Comment 12 Ilgaz Öcal 2020-09-25 20:15:47 UTC
I just installed 7.2 beta 1 and it contains no icon too.
Comment 13 caulier.gilles 2020-10-04 13:49:52 UTC
The reason is listed below :

-- Could NOT find IcoTool (missing: IcoTool_EXECUTABLE) 
CMake Warning at /mnt/data/GIT/7.x/project/bundles/mxe/build.win64/usr/x86_64-w64-mingw32.shared/share/ECM/modules/ECMAddAppIcon.cmake:225 (message):
  Unable to find the icotool utilities or icons in matching sizes -
  application will not have an application icon!
Call Stack (most recent call first):
  core/app/DigikamTarget.cmake:16 (ecm_add_app_icon)
  core/app/CMakeLists.txt:56 (include)


-- Could NOT find IcoTool (missing: IcoTool_EXECUTABLE) 
CMake Warning at /mnt/data/GIT/7.x/project/bundles/mxe/build.win64/usr/x86_64-w64-mingw32.shared/share/ECM/modules/ECMAddAppIcon.cmake:225 (message):
  Unable to find the icotool utilities or icons in matching sizes -
  application will not have an application icon!
Call Stack (most recent call first):
  core/showfoto/CMakeLists.txt:49 (ecm_add_app_icon)

Since we upgrade KF5 to 5.74, the windows application icons are now integrated with icotool program from icoutils package instead png2ico.

Gilles Caulier
Comment 14 caulier.gilles 2020-10-04 14:00:53 UTC
Git commit 5d01d9583b9a29005e4bf3c623ecfcfbf9a67209 by Gilles Caulier.
Committed on 04/10/2020 at 13:59.
Pushed by cgilles into branch 'master'.

Remove Png2Ico and switch to IcoUtils. Check if icotool CLI program is available.

M  +0    -17   project/bundles/mxe/02-build-extralibs.sh
M  +11   -0    project/bundles/mxe/03-build-digikam.sh
M  +2    -1    project/bundles/mxe/README
D  +0    -30   project/bundles/mxe/png2ico/CMakeLists.txt
D  +0    -3    project/bundles/mxe/png2ico/README.txt
D  +0    -282  project/bundles/mxe/png2ico/png2ico.cpp
D  +0    -933  project/bundles/mxe/png2ico/qanihandler.cpp
D  +0    -77   project/bundles/mxe/png2ico/qanihandler.h
D  +0    -868  project/bundles/mxe/png2ico/qcurhandler.cpp
D  +0    -77   project/bundles/mxe/png2ico/qcurhandler.h
D  +0    -867  project/bundles/mxe/png2ico/qicohandler.cpp
D  +0    -76   project/bundles/mxe/png2ico/qicohandler.h

https://invent.kde.org/graphics/digikam/commit/5d01d9583b9a29005e4bf3c623ecfcfbf9a67209
Comment 15 caulier.gilles 2020-10-04 16:35:25 UTC
Fixed : https://i.imgur.com/I4WyKX5.png

Gilles Caulier
Comment 16 Maik Qualmann 2020-10-15 15:31:22 UTC
*** Bug 427757 has been marked as a duplicate of this bug. ***
Comment 17 Maik Qualmann 2020-12-23 20:49:52 UTC
*** Bug 430761 has been marked as a duplicate of this bug. ***
Comment 18 Maik Qualmann 2021-01-03 14:25:13 UTC
*** Bug 431102 has been marked as a duplicate of this bug. ***
Comment 19 Chris Peterson 2021-01-21 00:52:43 UTC
*** Bug 431808 has been marked as a duplicate of this bug. ***
Comment 20 Maik Qualmann 2021-02-15 20:13:23 UTC
*** Bug 432982 has been marked as a duplicate of this bug. ***