Bug 426210 - Rows heights in different sections are inconsistent
Summary: Rows heights in different sections are inconsistent
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_keys (other bugs)
Version First Reported In: unspecified
Platform: Neon Linux
: NOR minor
Target Milestone: ---
Assignee: Michael Jansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-05 13:05 UTC by Patrick Silva
Modified: 2020-09-14 15:37 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (59.85 KB, image/png)
2020-09-05 13:05 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-09-05 13:05:36 UTC
Created attachment 131431 [details]
screenshot

SUMMARY
The rows under "Common actions" have lower height than the ones under "System services" and "Applications". See the attached screenshot please.

EXPECTED RESULT
all rows should have the same height

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2
Comment 1 Nate Graham 2020-09-08 13:22:25 UTC
Seems to be caused by the "Applications" list items not having buttons on hover, which leads to them having a lower implicit height.
Comment 2 Nate Graham 2020-09-08 13:23:43 UTC
Could be fixed in the KCM itself by manually changing the list item heights, or maybe Kirigami would be a better place, to ensure that list items always have a minimum height that's tall enough to fix hover buttons if they *would* show up. Judgment call really.
Comment 3 David Redondo 2020-09-08 13:25:38 UTC
Nothing to do with Kirigami though, because it's an AbstractListItem with custom contentItem. In the kcm all the delegates need to have the same implicirHeight
Comment 4 Bug Janitor Service 2020-09-14 14:48:00 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/151
Comment 5 David Redondo 2020-09-14 15:37:29 UTC
Git commit 690149e381964553b6987fbcf48404eb39a232ea by David Redondo.
Committed on 14/09/2020 at 14:46.
Pushed by davidre into branch 'master'.

Set a height for the list items

All delgates in all sections will have the same height.

M  +3    -2    kcms/keys/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/690149e381964553b6987fbcf48404eb39a232ea